From: kernel test robot <lkp@intel.com>
To: SeongJae Park <sj@kernel.org>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [sj:damon/next 130/142] samples/damon/mtier.c:78:30: warning: unused variable 'region'
Date: Tue, 17 Feb 2026 15:33:25 +0800 [thread overview]
Message-ID: <202602171530.NsLdPVOF-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/sj/linux.git damon/next
head: 53a936b437ade97f957569534f1460d23883b94f
commit: 52639cde20a9887c5df4acc55fb51a4f48a1644d [130/142] samples/damon/mtier: replace damon_add_region() with damon_set_regions()
config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20260217/202602171530.NsLdPVOF-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 15.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260217/202602171530.NsLdPVOF-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202602171530.NsLdPVOF-lkp@intel.com/
All warnings (new ones prefixed by >>):
samples/damon/mtier.c: In function 'damon_sample_mtier_build_ctx':
>> samples/damon/mtier.c:78:30: warning: unused variable 'region' [-Wunused-variable]
78 | struct damon_region *region;
| ^~~~~~
vim +/region +78 samples/damon/mtier.c
749cc6533b6621 Yunjeong Mun 2025-07-08 72
82a08bde3cf7bb SeongJae Park 2025-04-20 73 static struct damon_ctx *damon_sample_mtier_build_ctx(bool promote)
82a08bde3cf7bb SeongJae Park 2025-04-20 74 {
82a08bde3cf7bb SeongJae Park 2025-04-20 75 struct damon_ctx *ctx;
82a08bde3cf7bb SeongJae Park 2025-04-20 76 struct damon_attrs attrs;
82a08bde3cf7bb SeongJae Park 2025-04-20 77 struct damon_target *target;
82a08bde3cf7bb SeongJae Park 2025-04-20 @78 struct damon_region *region;
82a08bde3cf7bb SeongJae Park 2025-04-20 79 struct damos *scheme;
82a08bde3cf7bb SeongJae Park 2025-04-20 80 struct damos_quota_goal *quota_goal;
82a08bde3cf7bb SeongJae Park 2025-04-20 81 struct damos_filter *filter;
749cc6533b6621 Yunjeong Mun 2025-07-08 82 struct region_range addr;
52639cde20a988 SeongJae Park 2026-02-15 83 struct damon_addr_range range;
749cc6533b6621 Yunjeong Mun 2025-07-08 84 int ret;
82a08bde3cf7bb SeongJae Park 2025-04-20 85
82a08bde3cf7bb SeongJae Park 2025-04-20 86 ctx = damon_new_ctx();
82a08bde3cf7bb SeongJae Park 2025-04-20 87 if (!ctx)
82a08bde3cf7bb SeongJae Park 2025-04-20 88 return NULL;
82a08bde3cf7bb SeongJae Park 2025-04-20 89 attrs = (struct damon_attrs) {
82a08bde3cf7bb SeongJae Park 2025-04-20 90 .sample_interval = 5 * USEC_PER_MSEC,
82a08bde3cf7bb SeongJae Park 2025-04-20 91 .aggr_interval = 100 * USEC_PER_MSEC,
82a08bde3cf7bb SeongJae Park 2025-04-20 92 .ops_update_interval = 60 * USEC_PER_MSEC * MSEC_PER_SEC,
82a08bde3cf7bb SeongJae Park 2025-04-20 93 .min_nr_regions = 10,
82a08bde3cf7bb SeongJae Park 2025-04-20 94 .max_nr_regions = 1000,
82a08bde3cf7bb SeongJae Park 2025-04-20 95 };
82a08bde3cf7bb SeongJae Park 2025-04-20 96
82a08bde3cf7bb SeongJae Park 2025-04-20 97 /*
82a08bde3cf7bb SeongJae Park 2025-04-20 98 * auto-tune sampling and aggregation interval aiming 4% DAMON-observed
82a08bde3cf7bb SeongJae Park 2025-04-20 99 * accesses ratio, keeping sampling interval in [5ms, 10s] range.
82a08bde3cf7bb SeongJae Park 2025-04-20 100 */
82a08bde3cf7bb SeongJae Park 2025-04-20 101 attrs.intervals_goal = (struct damon_intervals_goal) {
82a08bde3cf7bb SeongJae Park 2025-04-20 102 .access_bp = 400, .aggrs = 3,
82a08bde3cf7bb SeongJae Park 2025-04-20 103 .min_sample_us = 5000, .max_sample_us = 10000000,
82a08bde3cf7bb SeongJae Park 2025-04-20 104 };
82a08bde3cf7bb SeongJae Park 2025-04-20 105 if (damon_set_attrs(ctx, &attrs))
82a08bde3cf7bb SeongJae Park 2025-04-20 106 goto free_out;
82a08bde3cf7bb SeongJae Park 2025-04-20 107 if (damon_select_ops(ctx, DAMON_OPS_PADDR))
82a08bde3cf7bb SeongJae Park 2025-04-20 108 goto free_out;
82a08bde3cf7bb SeongJae Park 2025-04-20 109
82a08bde3cf7bb SeongJae Park 2025-04-20 110 target = damon_new_target();
82a08bde3cf7bb SeongJae Park 2025-04-20 111 if (!target)
82a08bde3cf7bb SeongJae Park 2025-04-20 112 goto free_out;
82a08bde3cf7bb SeongJae Park 2025-04-20 113 damon_add_target(ctx, target);
749cc6533b6621 Yunjeong Mun 2025-07-08 114
749cc6533b6621 Yunjeong Mun 2025-07-08 115 if (detect_node_addresses) {
749cc6533b6621 Yunjeong Mun 2025-07-08 116 ret = promote ? nid_to_phys(1, &addr) : nid_to_phys(0, &addr);
749cc6533b6621 Yunjeong Mun 2025-07-08 117 if (ret)
749cc6533b6621 Yunjeong Mun 2025-07-08 118 goto free_out;
749cc6533b6621 Yunjeong Mun 2025-07-08 119 } else {
749cc6533b6621 Yunjeong Mun 2025-07-08 120 addr.start = promote ? node1_start_addr : node0_start_addr;
749cc6533b6621 Yunjeong Mun 2025-07-08 121 addr.end = promote ? node1_end_addr : node0_end_addr;
749cc6533b6621 Yunjeong Mun 2025-07-08 122 }
749cc6533b6621 Yunjeong Mun 2025-07-08 123
52639cde20a988 SeongJae Park 2026-02-15 124 range.start = addr.start;
52639cde20a988 SeongJae Park 2026-02-15 125 range.end = addr.end;
52639cde20a988 SeongJae Park 2026-02-15 126
52639cde20a988 SeongJae Park 2026-02-15 127 ret = damon_set_regions(target, &range, 1, DAMON_MIN_REGION_SZ);
52639cde20a988 SeongJae Park 2026-02-15 128 if (ret)
82a08bde3cf7bb SeongJae Park 2025-04-20 129 goto free_out;
82a08bde3cf7bb SeongJae Park 2025-04-20 130
82a08bde3cf7bb SeongJae Park 2025-04-20 131 scheme = damon_new_scheme(
82a08bde3cf7bb SeongJae Park 2025-04-20 132 /* access pattern */
82a08bde3cf7bb SeongJae Park 2025-04-20 133 &(struct damos_access_pattern) {
82a08bde3cf7bb SeongJae Park 2025-04-20 134 .min_sz_region = PAGE_SIZE,
82a08bde3cf7bb SeongJae Park 2025-04-20 135 .max_sz_region = ULONG_MAX,
82a08bde3cf7bb SeongJae Park 2025-04-20 136 .min_nr_accesses = promote ? 1 : 0,
82a08bde3cf7bb SeongJae Park 2025-04-20 137 .max_nr_accesses = promote ? UINT_MAX : 0,
82a08bde3cf7bb SeongJae Park 2025-04-20 138 .min_age_region = 0,
82a08bde3cf7bb SeongJae Park 2025-04-20 139 .max_age_region = UINT_MAX},
82a08bde3cf7bb SeongJae Park 2025-04-20 140 /* action */
82a08bde3cf7bb SeongJae Park 2025-04-20 141 promote ? DAMOS_MIGRATE_HOT : DAMOS_MIGRATE_COLD,
82a08bde3cf7bb SeongJae Park 2025-04-20 142 1000000, /* apply interval (1s) */
82a08bde3cf7bb SeongJae Park 2025-04-20 143 &(struct damos_quota){
82a08bde3cf7bb SeongJae Park 2025-04-20 144 /* 200 MiB per sec by most */
82a08bde3cf7bb SeongJae Park 2025-04-20 145 .reset_interval = 1000,
82a08bde3cf7bb SeongJae Park 2025-04-20 146 .sz = 200 * 1024 * 1024,
82a08bde3cf7bb SeongJae Park 2025-04-20 147 /* ignore size of region when prioritizing */
82a08bde3cf7bb SeongJae Park 2025-04-20 148 .weight_sz = 0,
82a08bde3cf7bb SeongJae Park 2025-04-20 149 .weight_nr_accesses = 100,
82a08bde3cf7bb SeongJae Park 2025-04-20 150 .weight_age = 100,
82a08bde3cf7bb SeongJae Park 2025-04-20 151 },
82a08bde3cf7bb SeongJae Park 2025-04-20 152 &(struct damos_watermarks){},
82a08bde3cf7bb SeongJae Park 2025-04-20 153 promote ? 0 : 1); /* migrate target node id */
82a08bde3cf7bb SeongJae Park 2025-04-20 154 if (!scheme)
82a08bde3cf7bb SeongJae Park 2025-04-20 155 goto free_out;
82a08bde3cf7bb SeongJae Park 2025-04-20 156 damon_set_schemes(ctx, &scheme, 1);
82a08bde3cf7bb SeongJae Park 2025-04-20 157 quota_goal = damos_new_quota_goal(
82a08bde3cf7bb SeongJae Park 2025-04-20 158 promote ? DAMOS_QUOTA_NODE_MEM_USED_BP :
82a08bde3cf7bb SeongJae Park 2025-04-20 159 DAMOS_QUOTA_NODE_MEM_FREE_BP,
c5e67d40a10234 Yunjeong Mun 2025-06-27 160 promote ? node0_mem_used_bp : node0_mem_free_bp);
82a08bde3cf7bb SeongJae Park 2025-04-20 161 if (!quota_goal)
82a08bde3cf7bb SeongJae Park 2025-04-20 162 goto free_out;
82a08bde3cf7bb SeongJae Park 2025-04-20 163 quota_goal->nid = 0;
82a08bde3cf7bb SeongJae Park 2025-04-20 164 damos_add_quota_goal(&scheme->quota, quota_goal);
82a08bde3cf7bb SeongJae Park 2025-04-20 165 filter = damos_new_filter(DAMOS_FILTER_TYPE_YOUNG, true, promote);
82a08bde3cf7bb SeongJae Park 2025-04-20 166 if (!filter)
82a08bde3cf7bb SeongJae Park 2025-04-20 167 goto free_out;
82a08bde3cf7bb SeongJae Park 2025-04-20 168 damos_add_filter(scheme, filter);
82a08bde3cf7bb SeongJae Park 2025-04-20 169 return ctx;
82a08bde3cf7bb SeongJae Park 2025-04-20 170 free_out:
82a08bde3cf7bb SeongJae Park 2025-04-20 171 damon_destroy_ctx(ctx);
82a08bde3cf7bb SeongJae Park 2025-04-20 172 return NULL;
82a08bde3cf7bb SeongJae Park 2025-04-20 173 }
82a08bde3cf7bb SeongJae Park 2025-04-20 174
:::::: The code at line 78 was first introduced by commit
:::::: 82a08bde3cf7bbbe90de57baa181bebf676582c7 samples/damon: implement a DAMON module for memory tiering
:::::: TO: SeongJae Park <sj@kernel.org>
:::::: CC: Andrew Morton <akpm@linux-foundation.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2026-02-17 7:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-17 7:33 kernel test robot [this message]
2026-02-17 15:20 ` [sj:damon/next 130/142] samples/damon/mtier.c:78:30: warning: unused variable 'region' SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202602171530.NsLdPVOF-lkp@intel.com \
--to=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.