All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lukas Straub <lukasstraub2@web.de>
To: qemu-devel@nongnu.org
Cc: Peter Xu <peterx@redhat.com>, Fabiano Rosas <farosas@suse.de>,
	 Laurent Vivier <lvivier@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	 Zhang Chen <zhangckid@gmail.com>,
	 Hailiang Zhang <zhanghailiang@xfusion.com>,
	 Markus Armbruster <armbru@redhat.com>,
	Li Zhijian <lizhijian@fujitsu.com>,
	 "Dr. David Alan Gilbert" <dave@treblig.org>,
	 Lukas Straub <lukasstraub2@web.de>
Subject: [PATCH v9 09/19] Call colo_release_ram_cache() after multifd threads terminate
Date: Wed, 18 Feb 2026 22:29:29 +0100	[thread overview]
Message-ID: <20260218-colo_unit_test_multifd-v9-9-d8dbdb0ca6f6@web.de> (raw)
In-Reply-To: <20260218-colo_unit_test_multifd-v9-0-d8dbdb0ca6f6@web.de>

The multifd threads still may access the colo cache, so release it
only after they terminate.

Reviewed-by: Fabiano Rosas <farosas@suse.de>
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Lukas Straub <lukasstraub2@web.de>
---
 migration/colo.c      | 3 ---
 migration/migration.c | 3 +++
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/migration/colo.c b/migration/colo.c
index 97a224c39c49ff2269f375db47112458cab0b4cb..96102c9d0fb3b60e063c81ce07b730011bc4919f 100644
--- a/migration/colo.c
+++ b/migration/colo.c
@@ -949,7 +949,4 @@ void coroutine_fn colo_incoming_co(void)
     /* Wait checkpoint incoming thread exit before free resource */
     qemu_thread_join(&th);
     bql_lock();
-
-    /* We hold the global BQL, so it is safe here */
-    colo_release_ram_cache();
 }
diff --git a/migration/migration.c b/migration/migration.c
index dba5d6ede579da42693d5270ede9660fb145238a..f36d42ef657bdf26d78ca642d77a9b76e1c0c174 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -454,6 +454,9 @@ void migration_incoming_state_destroy(void)
      * BQL and retake unconditionally.
      */
     assert(bql_locked());
+    if (migrate_colo()) {
+        colo_release_ram_cache();
+    }
     qemu_loadvm_state_cleanup(mis);
 
     if (mis->to_src_file) {

-- 
2.39.5



  parent reply	other threads:[~2026-02-18 21:31 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-18 21:29 [PATCH v9 00/19] migration: Add COLO multifd support and COLO migration unit test Lukas Straub
2026-02-18 21:29 ` [PATCH v9 01/19] MAINTAINERS: Add myself as maintainer for COLO migration framework Lukas Straub
2026-02-18 21:29 ` [PATCH v9 02/19] MAINTAINERS: Remove Hailiang Zhang from " Lukas Straub
2026-02-18 21:29 ` [PATCH v9 03/19] colo: Setup ram cache in normal migration path Lukas Straub
2026-02-18 21:29 ` [PATCH v9 04/19] colo: Replace migration_incoming_colo_enabled() with migrate_colo() Lukas Straub
2026-02-18 21:29 ` [PATCH v9 05/19] colo: Remove ENABLE_COLO savevm command and mark it as deprecated Lukas Straub
2026-02-18 21:29 ` [PATCH v9 06/19] ram: Remove colo special-casing Lukas Straub
2026-02-18 21:29 ` [PATCH v9 07/19] multifd: Move ram state receive into multifd_ram_state_recv() Lukas Straub
2026-02-18 21:29 ` [PATCH v9 08/19] multifd: Add COLO support Lukas Straub
2026-02-18 21:29 ` Lukas Straub [this message]
2026-02-18 21:29 ` [PATCH v9 10/19] colo: Fix crash during device vmstate load Lukas Straub
2026-02-18 21:29 ` [PATCH v9 11/19] colo: Hold the BQL while sending ram state Lukas Straub
2026-02-18 21:29 ` [PATCH v9 12/19] colo: Do not hold the BQL while receiving " Lukas Straub
2026-02-18 21:29 ` [PATCH v9 13/19] migration-test: Add COLO migration unit test Lukas Straub
2026-02-18 21:29 ` [PATCH v9 14/19] Convert colo main documentation to restructuredText Lukas Straub
2026-02-18 21:29 ` [PATCH v9 15/19] qemu-colo.rst: Miscellaneous changes Lukas Straub
2026-02-18 21:29 ` [PATCH v9 16/19] qemu-colo.rst: Add my copyright Lukas Straub
2026-02-18 21:29 ` [PATCH v9 17/19] qemu-colo.rst: Simplify the block replication setup Lukas Straub
2026-02-18 21:29 ` [PATCH v9 18/19] multifd: Fix hang if send thread errors during sync Lukas Straub
2026-02-19 21:23   ` Peter Xu
2026-02-18 21:29 ` [PATCH v9 19/19] colo: Fix a rare crash during shutdown Lukas Straub
2026-02-19 21:33   ` Peter Xu
2026-02-26 10:43     ` Lukas Straub

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260218-colo_unit_test_multifd-v9-9-d8dbdb0ca6f6@web.de \
    --to=lukasstraub2@web.de \
    --cc=armbru@redhat.com \
    --cc=dave@treblig.org \
    --cc=farosas@suse.de \
    --cc=lizhijian@fujitsu.com \
    --cc=lvivier@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=zhangckid@gmail.com \
    --cc=zhanghailiang@xfusion.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.