All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: George Abraham P <george.abraham.p@intel.com>
Cc: bhelgaas@google.com, linux-pci@vger.kernel.org,
	linux-kernel@vger.kernel.org, giovanni.cabiddu@intel.com,
	Wei Huang <wei.huang2@amd.com>, Jing Liu <jing2.liu@intel.com>,
	Paul Luse <paul.e.luse@linux.intel.com>,
	Eric Van Tassell <Eric.VanTassell@amd.com>,
	Yishai Hadas <yishaih@nvidia.com>
Subject: Re: [PATCH V2 RESEND] PCI/TPH: Skip Root Port completer check for RC_END devices
Date: Wed, 18 Feb 2026 10:42:54 +0200	[thread overview]
Message-ID: <20260218084254.GA10368@unreal> (raw)
In-Reply-To: <564e872c-ecc0-479c-86c3-68b5d3fda512@intel.com>

On Wed, Feb 18, 2026 at 10:24:28AM +0530, George Abraham P wrote:
> [+cc TPH authors that were missed in the previous mail]
> 
> On 09-Jan-26 10:59 AM, George Abraham P wrote:
> > Root Complex Integrated Endpoint devices (PCI_EXP_TYPE_RC_END) are
> > directly integrated into the root complex and do not have an
> > associated Root Port in the traditional PCIe hierarchy. The current
> > TPH implementation incorrectly attempts to find and check a Root Port's
> > TPH completer capability for these devices.
> > 
> > Add a check to skip Root Port completer type verification for RC_END
> > devices, allowing them to use their full TPH requester capability
> > without being limited by a non-existent Root Port's completer support.
> > 
> > For RC_END devices, the root complex itself acts as the TPH completer,
> > and this relationship is handled differently than the standard
> > endpoint-to-Root-Port model.
> > 
> > Fixes: f69767a1ada3 ("PCI: Add TLP Processing Hints (TPH) support")
> > Signed-off-by: George Abraham P <george.abraham.p@intel.com>
> > ---
> > v1->v2:
> >   - Added "Fixes:" tag to link the commit hash that introduced the code

I do not have a strong preference; I am fine with adding a Fixes tag or
leaving it out. Up to commit 2961f841b025, pcie_enable_tph() is called
in two drivers: bnxt and mlx5. Which of these devices is the RC_END
device?

Thanks

  reply	other threads:[~2026-02-18  8:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-09  5:29 [PATCH V2 RESEND] PCI/TPH: Skip Root Port completer check for RC_END devices George Abraham P
2026-02-18  4:54 ` George Abraham P
2026-02-18  8:42   ` Leon Romanovsky [this message]
2026-02-18 15:30     ` George Abraham P
2026-02-27  7:08       ` Wei Huang
2026-02-18 20:58 ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260218084254.GA10368@unreal \
    --to=leon@kernel.org \
    --cc=Eric.VanTassell@amd.com \
    --cc=bhelgaas@google.com \
    --cc=george.abraham.p@intel.com \
    --cc=giovanni.cabiddu@intel.com \
    --cc=jing2.liu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=paul.e.luse@linux.intel.com \
    --cc=wei.huang2@amd.com \
    --cc=yishaih@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.