All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: stian@itx.no
Cc: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	"David S. Miller" <davem@davemloft.net>,
	Andreas Larsson <andreas@gaisler.com>,
	sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] sparc: Fix page alignment in dma mapping
Date: Wed, 18 Feb 2026 10:48:26 +0200	[thread overview]
Message-ID: <20260218084826.GB10368@unreal> (raw)
In-Reply-To: <20260217171104.5643-3-stian@itx.no>

On Tue, Feb 17, 2026 at 06:10:19PM +0100, stian@itx.no wrote:
> From: Stian Halseth <stian@itx.no>
> 
> 'phys' may include an offset within the page, while 'base_paddr' is already
> page-aligned. This caused incorrect DMA mapping in dma_4u_map_phys and
> dma_4v_map_phys.
> 
> Fix both functions by masking phys with IO_PAGE_MASK or subtracting the
> page offset, covering both generic SPARC code and sun4v.
> 
> Fixes: 38c0d0ebf520 ("sparc: Use physical address DMA mapping")
> Reported-by: Stian Halseth <stian@itx.no>
> Closes: https://github.com/sparclinux/issues/issues/75
> Suggested-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Signed-off-by: Stian Halseth <stian@itx.no>
> ---
>  arch/sparc/kernel/iommu.c     | 2 ++
>  arch/sparc/kernel/pci_sun4v.c | 2 +-
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 

Thanks,
Reviewed-by: Leon Romanovsky <leon@kernel.org>

  reply	other threads:[~2026-02-18  8:48 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-17 16:21 [PATCH] sparc: iommu/pci_sun4v: fix page alignment in dma mapping stian
2026-02-17 16:38 ` John Paul Adrian Glaubitz
2026-02-17 16:48   ` Stian Halseth
2026-02-17 17:16     ` John Paul Adrian Glaubitz
2026-02-17 17:25       ` Leon Romanovsky
2026-02-17 17:33         ` Stian Halseth
2026-02-17 17:52           ` Leon Romanovsky
2026-02-17 19:41             ` Stian Halseth
2026-02-17 19:43               ` John Paul Adrian Glaubitz
2026-02-17 17:10   ` [PATCH v2] sparc: Fix " stian
2026-02-18  8:48     ` Leon Romanovsky [this message]
2026-02-18 10:28     ` Marek Szyprowski
2026-02-18 11:09       ` Stian Halseth
2026-02-18 11:14         ` Leon Romanovsky
2026-02-18 11:40         ` Marek Szyprowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260218084826.GB10368@unreal \
    --to=leon@kernel.org \
    --cc=andreas@gaisler.com \
    --cc=davem@davemloft.net \
    --cc=glaubitz@physik.fu-berlin.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=sparclinux@vger.kernel.org \
    --cc=stian@itx.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.