From: Stephen Hemminger <stephen@networkplumber.org>
To: "Matthieu Baerts (NGI0)" <matttbe@kernel.org>
Cc: David Ahern <dsahern@kernel.org>,
netdev@vger.kernel.org, mptcp@lists.linux.dev
Subject: Re: [PATCH iproute2 1/2] mptcp: monitor: also show iface name
Date: Wed, 18 Feb 2026 10:31:55 -0800 [thread overview]
Message-ID: <20260218103155.486d20ee@phoenix.local> (raw)
In-Reply-To: <20260211-mptcp-color-v1-1-01832777611d@kernel.org>
On Wed, 11 Feb 2026 13:03:17 +0100
"Matthieu Baerts (NGI0)" <matttbe@kernel.org> wrote:
> @@ -530,7 +541,7 @@ static int mptcp_monitor_msg(struct rtnl_ctrl_data *ctrl,
> if (tb[MPTCP_ATTR_TIMEOUT])
> printf(" timeout=%u", rta_getattr_u32(tb[MPTCP_ATTR_TIMEOUT]));
> if (tb[MPTCP_ATTR_IF_IDX])
> - printf(" ifindex=%d", rta_getattr_s32(tb[MPTCP_ATTR_IF_IDX]));
> + print_iface(rta_getattr_s32(tb[MPTCP_ATTR_IF_IDX]));
> if (tb[MPTCP_ATTR_RESET_REASON])
> printf(" reset_reason=%u", rta_getattr_u32(tb[MPTCP_ATTR_RESET_REASON]));
> if (tb[MPTCP_ATTR_RESET_FLAGS])
The whole monitor message output format here is divergent from what other
iproute2 commands do. If you look at ip monitor there are no '=' signs
in the output.
Please fix the whole function. Ideally all of iproute commands should
support JSON in monitor mode as well. But that is a bigger effort.
next prev parent reply other threads:[~2026-02-18 18:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-11 12:03 [PATCH iproute2 0/2] mptcp: support colors & display iface name Matthieu Baerts (NGI0)
2026-02-11 12:03 ` [PATCH iproute2 1/2] mptcp: monitor: also show " Matthieu Baerts (NGI0)
2026-02-18 18:31 ` Stephen Hemminger [this message]
2026-02-18 19:03 ` Matthieu Baerts
2026-02-19 17:11 ` Stephen Hemminger
2026-02-19 17:38 ` Matthieu Baerts
2026-02-19 19:22 ` Stephen Hemminger
2026-02-19 19:26 ` Matthieu Baerts
2026-02-11 12:03 ` [PATCH iproute2 2/2] mptcp: display addr & ifname in color Matthieu Baerts (NGI0)
2026-02-18 4:00 ` [PATCH iproute2 0/2] mptcp: support colors & display iface name patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260218103155.486d20ee@phoenix.local \
--to=stephen@networkplumber.org \
--cc=dsahern@kernel.org \
--cc=matttbe@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.