From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 98D96E9A047 for ; Wed, 18 Feb 2026 16:24:44 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vskLl-0001nH-J0; Wed, 18 Feb 2026 11:24:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vskLi-0001ma-Fz for qemu-devel@nongnu.org; Wed, 18 Feb 2026 11:24:26 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vskLg-0007Sl-1Y for qemu-devel@nongnu.org; Wed, 18 Feb 2026 11:24:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1771431861; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aw1HzjFWge1vEsrcG/YJ1W7QE+by5aok+RMwqtqUpks=; b=Sj2TmMPkLk9Lpa3uKDWuukRD/RTLO7X30Llhm8o9ROcaJH8uenj9lvEnvF4YyifFtRARWC OijF+Z0S87mcuIh0BmrQtzsdpcq179YUSUHI3audfTAItjWT8aHMTO4ukjUHw8AoqYRydW FGO4KNxGr4v2mjSmYrmUg07sjgvg0Io= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-500-QG4l8dWSPE-osFNK0xilfQ-1; Wed, 18 Feb 2026 11:24:18 -0500 X-MC-Unique: QG4l8dWSPE-osFNK0xilfQ-1 X-Mimecast-MFC-AGG-ID: QG4l8dWSPE-osFNK0xilfQ_1771431857 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 88AA9195FDE0; Wed, 18 Feb 2026 16:24:17 +0000 (UTC) Received: from localhost (unknown [10.2.16.8]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id AFA821956095; Wed, 18 Feb 2026 16:24:16 +0000 (UTC) Date: Wed, 18 Feb 2026 11:24:15 -0500 From: Stefan Hajnoczi To: Jens Axboe Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, fam@euphon.net Subject: Re: [PATCH 2/2] fdmon-io_uring: check CQ ring directly in gsource_check Message-ID: <20260218162415.GD587447@fedora> References: <20260213143225.161043-1-axboe@kernel.dk> <20260213143225.161043-3-axboe@kernel.dk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="tWgUKc8+1fV9tv0o" Content-Disposition: inline In-Reply-To: <20260213143225.161043-3-axboe@kernel.dk> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass client-ip=170.10.133.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.043, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org --tWgUKc8+1fV9tv0o Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Feb 13, 2026 at 07:26:37AM -0700, Jens Axboe wrote: > gsource_check() only looks at the ppoll revents for the io_uring fd, > but CQEs can be posted during gsource_prepare()'s io_uring_submit() > call via kernel task_work processing on syscall exit. These completions > are already sitting in the CQ ring but the ring fd may not be signaled > yet, causing gsource_check() to return false. >=20 > Add a fallback io_uring_cq_ready() check so completions that arrive > during submission are dispatched immediately rather than waiting for > the next ppoll() cycle. >=20 > Signed-off-by: Jens Axboe > --- > util/fdmon-io_uring.c | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) Reviewed-by: Stefan Hajnoczi --tWgUKc8+1fV9tv0o Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAmmV568ACgkQnKSrs4Gr c8howgf/X5bLv/MyXj037RtW1sd1CqyAB89dMKXTC2yIZl5zZZqLhoIvflplYPG6 FYaKUNfBSAp1/FUd43IYRs7/WBIL3OxRirNv8dajjXR+L1ytnqkqhUEiREt/mzGH 6GmuKXvXOt+iDKusVRzMaW08zRUqnAh7KfTQEv6+yp5sYk5n+fReHL6W5AYt9rQf PkrZzgIm1JseVl0sHV9sBPS/ZRAyUXXVN9CtFqR8xz5/BdwZD0aI1Jj7vL6eLRcX zV3t6jCt0BHjgGeXtpOIlTbS8gn9AtkTwz6QmmDE6f7dHkIETYe59aaj1koAcwY1 7IfPF82uNObiGG8MTkLYh/07W6iMwQ== =Xb2V -----END PGP SIGNATURE----- --tWgUKc8+1fV9tv0o--