Re: [PATCH v3 06/35] fsverity: pass digest size and hash of the empty block to ->write

[Christoph Hellwig <hch@lst.de>]

On Wed, Feb 18, 2026 at 01:17:52PM +0100, Andrey Albershteyn wrote:
> On 2026-02-18 07:18:34, Christoph Hellwig wrote:
> > On Wed, Feb 18, 2026 at 12:19:06AM +0100, Andrey Albershteyn wrote:
> > > Let filesystem iterate over hashes in the block and check if these are
> > > hashes of zeroed data blocks. XFS will use this to decide if it want to
> > > store tree block full of these hashes.
> > 
> > Does it make sense to pass in the zero_digest vs just having a global
> > symbol or accessor?  This should be static information.
> 
> I think this won't work if we have two filesystems with different
> block sizes and therefore different merkle block sizes => different
> hash.

Looking at this a bit more - you're storing the entirely zero_digest
in struct merkle_tree_params, which is embedded intothe
fsverity_info.  This means that you can trivially access it using an
accessor of the fsverity_inode.

It also means that you actually bloat that structure quite a bit for
constant file system wide information.  Maybe it's time to split
out the file system wide part of it into a separate structure?
Eric?