From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from verein.lst.de (verein.lst.de [213.95.11.211])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4600A21FF33
	for <fsverity@lists.linux.dev>; Thu, 19 Feb 2026 06:00:27 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1771480828; cv=none; b=n+RdszSM1rDPtDQckPGze3Zn5tIYcvMgYhWo/sKmxHgRe0M9qGCuFtFiLLyWF6Q+N/o+GBAuKyQmeiIpxInjF+0JPVXuhaJF8Bi8dPE+d4gI53G4cLCRxFl5nEdz0X/x6CINfL9Zzf2YktwvexHM7tQPdcSZZjJrhVy4aWmO/Wo=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1771480828; c=relaxed/simple;
	bh=lHwxlVVdiSiQsHLzUHIuDSlfIIypmm1ylC5H49bGhvM=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=iqbVhs2HsWxW9gDGocM4qnMuF3niSdbzW4EUh5NXldDQRQa2NgnB1JG4NVqxOz+k7QYeRgJtI3Q8Uk1i0hpvy9rQ5Q+2pTsvxSbvEHPWcDRRSP2cprHcJ9qZ8aqSJs0RL7yfuvteSVleNq89DMhE2lZde7sFjdmgT60+vquI0R4=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de
Received: by verein.lst.de (Postfix, from userid 2407)
	id 4C57D68C7B; Thu, 19 Feb 2026 07:00:25 +0100 (CET)
Date: Thu, 19 Feb 2026 07:00:24 +0100
From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Andrey Albershteyn <aalbersh@kernel.org>, linux-xfs@vger.kernel.org,
	fsverity@lists.linux.dev, linux-fsdevel@vger.kernel.org,
	ebiggers@kernel.org, hch@lst.de
Subject: Re: [PATCH v3 07/35] iomap: introduce IOMAP_F_FSVERITY
Message-ID: <20260219060024.GB3739@lst.de>
References: <20260217231937.1183679-1-aalbersh@kernel.org> <20260217231937.1183679-8-aalbersh@kernel.org> <20260218230348.GF6467@frogsfrogsfrogs>
Precedence: bulk
X-Mailing-List: fsverity@lists.linux.dev
List-Id: <fsverity.lists.linux.dev>
List-Subscribe: <mailto:fsverity+subscribe@lists.linux.dev>
List-Unsubscribe: <mailto:fsverity+unsubscribe@lists.linux.dev>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20260218230348.GF6467@frogsfrogsfrogs>
User-Agent: Mutt/1.5.17 (2007-11-01)

On Wed, Feb 18, 2026 at 03:03:48PM -0800, Darrick J. Wong wrote:
> >  		old_size = iter->inode->i_size;
> > -		if (pos + written > old_size) {
> > +		if (pos + written > old_size &&
> > +		    !(iter->iomap.flags & IOMAP_F_FSVERITY)) {
> 
> I think this flag should be called IOMAP_F_POSTEOF since there's no
> "fsverity" logic dependent on this flag; it merely allows read/write
> access to folios beyond EOF without any of the usual clamping and
> zeroing...

There are fsverity-specific semantics attached because of the
magic hash handling for holes.