From: kernel test robot <lkp@intel.com>
To: Ian Ray <ian.ray@gehealthcare.com>,
Guenter Roeck <linux@roeck-us.net>,
Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: oe-kbuild-all@lists.linux.dev,
"Ian Ray" <ian.ray@gehealthcare.com>,
"Bence Csókás" <bence98@sch.bme.hu>,
"Tomaž Zaman" <tomaz@mono.si>,
linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH V2 2/3] hwmon: (ina2xx) Make it easier to add more devices
Date: Fri, 20 Feb 2026 02:54:42 +0100 [thread overview]
Message-ID: <202602200201.hafkm9wo-lkp@intel.com> (raw)
In-Reply-To: <20260219130127.87901-3-ian.ray@gehealthcare.com>
Hi Ian,
kernel test robot noticed the following build warnings:
[auto build test WARNING on groeck-staging/hwmon-next]
[also build test WARNING on robh/for-next linus/master v6.19 next-20260219]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Ian-Ray/dt-bindings-hwmon-ti-ina2xx-Add-INA234-device/20260219-210940
base: https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next
patch link: https://lore.kernel.org/r/20260219130127.87901-3-ian.ray%40gehealthcare.com
patch subject: [PATCH V2 2/3] hwmon: (ina2xx) Make it easier to add more devices
config: x86_64-rhel-9.4 (https://download.01.org/0day-ci/archive/20260220/202602200201.hafkm9wo-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260220/202602200201.hafkm9wo-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202602200201.hafkm9wo-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/hwmon/ina2xx.c: In function 'ina2xx_is_visible':
>> drivers/hwmon/ina2xx.c:722:25: warning: unused variable 'chip' [-Wunused-variable]
722 | enum ina2xx_ids chip = data->chip;
| ^~~~
vim +/chip +722 drivers/hwmon/ina2xx.c
5a56a39be7ffb4 Alex Qiu 2020-05-04 714
814db9f1b8ec1c Guenter Roeck 2024-07-24 715 static umode_t ina2xx_is_visible(const void *_data, enum hwmon_sensor_types type,
814db9f1b8ec1c Guenter Roeck 2024-07-24 716 u32 attr, int channel)
814db9f1b8ec1c Guenter Roeck 2024-07-24 717 {
814db9f1b8ec1c Guenter Roeck 2024-07-24 718 const struct ina2xx_data *data = _data;
de0da6ae1908b4 Guenter Roeck 2024-08-27 719 bool has_alerts = data->config->has_alerts;
52172ad87a22ed Wenliang Yan 2024-11-06 720 bool has_power_average = data->config->has_power_average;
0337abb760db03 Ian Ray 2026-02-19 721 bool has_update_interval = data->config->has_update_interval;
814db9f1b8ec1c Guenter Roeck 2024-07-24 @722 enum ina2xx_ids chip = data->chip;
814db9f1b8ec1c Guenter Roeck 2024-07-24 723
814db9f1b8ec1c Guenter Roeck 2024-07-24 724 switch (type) {
814db9f1b8ec1c Guenter Roeck 2024-07-24 725 case hwmon_in:
814db9f1b8ec1c Guenter Roeck 2024-07-24 726 switch (attr) {
814db9f1b8ec1c Guenter Roeck 2024-07-24 727 case hwmon_in_input:
814db9f1b8ec1c Guenter Roeck 2024-07-24 728 return 0444;
814db9f1b8ec1c Guenter Roeck 2024-07-24 729 case hwmon_in_lcrit:
814db9f1b8ec1c Guenter Roeck 2024-07-24 730 case hwmon_in_crit:
de0da6ae1908b4 Guenter Roeck 2024-08-27 731 if (has_alerts)
814db9f1b8ec1c Guenter Roeck 2024-07-24 732 return 0644;
814db9f1b8ec1c Guenter Roeck 2024-07-24 733 break;
814db9f1b8ec1c Guenter Roeck 2024-07-24 734 case hwmon_in_lcrit_alarm:
814db9f1b8ec1c Guenter Roeck 2024-07-24 735 case hwmon_in_crit_alarm:
de0da6ae1908b4 Guenter Roeck 2024-08-27 736 if (has_alerts)
814db9f1b8ec1c Guenter Roeck 2024-07-24 737 return 0444;
814db9f1b8ec1c Guenter Roeck 2024-07-24 738 break;
814db9f1b8ec1c Guenter Roeck 2024-07-24 739 default:
814db9f1b8ec1c Guenter Roeck 2024-07-24 740 break;
814db9f1b8ec1c Guenter Roeck 2024-07-24 741 }
814db9f1b8ec1c Guenter Roeck 2024-07-24 742 break;
814db9f1b8ec1c Guenter Roeck 2024-07-24 743 case hwmon_curr:
814db9f1b8ec1c Guenter Roeck 2024-07-24 744 switch (attr) {
814db9f1b8ec1c Guenter Roeck 2024-07-24 745 case hwmon_curr_input:
814db9f1b8ec1c Guenter Roeck 2024-07-24 746 return 0444;
4d5c2d986757e4 Guenter Roeck 2024-08-28 747 case hwmon_curr_lcrit:
4d5c2d986757e4 Guenter Roeck 2024-08-28 748 case hwmon_curr_crit:
de0da6ae1908b4 Guenter Roeck 2024-08-27 749 if (has_alerts)
4d5c2d986757e4 Guenter Roeck 2024-08-28 750 return 0644;
4d5c2d986757e4 Guenter Roeck 2024-08-28 751 break;
4d5c2d986757e4 Guenter Roeck 2024-08-28 752 case hwmon_curr_lcrit_alarm:
4d5c2d986757e4 Guenter Roeck 2024-08-28 753 case hwmon_curr_crit_alarm:
de0da6ae1908b4 Guenter Roeck 2024-08-27 754 if (has_alerts)
4d5c2d986757e4 Guenter Roeck 2024-08-28 755 return 0444;
4d5c2d986757e4 Guenter Roeck 2024-08-28 756 break;
814db9f1b8ec1c Guenter Roeck 2024-07-24 757 default:
814db9f1b8ec1c Guenter Roeck 2024-07-24 758 break;
814db9f1b8ec1c Guenter Roeck 2024-07-24 759 }
814db9f1b8ec1c Guenter Roeck 2024-07-24 760 break;
814db9f1b8ec1c Guenter Roeck 2024-07-24 761 case hwmon_power:
814db9f1b8ec1c Guenter Roeck 2024-07-24 762 switch (attr) {
814db9f1b8ec1c Guenter Roeck 2024-07-24 763 case hwmon_power_input:
814db9f1b8ec1c Guenter Roeck 2024-07-24 764 return 0444;
814db9f1b8ec1c Guenter Roeck 2024-07-24 765 case hwmon_power_crit:
de0da6ae1908b4 Guenter Roeck 2024-08-27 766 if (has_alerts)
814db9f1b8ec1c Guenter Roeck 2024-07-24 767 return 0644;
814db9f1b8ec1c Guenter Roeck 2024-07-24 768 break;
814db9f1b8ec1c Guenter Roeck 2024-07-24 769 case hwmon_power_crit_alarm:
de0da6ae1908b4 Guenter Roeck 2024-08-27 770 if (has_alerts)
814db9f1b8ec1c Guenter Roeck 2024-07-24 771 return 0444;
814db9f1b8ec1c Guenter Roeck 2024-07-24 772 break;
52172ad87a22ed Wenliang Yan 2024-11-06 773 case hwmon_power_average:
52172ad87a22ed Wenliang Yan 2024-11-06 774 if (has_power_average)
52172ad87a22ed Wenliang Yan 2024-11-06 775 return 0444;
52172ad87a22ed Wenliang Yan 2024-11-06 776 break;
814db9f1b8ec1c Guenter Roeck 2024-07-24 777 default:
814db9f1b8ec1c Guenter Roeck 2024-07-24 778 break;
814db9f1b8ec1c Guenter Roeck 2024-07-24 779 }
814db9f1b8ec1c Guenter Roeck 2024-07-24 780 break;
814db9f1b8ec1c Guenter Roeck 2024-07-24 781 case hwmon_chip:
814db9f1b8ec1c Guenter Roeck 2024-07-24 782 switch (attr) {
814db9f1b8ec1c Guenter Roeck 2024-07-24 783 case hwmon_chip_update_interval:
0337abb760db03 Ian Ray 2026-02-19 784 if (has_update_interval)
814db9f1b8ec1c Guenter Roeck 2024-07-24 785 return 0644;
814db9f1b8ec1c Guenter Roeck 2024-07-24 786 break;
814db9f1b8ec1c Guenter Roeck 2024-07-24 787 default:
814db9f1b8ec1c Guenter Roeck 2024-07-24 788 break;
814db9f1b8ec1c Guenter Roeck 2024-07-24 789 }
814db9f1b8ec1c Guenter Roeck 2024-07-24 790 break;
814db9f1b8ec1c Guenter Roeck 2024-07-24 791 default:
814db9f1b8ec1c Guenter Roeck 2024-07-24 792 break;
814db9f1b8ec1c Guenter Roeck 2024-07-24 793 }
814db9f1b8ec1c Guenter Roeck 2024-07-24 794 return 0;
814db9f1b8ec1c Guenter Roeck 2024-07-24 795 }
814db9f1b8ec1c Guenter Roeck 2024-07-24 796
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2026-02-20 1:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-19 13:01 [PATCH V2 0/3] hwmon: INA234 Ian Ray
2026-02-19 13:01 ` [PATCH V2 1/3] dt-bindings: hwmon: ti,ina2xx: Add INA234 device Ian Ray
2026-02-19 13:01 ` [PATCH V2 2/3] hwmon: (ina2xx) Make it easier to add more devices Ian Ray
2026-02-19 15:59 ` Guenter Roeck
2026-02-19 20:44 ` Bence Csókás
2026-02-20 1:13 ` kernel test robot
2026-02-20 1:54 ` kernel test robot [this message]
2026-02-19 13:01 ` [PATCH V2 3/3] hwmon: (ina2xx) Add support for INA234 Ian Ray
2026-02-19 20:45 ` Bence Csókás
2026-02-21 7:02 ` [PATCH V2 0/3] hwmon: INA234 Jens Almer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202602200201.hafkm9wo-lkp@intel.com \
--to=lkp@intel.com \
--cc=bence98@sch.bme.hu \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=ian.ray@gehealthcare.com \
--cc=krzk@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=robh@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=tomaz@mono.si \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.