Re: [LTP] [PATCH v2 1/1] [STAGING] ioctl_pidfd06: accept EREMOTE/ESRCH for PIDFD_GET_INFO across pidns

[Petr Vorel <pvorel@suse.cz>]

...
> > +static const int exp_errnos[] = {EREMOTE, ESRCH};

> >  static void run(void)
> >  {
> > @@ -41,7 +42,8 @@ static void run(void)
> >  	args->exit_signal = SIGCHLD;


> I would be stricter for new kernels, we do not want the new value
> reverted back by an accident. So what about:

So we might want to add this to ground rules.

> static int err_nr = ARRAY_SIZE(exp_errnos);

> static void setup(void)
> {
> 	...
> 	if (tst_kvercmp(9, 19, 0) >= 0)
> 		err_nr = 1;
> 	...
> }

+1

> >  	if (!SAFE_CLONE(args)) {
> > -		TST_EXP_FAIL(ioctl(pidfd, PIDFD_GET_INFO, info), ESRCH);
> > +		TST_EXP_FAIL_ARR(ioctl(pidfd, PIDFD_GET_INFO, info), exp_errnos,
> > +				ARRAY_SIZE(exp_errnos));
> 				^
> 				err_nr

+1

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp