From: Christoph Hellwig <hch@lst.de>
To: John Garry <john.g.garry@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>,
axboe@kernel.dk, linux-block@vger.kernel.org
Subject: Re: [PATCH] block: Correct comment on bio_alloc_clone()
Date: Fri, 20 Feb 2026 16:43:24 +0100 [thread overview]
Message-ID: <20260220154324.GA14632@lst.de> (raw)
In-Reply-To: <26f345ba-9cb6-49ad-89f4-1ce0153fd86c@oracle.com>
On Fri, Feb 20, 2026 at 03:36:41PM +0000, John Garry wrote:
>
> So I can have this:
>
> * Allocate a new bio that is a clone of @bio_src. The caller owns the
> returned
> * bio, but not the actual data it points to, bi_io_vec.
Well, bi_io_vec isn't really the data, but the indirection pointing
to the data. I guess we need to come up with consistent terminology
first before we can make good sense of this.
Allocate a new bio that is a clone of @bio_src. This reuses the bio_vecs
pointed to by @bio_src->bi_io_vec, and clones the iterator pointing to
the current position in it. The caller owns the returned bio, but not
the bio_vecs, and must ensure the bio is freed before the memory
pointed to by @bio_Src->bi_io_vecs.
next prev parent reply other threads:[~2026-02-20 15:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-20 14:32 [PATCH] block: Correct comment on bio_alloc_clone() John Garry
2026-02-20 15:10 ` Christoph Hellwig
2026-02-20 15:36 ` John Garry
2026-02-20 15:43 ` Christoph Hellwig [this message]
2026-02-20 15:55 ` John Garry
2026-02-20 15:57 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260220154324.GA14632@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=john.g.garry@oracle.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.