Re: [PATCH 3/6] nvme: always issue I/O Command Set specific Identify Namespace

[Christoph Hellwig <hch@lst.de>]

On Thu, Feb 19, 2026 at 08:28:06PM -0700, Caleb Sander Mateos wrote:
> Currently, the I/O Command Set specific Identify Namespace structure is
> only fetched for controllers that support extended LBA formats. This is
> because struct nvme_id_ns_nvm is only used by nvme_configure_pi_elbas(),
> which is only called when the ELBAS bit is set in the CTRATT field of
> the Identify Controller structure.
> 
> However, the I/O Command Set specific Identify Namespace structure will
> soon be used in nvme_config_discard(), so always try to obtain it in
> nvme_update_ns_info_block() if the controller supports NVMe version 2.0
> or later.

This was done kinda intentionally to avoid extra roundtrips and
tripping over buggy implementations.  But I think you have a good
use case to extent this, so:

Reviewed-by: Christoph Hellwig <hch@lst.de>

>  			goto out;
>  	}
>  
> -- 
> 2.45.2
---end quoted text---