All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Gabriel Goller <g.goller@proxmox.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
	Jonathan Corbet <corbet@lwn.net>,
	Shuah Khan <skhan@linuxfoundation.org>,
	netdev@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] docs: net: document neigh gc_interval and gc_stale_time sysctls
Date: Fri, 20 Feb 2026 16:43:44 -0800	[thread overview]
Message-ID: <20260220164344.68ab2a6a@kernel.org> (raw)
In-Reply-To: <20260219162200.510325-1-g.goller@proxmox.com>

On Thu, 19 Feb 2026 17:21:58 +0100 Gabriel Goller wrote:
> +neigh/default/gc_interval - INTEGER
> +	How often the garbage collector for neighbor entries should run. This
> +	value applies to the entire table, not individual entries.
> +
> +	Default: 30 seconds

AI suggests that this value is not actually currently used
in our implementation. I can't find any use either, TBH.
It's read and can be written but it's seemingly not used for anything.

> +neigh/default/gc_stale_time - INTEGER
> +	Determines how long a neighbor entry can remain unused before it is
> +	considered stale and eligible for garbage collection. Entries that have
> +	not been used for longer than this time will be removed by the garbage
> +	collector, unless they have active references, are marked as PERMANENT,
> +	or carry the NTF_EXT_LEARNED or NTF_EXT_VALIDATED flag.
> +
> +	Default: 60 seconds

AI adds:

  Important caveat: This check is only reached when total_entries >= gc_thresh1
  (line 1000-1001). Below that threshold, the periodic GC skips the scan
  entirely.

If true I think we should mention that ?
-- 
pw-bot: cr

  parent reply	other threads:[~2026-02-21  0:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-19 16:21 [PATCH net-next] docs: net: document neigh gc_interval and gc_stale_time sysctls Gabriel Goller
2026-02-19 16:50 ` Keller, Jacob E
2026-02-21  0:43 ` Jakub Kicinski [this message]
2026-02-23  9:54   ` Gabriel Goller
2026-02-23 10:23 ` Gabriel Goller
2026-02-23 22:58   ` Jakub Kicinski
2026-02-24  9:06     ` Gabriel Goller
2026-02-25  0:01       ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260220164344.68ab2a6a@kernel.org \
    --to=kuba@kernel.org \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=g.goller@proxmox.com \
    --cc=horms@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.