From: Stephen Hemminger <stephen@networkplumber.org>
To: longli@linux.microsoft.com
Cc: dev@dpdk.org, Wei Hu <weh@microsoft.com>,
stable@dpdk.org, Dariusz Sosnowski <dsosnowski@nvidia.com>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
Bing Zhao <bingz@nvidia.com>, Ori Kam <orika@nvidia.com>,
Suanming Mou <suanmingm@nvidia.com>,
Matan Azrad <matan@nvidia.com>, Long Li <longli@microsoft.com>
Subject: Re: [PATCH v2 1/8] net/netvsc: secondary ignore promiscuous enable/disable
Date: Fri, 20 Feb 2026 21:16:14 -0800 [thread overview]
Message-ID: <20260220211614.44f6b3df@phoenix.local> (raw)
In-Reply-To: <20260221024540.659098-1-longli@linux.microsoft.com>
On Fri, 20 Feb 2026 18:45:20 -0800
longli@linux.microsoft.com wrote:
> diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c
> index 6584819f4f..5d7b410f1b 100644
> --- a/drivers/net/netvsc/hn_ethdev.c
> +++ b/drivers/net/netvsc/hn_ethdev.c
> @@ -480,6 +480,9 @@ hn_dev_promiscuous_enable(struct rte_eth_dev *dev)
> {
> struct hn_data *hv = dev->data->dev_private;
>
> + if (rte_eal_process_type() != RTE_PROC_PRIMARY)
> + return 0;
You might want to return -ENOTSUP rather than silently allowing secondary
to think it worked.
next prev parent reply other threads:[~2026-02-21 5:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-21 2:45 [PATCH v2 1/8] net/netvsc: secondary ignore promiscuous enable/disable longli
2026-02-21 2:45 ` [PATCH v2 2/8] net/netvsc: fix race conditions on VF add/remove events longli
2026-02-23 17:40 ` Stephen Hemminger
2026-02-23 17:43 ` Stephen Hemminger
2026-02-23 22:31 ` [EXTERNAL] " Long Li
2026-02-21 2:45 ` [PATCH v2 3/8] net/netvsc: add multi-process VF device removal support longli
2026-02-23 17:45 ` Stephen Hemminger
2026-02-23 22:32 ` [EXTERNAL] " Long Li
2026-02-21 2:45 ` [PATCH v2 4/8] net/mana: fix PD resource leak on device close longli
2026-02-21 2:45 ` [PATCH v2 5/8] net/netvsc: fix devargs memory leak on hotplug longli
2026-02-21 2:45 ` [PATCH v2 6/8] net/mana: fix fast-path ops setup in secondary process longli
2026-02-21 2:45 ` [PATCH v2 7/8] net/mlx5: " longli
2026-02-21 2:45 ` [PATCH v2 8/8] net/mlx4: " longli
2026-02-21 5:16 ` Stephen Hemminger [this message]
2026-02-23 23:25 ` [EXTERNAL] Re: [PATCH v2 1/8] net/netvsc: secondary ignore promiscuous enable/disable Long Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260220211614.44f6b3df@phoenix.local \
--to=stephen@networkplumber.org \
--cc=bingz@nvidia.com \
--cc=dev@dpdk.org \
--cc=dsosnowski@nvidia.com \
--cc=longli@linux.microsoft.com \
--cc=longli@microsoft.com \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=stable@dpdk.org \
--cc=suanmingm@nvidia.com \
--cc=viacheslavo@nvidia.com \
--cc=weh@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.