All of lore.kernel.org
 help / color / mirror / Atom feed
From: Taha Ed-Dafili <0rayn.dev@gmail.com>
To: dlechner@baylibre.com
Cc: 0rayn.dev@gmail.com, Michael.Hennerich@analog.com,
	andy@kernel.org, corbet@lwn.net, jic23@kernel.org,
	lars@metafoo.de, linux-doc@vger.kernel.org,
	linux-iio@vger.kernel.org,
	linux-kernel-mentees-archive@lists.linuxfoundation.org,
	linux-kernel@vger.kernel.org, nuno.sa@analog.com,
	rdunlap@infradead.org, skhan@linuxfoundation.org
Subject: Re: [PATCH v4 3/4] iio: accel: adxl345: Implement event scaling for ABI compliance
Date: Sat, 21 Feb 2026 17:21:23 +0000	[thread overview]
Message-ID: <20260221172123.57134-1-0rayn.dev@gmail.com> (raw)
In-Reply-To: <e2c74e7f-d851-457f-88f8-d80a8d17c51f@baylibre.com>

I did go over the datasheet and found the hardware uses a single
register for both tap thresholds, so I assume the VALUE was intentionally
omitted from DOUBLETAP to avoid duplicate sysfs attributes.

I mechanically added the scale attribute without realizing this. I will
drop BIT(IIO_EV_INFO_SCALE) for double tap and update the docs in v5.

I'll wait a couple of days for any other feedback before sending the
next version.

  reply	other threads:[~2026-02-21 17:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-21 14:12 [PATCH v4 0/4] iio: accel: adxl345: Implement event scaling and ABI compliance Taha Ed-Dafili
2026-02-21 14:12 ` [PATCH v4 1/4] docs: iio: adxl345: fix typos and grammar Taha Ed-Dafili
2026-02-21 14:12 ` [PATCH v4 2/4] iio: core: Add IIO_EV_INFO_SCALE to event info Taha Ed-Dafili
2026-02-21 14:12 ` [PATCH v4 3/4] iio: accel: adxl345: Implement event scaling for ABI compliance Taha Ed-Dafili
2026-02-21 16:47   ` David Lechner
2026-02-21 17:21     ` Taha Ed-Dafili [this message]
2026-02-22 16:11       ` Jonathan Cameron
2026-02-21 14:12 ` [PATCH v4 4/4] docs: iio: adxl345: update math and examples for scaling Taha Ed-Dafili
2026-02-21 16:50   ` David Lechner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260221172123.57134-1-0rayn.dev@gmail.com \
    --to=0rayn.dev@gmail.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=andy@kernel.org \
    --cc=corbet@lwn.net \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel-mentees-archive@lists.linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=rdunlap@infradead.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.