From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9468D246BC5; Sat, 21 Feb 2026 19:44:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771703055; cv=none; b=FGFarW4HRxR8r3otAzk/pl8fpAWpwI8A+8hlhhBGWVpUyYNXTwSrepjOkjYZ5r7pr0TP9Kmbnh6zhlM4KqQ/4VrGFXR4sHTDblqv2ce5Gu+aFkHFk2zqKklWxhf6wN48LMFLCayKqGXDm579JanSu81F1z9BpSNxV/gaxgYdDtg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771703055; c=relaxed/simple; bh=Bz42mS4nINBFpY1zgbijQciA8eCm/Tci8KwUrRAfnlI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TlKFxrJcTtEtOu9GSCCS15WDEfnm+To60MKTiPqEWySsFTvUjWQ+8Ep3PYzCt89Ec0Dt2Qy5wiYUbEc1u01YyrYTDTXGrWVU6YH6kJ4FvZ5rkGPQYXDk+LjAGA8aVCDhyW0YWjwrtassqzVEMT9xtJf6DcyP05iaD4H3SPEV65Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=XjRdJowU; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="XjRdJowU" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C7132C4CEF7; Sat, 21 Feb 2026 19:44:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1771703055; bh=Bz42mS4nINBFpY1zgbijQciA8eCm/Tci8KwUrRAfnlI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XjRdJowUeJujb+nzZjrFgTNx4IBh9BGCWdkMA/MqEkgwnPYHe4+yhcw7kBgiXuHXL b+EhdyDouWWjazyhDJ1Q5O9wSzVSyicEBcxxuYYRLFD/28y6cJHtDMvyd7qK+3NMm/ AWPPKJnRFdybBakZcm7WVtdB5LvYT9ykfWWagf3zN8OeqLpvhccqcRAV8C9TINvTq8 /i1YCJUCI7lugGG75mltIL8L/RyUhUywbHHGx4+2msanggMZBFoe1VdBZY7fmiP4NW kmQFclFS5So7WfVXGavsul7ECOQ5zVYH1xJ6nQij0MyQWwUXpIupJ7Z4EMdZRRddu6 9RBhEva+gcqkg== Date: Sat, 21 Feb 2026 11:44:02 -0800 From: Eric Biggers To: Christoph Hellwig Cc: "Theodore Y. Ts'o" , Jaegeuk Kim , Andreas Dilger , Chao Yu , Christian Brauner , "Darrick J. Wong" , linux-fscrypt@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 2/9] fscrypt: pass a byte offset to fscrypt_mergeable_bio Message-ID: <20260221194402.GB2536@quark> References: <20260218061531.3318130-1-hch@lst.de> <20260218061531.3318130-3-hch@lst.de> Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260218061531.3318130-3-hch@lst.de> On Wed, Feb 18, 2026 at 07:14:40AM +0100, Christoph Hellwig wrote: > Logical offsets into an inode are usually expresssed as bytes in the VFS. expresssed => expressed, in all the commit messages > /** > * fscrypt_mergeable_bio_bh() - test whether data can be added to a bio > * @bio: the bio being built up > * @next_bh: the next buffer_head for which I/O will be submitted > * > * Same as fscrypt_mergeable_bio(), except this takes a buffer_head instead of > * an inode and block number directly. Above comment needs "block number" => "file position". (Or "file offset" if you want. I think "file position" makes more sense, given that the variable is called 'pos'. Either way, "block number" is definitely wrong.) - Eric From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2F28DC61DEB for ; Sat, 21 Feb 2026 20:04:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: Reply-To:From:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:In-Reply-To:MIME-Version:References: Message-ID:To:Date:Sender:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jOT4xCDyqCklEzOvB+Y+KwR+EjNNRgPwySLSjJwcoPM=; b=dvIj4DBp8/iT8nL1udMA7OR1mK tdVREh4YAs1WTeTXThLYk7WvXZTiAmcRlYA4WMtn3/0Qg3hZQX3Js+14LSHjr65OiCWWwOkPQzc6U quert2GUdWwxu3ezvBetxyTitg0ePm9qQGq1gziQxghS6tZ6oFw8oX6iQzg5NjVTU4xE=; Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1vttCv-0006JC-Rq; Sat, 21 Feb 2026 20:04:05 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1vttCu-0006Iv-AT for linux-f2fs-devel@lists.sourceforge.net; Sat, 21 Feb 2026 20:04:04 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=iwgUiioQn+O/hgHxNNaY7qQbiVcrgjkdlMtHw7+rQcc=; b=VYrF1z0VcmrNiUDVCRp3bZld1x CfjsQ6z7vW5lkjNuRB212pgw+D/nm2LDtN5UmYWcADx1ppdGOMbKFx1zZOae5s8NPdBKbmlLq1Ks1 oi9ACa/U870K7MOOy6wmIPOFGUdXpq7MwmSB6ZGaNMqnwjfTDlg6ZpyqLJsGhSRarYKQ=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=iwgUiioQn+O/hgHxNNaY7qQbiVcrgjkdlMtHw7+rQcc=; b=aaSsjZ8NX0mb2DJ/16OSIv6C2r BXhpHU1/OR7q7H2qU7NApCKozbVddNq6so8BPSrmqBBZMEK6Q1qiBsrvR+CmKouBEHh6QGOKJlms7 7IrrF04krOeZFYcvnwRyUhpPTT7XCcZbKqQarSzGLMr5Fnf0qkOHXi3IHswKq2maT3Os=; Received: from sea.source.kernel.org ([172.234.252.31]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1vtstt-0002o8-Kz for linux-f2fs-devel@lists.sourceforge.net; Sat, 21 Feb 2026 19:44:26 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 434D743E0E; Sat, 21 Feb 2026 19:44:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C7132C4CEF7; Sat, 21 Feb 2026 19:44:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1771703055; bh=Bz42mS4nINBFpY1zgbijQciA8eCm/Tci8KwUrRAfnlI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XjRdJowUeJujb+nzZjrFgTNx4IBh9BGCWdkMA/MqEkgwnPYHe4+yhcw7kBgiXuHXL b+EhdyDouWWjazyhDJ1Q5O9wSzVSyicEBcxxuYYRLFD/28y6cJHtDMvyd7qK+3NMm/ AWPPKJnRFdybBakZcm7WVtdB5LvYT9ykfWWagf3zN8OeqLpvhccqcRAV8C9TINvTq8 /i1YCJUCI7lugGG75mltIL8L/RyUhUywbHHGx4+2msanggMZBFoe1VdBZY7fmiP4NW kmQFclFS5So7WfVXGavsul7ECOQ5zVYH1xJ6nQij0MyQWwUXpIupJ7Z4EMdZRRddu6 9RBhEva+gcqkg== Date: Sat, 21 Feb 2026 11:44:02 -0800 To: Christoph Hellwig Message-ID: <20260221194402.GB2536@quark> References: <20260218061531.3318130-1-hch@lst.de> <20260218061531.3318130-3-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260218061531.3318130-3-hch@lst.de> X-Headers-End: 1vtstt-0002o8-Kz Subject: Re: [f2fs-dev] [PATCH 2/9] fscrypt: pass a byte offset to fscrypt_mergeable_bio X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Eric Biggers via Linux-f2fs-devel Reply-To: Eric Biggers Cc: Christian Brauner , "Theodore Y. Ts'o" , "Darrick J. Wong" , linux-f2fs-devel@lists.sourceforge.net, linux-fscrypt@vger.kernel.org, Andreas Dilger , linux-fsdevel@vger.kernel.org, Jaegeuk Kim , linux-ext4@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Wed, Feb 18, 2026 at 07:14:40AM +0100, Christoph Hellwig wrote: > Logical offsets into an inode are usually expresssed as bytes in the VFS. expresssed => expressed, in all the commit messages > /** > * fscrypt_mergeable_bio_bh() - test whether data can be added to a bio > * @bio: the bio being built up > * @next_bh: the next buffer_head for which I/O will be submitted > * > * Same as fscrypt_mergeable_bio(), except this takes a buffer_head instead of > * an inode and block number directly. Above comment needs "block number" => "file position". (Or "file offset" if you want. I think "file position" makes more sense, given that the variable is called 'pos'. Either way, "block number" is definitely wrong.) - Eric _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel