Re: [PATCH] hw/i386/amd_iommu.c: fix amdvi_unhandled_command logging cmd ID

[Igor Mammedov <imammedo@redhat.com>]

On Fri, 20 Feb 2026 19:14:37 +0100
David Hoppenbrouwers <qemu@demindiro.com> wrote:

> The command ID is in cmd[0], not cmd[1].
pls add a reference to the spec,
and if any what impact it does have on a guest/how it manifests.

> Signed-off-by: David Hoppenbrouwers <qemu@demindiro.com>
> ---
>  hw/i386/amd_iommu.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c
> index 789e09d6f2..2570a4701c 100644
> --- a/hw/i386/amd_iommu.c
> +++ b/hw/i386/amd_iommu.c
> @@ -1456,9 +1456,9 @@ static void amdvi_cmdbuf_exec(AMDVIState *s)
>          amdvi_inval_all(s, cmd);
>          break;
>      default:
> -        trace_amdvi_unhandled_command(extract64(cmd[1], 60, 4));
> +        trace_amdvi_unhandled_command(extract64(cmd[0], 60, 4));
>          /* log illegal command */
> -        amdvi_log_illegalcom_error(s, extract64(cmd[1], 60, 4),
> +        amdvi_log_illegalcom_error(s, extract64(cmd[0], 60, 4),
>                                     s->cmdbuf + s->cmdbuf_head);
>      }
>  }