All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Rachit Dhar <rchtdhr@gmail.com>
Cc: Viresh Kumar <vireshk@kernel.org>,
	Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>,
	greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/4] staging: greybus: fixed styling issue in fw-management.c
Date: Mon, 23 Feb 2026 14:53:27 +0100	[thread overview]
Message-ID: <2026022313-velocity-unwieldy-dd40@gregkh> (raw)
In-Reply-To: <CAJH1ELAO0VXJUC5s8W6KhVO4=4BA_ir94KDte+V87Vt-Sq6Ykw@mail.gmail.com>

On Mon, Feb 16, 2026 at 10:33:59AM +0530, Rachit Dhar wrote:
> On Sat, Feb 7, 2026 at 7:08 PM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > What specific style issue was fixed?  Please be specific.
> >
> > Also, your patches were not correctly linked together.  Please use
> > something like 'git send-email' to send them all at once.  Otherwise
> > they get lost and out-of-order as you can see in the email archives on
> > lore.kernel.org.
> 
> The style issue fixed was for the following checkpatch check:
> 
> CHECK: Alignment should match open parenthesis
> #437: FILE: drivers/staging/greybus/fw-management.c:437:
> +               ret = fw_mgmt_load_and_validate_operation(fw_mgmt,
> +                               intf_load.load_method, intf_load.firmware_tag);
> 
> Thanks for pointing out the issue of out-of-order patches.
> I did use git send-email, but did so for each patch separately,
> which might have led to this. If I should send another patch series
> to correct this, please let me know.

I can't take these as-is, so yes, please rebase and resend the remaining
ones.

thanks,

greg k-h

      reply	other threads:[~2026-02-23 13:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-04 18:30 [PATCH v3 2/4] staging: greybus: fixed styling issue in fw-management.c Rachit Dhar
2026-02-07 13:37 ` Greg Kroah-Hartman
2026-02-16  5:03   ` Rachit Dhar
2026-02-23 13:53     ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026022313-velocity-unwieldy-dd40@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=elder@kernel.org \
    --cc=greybus-dev@lists.linaro.org \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=rchtdhr@gmail.com \
    --cc=vireshk@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.