All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Florian Westphal <fw@strlen.de>
Cc: <netdev@vger.kernel.org>
Subject: Re: [PATCH net] selftests: netfilter: nft_queue.sh: increase udp_gro_ct subtest timeout
Date: Tue, 24 Feb 2026 06:59:21 -0800	[thread overview]
Message-ID: <20260224065921.0d4f5cdc@kernel.org> (raw)
In-Reply-To: <20260223190108.28139-1-fw@strlen.de>

On Mon, 23 Feb 2026 20:00:58 +0100 Florian Westphal wrote:
> Jakub reports test flakes on debug kernels:
>  FAIL: test_udp_gro_ct: Expected software segmentation to occur, had 23 and 17
> 
> The nf_queue listener exits when it doesn't receive a new packet after
> 2s, seems this is too low. Use a 5 second timeout instead, same as the
> duration of the packet generation side.
> 
> Fixes: 59ecffa3995e ("selftests: netfilter: nft_queue.sh: add udp fraglist gro test case")
> Reported-by: Jakub Kicinski <kuba@kernel.org>
> Closes: https://lore.kernel.org/netdev/20260218184114.0b405b72@kernel.org/
> Signed-off-by: Florian Westphal <fw@strlen.de>
> ---
>  Hello, unfortunately I can't repro the flakes here, but 2s is rather
>  short and a nf_queue listener that exits while packets are still queued
>  does explain the error message (more packets counted as incoming than
>  outgoing).

Thanks for looking into it! Unfortunately we saw the problem again with
this patch applied:
https://netdev-ctrl.bots.linux.dev/logs/vmksft/nf-dbg/results/531881/3-nft-queue-sh/stdout

Looks like it repros once every 25 runs for us:
https://netdev.bots.linux.dev/contest.html?executor=vmksft-nf-dbg&test=nft-queue-sh

  reply	other threads:[~2026-02-24 14:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-23 19:00 [PATCH net] selftests: netfilter: nft_queue.sh: increase udp_gro_ct subtest timeout Florian Westphal
2026-02-24 14:59 ` Jakub Kicinski [this message]
2026-02-24 15:09   ` Florian Westphal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260224065921.0d4f5cdc@kernel.org \
    --to=kuba@kernel.org \
    --cc=fw@strlen.de \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.