From: Stephen Hemminger <stephen@networkplumber.org>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, ktraynor@redhat.com
Subject: Re: [PATCH] net/tap: defer qdisc initialisation for rte_flow
Date: Tue, 24 Feb 2026 07:38:20 -0800 [thread overview]
Message-ID: <20260224073820.44a5a329@phoenix.local> (raw)
In-Reply-To: <20260224152744.3860285-1-david.marchand@redhat.com>
On Tue, 24 Feb 2026 16:27:44 +0100
David Marchand <david.marchand@redhat.com> wrote:
> qdisc setup is required when using a remote_iface or when creating
> rte_flow rules.
> Otherwise, many applications don't care about it.
>
> Let's postpone the qdisc init to when it is really needed, that will
> avoid spewing ERR logs for nothing.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
Agreed. Should probably mark this with Fixes.
The only AI review feedback was that flow_init should be bool not int;
but the existing code uses int for flags so OK.
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
next prev parent reply other threads:[~2026-02-24 15:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-24 15:27 [PATCH] net/tap: defer qdisc initialisation for rte_flow David Marchand
2026-02-24 15:38 ` Stephen Hemminger [this message]
2026-02-25 22:51 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260224073820.44a5a329@phoenix.local \
--to=stephen@networkplumber.org \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ktraynor@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.