From: Herve Codina <herve.codina@bootlin.com>
To: Ioana Ciornei <ioana.ciornei@nxp.com>
Cc: Thomas Gleixner <tglx@kernel.org>,
Linus Walleij <linusw@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Alexander Stein <alexander.stein@ew.tq-group.com>,
linux-kernel@vger.kernel.org,
Dan Carpenter <dan.carpenter@linaro.org>
Subject: Re: [PATCH 2/2] irqchip/ls-extirq: fix devm_of_iomap() error check
Date: Tue, 24 Feb 2026 13:53:05 +0100 [thread overview]
Message-ID: <20260224135305.7a364f39@bootlin.com> (raw)
In-Reply-To: <20260224113610.1129022-3-ioana.ciornei@nxp.com>
Hi Ioana,
On Tue, 24 Feb 2026 13:36:10 +0200
Ioana Ciornei <ioana.ciornei@nxp.com> wrote:
> The devm_of_iomap() function returns an ERR_PTR() encoded error code on
> failure. Replace the incorrect check against NULL with IS_ERR().
>
> Fixes: 05cd654829dd ("irqchip/ls-extirq: Convert to a platform driver to make it work again")
> Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> Closes: https://lore.kernel.org/all/aYXvfbfT6w0TMsXS@stanley.mountain/
> Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
Reviewed-by: Herve Codina <herve.codina@bootlin.com>
Best regards,
Hervé
next prev parent reply other threads:[~2026-02-24 12:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-24 11:36 [PATCH 0/2] irqchip/ls-extirq: various fixes Ioana Ciornei
2026-02-24 11:36 ` [PATCH 1/2] Revert "irqchip/ls-extirq: Use for_each_of_imap_item iterator" Ioana Ciornei
2026-02-24 12:47 ` Herve Codina
2026-02-24 12:53 ` Ioana Ciornei
2026-02-24 17:36 ` [tip: irq/urgent] " tip-bot2 for Ioana Ciornei
2026-02-24 11:36 ` [PATCH 2/2] irqchip/ls-extirq: fix devm_of_iomap() error check Ioana Ciornei
2026-02-24 12:53 ` Herve Codina [this message]
2026-02-24 17:36 ` [tip: irq/urgent] irqchip/ls-extirq: Fix " tip-bot2 for Ioana Ciornei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260224135305.7a364f39@bootlin.com \
--to=herve.codina@bootlin.com \
--cc=alexander.stein@ew.tq-group.com \
--cc=dan.carpenter@linaro.org \
--cc=geert+renesas@glider.be \
--cc=ioana.ciornei@nxp.com \
--cc=linusw@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.