From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8472036402C for ; Tue, 24 Feb 2026 16:42:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771951333; cv=none; b=hnxX7M1xjk7lVY70nsF/oMqb4yGBDuvu4YS2i0ZGfLnJRW9N0NkTJ3iPT4/1OsQ0jrx8JeqqAncxBWJ0EjzgUUE7ZTsbWzdjwhOPtGMR1GFk9luvkZCXH85zrk9wMcz7Xx2YF2TIIScemhu1H3lTBanm9CesHCI/GsF3+Dg0p0w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771951333; c=relaxed/simple; bh=t84B8Ilz4HCtnV2JFRxXep0Vy6JuoZVpcJs7VugdvaQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CQDih+Wn5z9tR3UyXGp9GfNI4MZHG+b7rt/L6Is7h0c3/b3mfPwOoP/99aE/jiw3iVajcrNsJ4MXM/CF8e9xdWwp2OJjLXkQo6OpLo/MM2HNvRCs8wgHa4xxDlSdPSvaYEDX+tEJmkoVkVQ84Gc9fxqx/nZ3xB76FNYmaQ+S1Xs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=permerror header.from=versity.com; spf=pass smtp.mailfrom=versity.com; dkim=pass (2048-bit key) header.d=versity.com header.i=@versity.com header.b=jV9gqrNh; arc=none smtp.client-ip=209.85.218.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=permerror header.from=versity.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=versity.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=versity.com header.i=@versity.com header.b="jV9gqrNh" Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-b8871718b00so953216566b.3 for ; Tue, 24 Feb 2026 08:42:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=versity.com; s=google; t=1771951331; x=1772556131; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GyQKNYbz8W3XKmL69VVKoSquy97gg1PE/75VLIP+oqg=; b=jV9gqrNhpBZW+At9N39g0d6c1XX06D7AXNyYzvMomQvszuyWiR40wJ811Vw2CdVI/J BQG6mN028kVxNNoBKXX4W8DtK77q7dk8pCv0OltxI8KqtD7abWRuxBHa3+p2XZnOoKmc 9DNyn2Wv8uP9uYtl5IEIHgJyMv/7pj28lFyYNmGo4Dm1xGs17k7jZtoGirIFuxvr+p6w XpK3HI0D6nmBZ+Gh+6zpLla4dMHpsBTO8KvhOONqkuzoz0eDHiVj+d70mJDTlcL1TYz/ 5egkneqn2XljHkCngeGhCIhfe7K44v1j6EYhNJqB9HwvoPSw33yK6TtWo9rxKLwyns4I xShA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771951331; x=1772556131; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=GyQKNYbz8W3XKmL69VVKoSquy97gg1PE/75VLIP+oqg=; b=fQtO8dhUh9ntYFrB4DKrKz+WcyJhp3KESAjIZ0A1BHnWCelNxG8TfJx8Wx1KNKEZRh E/LH5Guy+3y/9gaElsAA4IfohcBLVgzbJWbCaVAXUVzWkayp959jZRfO3Ghjd86S0/ZS 2sPpuhfqwUetTUsTRy7gM8S+ZZdzitJygeyjDWiQFx9p4FtE1kRHLp1nehbej+HeKhGp aKogbvY0Yl2UfqkqeXyjWEQsw4CfwzwGZVYsWsE55Go8Y54fBTKoEy0di5dhkHbxJLOK PP1WNqc3FR7lU359bFjEnqb0moWpmFuSA8isCQoReV7P0ROamE3LiAK8ekFJISao2FpP X+Sg== X-Gm-Message-State: AOJu0Ywa/1cv1dv1YcQ6rxlt62U7zlDqw8Iqa4zO8Dqo2D9DihGNJ9vR WHqd+PFAkAZM+6Vacb3aXT0udOSr2vTSJZ82ZnrDMU/C1u7EYxKIMuAJxjWp23KkAMFczGbXf9N ZW4lnAjg= X-Gm-Gg: AZuq6aIXiSye61KgIOyPHa0ou8eWxfZ4kIqJNpVRvcV8cd0un2UKjovMCn3JLNmq+aq z3Z00q6bQYc96rGeGMjD06oangCOShF4DseaRodFQy2ee2KoUhK9NJt+RBNRvN3AqEqhHomzuBB Nt/lHq0CrjPq4qsDoAmR4EfaX7OzxTgMq5O4kc6HaO9iBe9UgZEMpPVv+S19yDSExTiGom/guwM SEtaDWr9kqdCAqEQnqT3Cgu9fHXqbJaSSEkbkok4CXO+Hto0egztxWEFSRQ5lkhbyPVriUx15uD m/A+laLUoELSFbAtylIP7Rh2cheb0O5DmKKs1Cim6J3lauJSKy4vLNKJjdwWw5T0PzqVrUBUFuI xZbTvvJj8Mu/O2KmFWM6C6iHbzrGdXnosV83dkXUxzPjbOwFVKpSfQ2U1I8c5oxX5C2fKikB2io ZqlhNXoTLsAqeOynC1XRDmDE+xkkuMANd88l8yUXQthYBrgL1eQwLorxH0MNzh3LLqqPk= X-Received: by 2002:a17:906:a216:b0:b88:5a44:fe27 with SMTP id a640c23a62f3a-b9081b8f775mr683815766b.42.1771951330830; Tue, 24 Feb 2026 08:42:10 -0800 (PST) Received: from localhost.localdomain (46-117-212-87.ftth.glasoperator.nl. [87.212.117.46]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-65eaba13866sm3462367a12.18.2026.02.24.08.42.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Feb 2026 08:42:10 -0800 (PST) From: Valerie Aurora To: rpdfs-devel@lists.linux.dev Cc: Valerie Aurora Subject: [PATCH 1/2] Add rpdfs_unlink() Date: Tue, 24 Feb 2026 17:41:56 +0100 Message-ID: <20260224164157.2591-2-val@versity.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20260224164157.2591-1-val@versity.com> References: <20260224164157.2591-1-val@versity.com> Precedence: bulk X-Mailing-List: rpdfs-devel@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Copied from rpdfs_rename() and the extra bits removed. Signed-off-by: Valerie Aurora --- fs/rpdfs/dir.c | 51 ++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 51 insertions(+) diff --git a/fs/rpdfs/dir.c b/fs/rpdfs/dir.c index 115f879d8fb1..9b33453ad5f6 100644 --- a/fs/rpdfs/dir.c +++ b/fs/rpdfs/dir.c @@ -491,6 +491,56 @@ static struct dentry *rpdfs_mkdir(struct mnt_idmap *idmap, struct inode *dir, return ERR_PTR(create_and_instantiate_new(idmap, dir, dentry, S_IFDIR | mode)); } +static int rpdfs_unlink(struct inode *dir, struct dentry *dentry) +{ + struct rpdfs_fs_info *rfi = RPDFS_INODE_FS(dir); + struct inode *inode = d_inode(dentry); + struct key_dent *kd = NULL; + DECLARE_RPDFS_TXN(txn); + int ret; + + kd = alloc_key_dent(dentry, inode); + if (!kd) { + ret = -ENOMEM; + goto out; + } + + /* prepare all the blocks for in the txn */ + do { + ret = rpdfs_inode_txn_prepare(rfi, &txn, dir, RBAF_WRITE) ?: + rpdfs_inode_txn_prepare(rfi, &txn, inode, RBAF_WRITE) ?: + prepare_remove_entry(rfi, &txn, dir, kd); + } while (rpdfs_txn_retry(rfi, &txn, &ret)); + if (ret < 0) + goto out; + + /* apply changes to block structures */ + apply_remove_entry(rfi, &txn, dir, kd); + + /* update vfs inodes: first dir sizes and times */ + i_size_write(dir, i_size_read(dir) - dentry->d_name.len); + inode_set_mtime_to_ts(dir, inode_set_ctime_current(dir)); + + /* now inode nlink and times */ + if (inode->i_nlink == 0) + pr_warn("deleting inode %.*s with link count already 0", + dentry->d_name.len, dentry->d_name.name); + else + drop_nlink(inode); + inode_set_ctime_current(inode); + + /* update block storage of vfs inodes */ + rpdfs_inode_txn_update(rfi, &txn, dir); + rpdfs_inode_txn_update(rfi, &txn, inode); + + ret = 0; +out: + rpdfs_txn_reset(rfi, &txn); + kfree(kd); + + return ret; +} + /* * The vfs has verified the cached directories. Our inode refresh will * fail if the inodes have been reused, so we don't have to test if @@ -680,6 +730,7 @@ const struct inode_operations rpdfs_dir_iops = { .lookup = rpdfs_lookup, .mkdir = rpdfs_mkdir, .rename = rpdfs_rename, + .unlink = rpdfs_unlink, }; const struct file_operations rpdfs_dir_fops = { -- 2.49.0