From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Artem Lytkin <iprintercanon@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/3] staging: most: dim2: clean up error handling in fsl_mx6_enable
Date: Tue, 24 Feb 2026 09:55:19 -0800 [thread overview]
Message-ID: <2026022422-dreamless-tantrum-eae8@gregkh> (raw)
In-Reply-To: <20260224043723.1828-1-iprintercanon@gmail.com>
On Tue, Feb 24, 2026 at 04:37:20AM +0000, Artem Lytkin wrote:
> This series cleans up error handling in fsl_mx6_enable(), split into
> separate logical changes per Dan Carpenter's review of v1.
>
> Changes since v1:
> - Split combined patch into 3 separate patches (one change per patch)
> - Extended string indirection fix to all three enable functions
>
> Patch 1 replaces IS_ERR_OR_NULL() with IS_ERR() since devm_clk_get()
> never returns NULL.
>
> Patch 2 replaces dev_err() + hardcoded -EFAULT with dev_err_probe()
> and PTR_ERR() to propagate correct error codes and handle probe
> deferral properly.
>
> Patch 3 removes unnecessary string indirection in dev_err() calls
> ("%s\n", "message" -> "message\n").
>
> Artem Lytkin (3):
> staging: most: dim2: replace IS_ERR_OR_NULL with IS_ERR for
> devm_clk_get
> staging: most: dim2: use dev_err_probe and proper error codes for
> clock
> staging: most: dim2: remove unnecessary string indirection in dev_err
>
> drivers/staging/most/dim2/dim2.c | 19 +++++++++----------
> 1 file changed, 9 insertions(+), 10 deletions(-)
>
> --
> 2.43.0
>
I see 2 different copies of this series, as can be seen on
lore.kernel.org:
https://lore.kernel.org/all/20260224043723.1828-1-iprintercanon@gmail.com/
which is "correct"?
Can you send a v3 so I know what to do?
thanks,
greg k-h
prev parent reply other threads:[~2026-02-24 17:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-16 20:19 [PATCH 0/2] staging: most: dim2: fix error handling in fsl_mx6_enable Artem Lytkin
2026-02-16 20:19 ` [PATCH 1/2] staging: most: dim2: check return value of clk_prepare_enable for PLL Artem Lytkin
2026-02-16 20:19 ` [PATCH 2/2] staging: most: dim2: fix error handling in fsl_mx6_enable Artem Lytkin
2026-02-19 8:18 ` Dan Carpenter
2026-02-23 21:09 ` [PATCH v2 0/3] staging: most: dim2: clean up " Artem Lytkin
2026-02-23 21:09 ` [PATCH v2 1/3] staging: most: dim2: replace IS_ERR_OR_NULL with IS_ERR for devm_clk_get Artem Lytkin
2026-02-23 21:09 ` [PATCH v2 2/3] staging: most: dim2: use dev_err_probe and proper error codes for clock Artem Lytkin
2026-02-23 21:09 ` [PATCH v2 3/3] staging: most: dim2: remove unnecessary string indirection in dev_err Artem Lytkin
2026-02-24 4:37 ` [PATCH v2 0/3] staging: most: dim2: clean up error handling in fsl_mx6_enable Artem Lytkin
2026-02-24 4:37 ` [PATCH v2 1/3] staging: most: dim2: replace IS_ERR_OR_NULL with IS_ERR for devm_clk_get Artem Lytkin
2026-02-24 4:37 ` [PATCH v2 2/3] staging: most: dim2: use dev_err_probe and proper error codes for clock Artem Lytkin
2026-02-24 4:37 ` [PATCH v2 3/3] staging: most: dim2: remove unnecessary string indirection in dev_err Artem Lytkin
2026-02-24 17:55 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026022422-dreamless-tantrum-eae8@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=iprintercanon@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.