All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Maciek Machnikowski <maciek@machnikowski.net>
Cc: netdev@vger.kernel.org, richardcochran@gmail.com,
	milena.olech@intel.com, willemdebruijn.kernel@gmail.com,
	andrew@lunn.ch, vadim.fedorenko@linux.dev, horms@kernel.org
Subject: Re: [PATCH v3 net-next 3/3] selftests:net: Implement ptp4l sync test using netdevsim
Date: Wed, 25 Feb 2026 18:41:00 -0800	[thread overview]
Message-ID: <20260225184100.20b24179@kernel.org> (raw)
In-Reply-To: <20260225153858.29486-4-maciek@machnikowski.net>

On Wed, 25 Feb 2026 16:38:58 +0100 Maciek Machnikowski wrote:
> Add PTP synchronization test using ptp4l and netdevsim.
> 
> The test creates two netdevsim adapters, links them together
> and runs the ptp4l leader and ptp4l follower on two ends
> of the netdevsim link and waits for the follower to report the
> synchronized state (s2) in its output log.

Please make this a Python test using the wrappers we have so that
the test can run both against netdevsim and real devices.

Is ptp4l going to be stable as a selftest? And will it give us solid
coverage (vs doing some fallbacks and pass even for broken drivers)?
We generally test 

Vadim, WDYT?

  parent reply	other threads:[~2026-02-26  2:41 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-25 15:38 [PATCH v3 net-next 0/3] Implement PTP support in netdevsim Maciek Machnikowski
2026-02-25 15:38 ` [PATCH v3 net-next 1/3] ptp_mock: Expose ptp_clock_info to external drivers Maciek Machnikowski
2026-02-26  1:57   ` Jakub Kicinski
2026-02-25 15:38 ` [PATCH v3 net-next 2/3] netdevsim: Implement basic ptp support Maciek Machnikowski
2026-02-25 16:32   ` Sai Krishna Gajula
2026-02-26  2:01   ` Jakub Kicinski
2026-03-04 12:41     ` Maciek Machnikowski
2026-03-04 15:19   ` Willem de Bruijn
2026-03-04 15:48     ` Willem de Bruijn
2026-02-25 15:38 ` [PATCH v3 net-next 3/3] selftests:net: Implement ptp4l sync test using netdevsim Maciek Machnikowski
2026-02-25 16:45   ` Sai Krishna Gajula
2026-03-04 12:44     ` Maciek Machnikowski
2026-02-26  2:41   ` Jakub Kicinski [this message]
2026-03-04 15:21   ` Willem de Bruijn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260225184100.20b24179@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=horms@kernel.org \
    --cc=maciek@machnikowski.net \
    --cc=milena.olech@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=richardcochran@gmail.com \
    --cc=vadim.fedorenko@linux.dev \
    --cc=willemdebruijn.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.