All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Shung-Hsi Yu <shung-hsi.yu@suse.com>
Cc: "Harshit Mogalapalli" <harshit.m.mogalapalli@oracle.com>,
	"Ricardo B. Marlière" <rbm@suse.com>,
	stable@vger.kernel.org, "Shuah Khan" <skhan@linuxfoundation.org>,
	linux-kselftest@vger.kernel.org,
	"Daniel Borkmann" <daniel@iogearbox.net>,
	"Alexei Starovoitov" <ast@kernel.org>,
	"Andrii Nakryiko" <andrii@kernel.org>,
	bpf@vger.kernel.org
Subject: Re: Latest BPF selftests on stable kernels (was 'Re: [PATCH stable 6.12 0/5] Backport selftest for "bpf: Check skb->transport_header is set in bpf_skb_check_mtu"')
Date: Wed, 25 Feb 2026 06:32:40 -0800	[thread overview]
Message-ID: <2026022557-synapse-schilling-e88b@gregkh> (raw)
In-Reply-To: <crki45lsdj4yjmz3ix4k5scjuovjr56oexmwhhwbqeejdxh3j2@kgve6uooitce>

On Wed, Feb 25, 2026 at 10:35:06AM +0800, Shung-Hsi Yu wrote:
> Cc BPF mailing list and maintainers. Plus other in the referenced
> thread.
> 
> Hi Harshit,
> 
> On Tue, Feb 24, 2026 at 09:18:04AM -0300, Ricardo B. Marlière wrote:
> > On Tue Feb 24, 2026 at 4:53 AM -03, Harshit Mogalapalli wrote:
> > > On 24/02/26 13:08, Shung-Hsi Yu wrote:
> > >> This patchset backport the corresponding BPF selftests for commit
> > >> d946f3c98328 ("bpf: Check skb->transport_header is set in
> > >> bpf_skb_check_mtu"), which has already been included since 6.12.63.
> > >> 
> > >> The BPF selftest added in commit 6cc73f35406c ("selftests/bpf: Test
> > >> bpf_skb_check_mtu(BPF_MTU_CHK_SEGS) when transport_header is not set")
> > >> additionally depends on network namespace support for BPF selftests
> > >> added by Bastien, otherwise the MTU in root networking namespace will be
> > >> set to 10, causing other BPF selftests to fail. Credit goes to Ricardo
> > >> Marlière for figuring out the dependency.
> > >
> > > Note:
> > > I have recently learnt that ideally we are supposed to run upstream 
> > > latest kselftests on stable kernels as well. If a feature is not 
> > > supported the kselftests are meant to be skipped.
> 
> Thanks you for the bringing this up! This was also mentioned by Daniel
> (Borkmann), but my experience aligns with Ricardo's.
> 
> > That is not true for BPF, from my (limited) experience.
> 
> I do want running latest BPF selftests to work on stable thought, made
> some half-hearted attempts last April on trying bpf-next's BPF selftests
> (during 6.15 phase) run on stable/linux-6.14.y, but wasn't able to get
> pass the building phase.
> 
> As far as I remember I ran into issue building bpf_testmod.ko (kernel
> module) of bpf-next against 6.14, and other similar issues related data
> structure or API changes. Pretty much the same set of problems we get
> when trying to build any driver in the latest kernel against stable
> kernels.
> 
> Maybe it can work if BPF selftests that does not depends on
> bpf_testmod.ko, and build failures of BPF programs are simply ignored
> (not sure how feasible that is, probably would make Makefile much
> complicated), so for now I'm sticking with backporting BPF selftests to
> stable kernels.

If a kernel test module is involved, then yes, you are right, those
changes do need to be backported as mix/match of kernel modules to other
trees is not something that we support.

We only want this to be the rule for when we have purely userspace test
cases/code.

thanks,

greg k-h

  reply	other threads:[~2026-02-25 14:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-24  7:38 [PATCH stable 6.12 0/5] Backport selftest for "bpf: Check skb->transport_header is set in bpf_skb_check_mtu" Shung-Hsi Yu
2026-02-24  7:38 ` [PATCH stable 6.12 1/5] selftests/bpf: ns_current_pid_tgid: Rename the test function Shung-Hsi Yu
2026-02-24  7:38 ` [PATCH stable 6.12 2/5] selftests/bpf: Optionally open a dedicated namespace to run test in it Shung-Hsi Yu
2026-02-24  7:38 ` [PATCH stable 6.12 3/5] selftests/bpf: tc_links/tc_opts: Unserialize tests Shung-Hsi Yu
2026-02-24  7:38 ` [PATCH stable 6.12 4/5] selftests/bpf: ns_current_pid_tgid: Use test_progs's ns_ feature Shung-Hsi Yu
2026-02-24  7:38 ` [PATCH stable 6.12 5/5] selftests/bpf: Test bpf_skb_check_mtu(BPF_MTU_CHK_SEGS) when transport_header is not set Shung-Hsi Yu
2026-02-24  7:53 ` [PATCH stable 6.12 0/5] Backport selftest for "bpf: Check skb->transport_header is set in bpf_skb_check_mtu" Harshit Mogalapalli
2026-02-24 12:18   ` Ricardo B. Marlière
2026-02-25  2:35     ` Latest BPF selftests on stable kernels (was 'Re: [PATCH stable 6.12 0/5] Backport selftest for "bpf: Check skb->transport_header is set in bpf_skb_check_mtu"') Shung-Hsi Yu
2026-02-25 14:32       ` Greg KH [this message]
2026-02-26  7:33         ` Shung-Hsi Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026022557-synapse-schilling-e88b@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=harshit.m.mogalapalli@oracle.com \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=rbm@suse.com \
    --cc=shung-hsi.yu@suse.com \
    --cc=skhan@linuxfoundation.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.