All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Usama Arif <usama.arif@linux.dev>
Cc: oe-kbuild-all@lists.linux.dev
Subject: Re: [RFC v2 13/21] mm: huge_mm: Make sure all split_huge_pmd calls are checked
Date: Fri, 27 Feb 2026 00:32:50 +0800	[thread overview]
Message-ID: <202602270049.Hcnrxeen-lkp@intel.com> (raw)
In-Reply-To: <20260226113233.3987674-14-usama.arif@linux.dev>

Hi Usama,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build warnings:

[auto build test WARNING on akpm-mm/mm-everything]

url:    https://github.com/intel-lab-lkp/linux/commits/Usama-Arif/mm-thp-make-split_huge_pmd-functions-return-int-for-error-propagation/20260226-193910
base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link:    https://lore.kernel.org/r/20260226113233.3987674-14-usama.arif%40linux.dev
patch subject: [RFC v2 13/21] mm: huge_mm: Make sure all split_huge_pmd calls are checked
config: arc-allmodconfig (https://download.01.org/0day-ci/archive/20260227/202602270049.Hcnrxeen-lkp@intel.com/config)
compiler: arc-linux-gcc (GCC) 15.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260227/202602270049.Hcnrxeen-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202602270049.Hcnrxeen-lkp@intel.com/

All warnings (new ones prefixed by >>):

   fs/proc/task_mmu.c: In function 'pagemap_scan_thp_entry':
>> fs/proc/task_mmu.c:2718:17: warning: ignoring return value of 'split_huge_pmd' declared with attribute 'warn_unused_result' [-Wunused-result]
    2718 |                 split_huge_pmd(vma, pmd, start);
         |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


vim +2718 fs/proc/task_mmu.c

52526ca7fdb905 Muhammad Usama Anjum 2023-08-21  2682  
52526ca7fdb905 Muhammad Usama Anjum 2023-08-21  2683  static int pagemap_scan_thp_entry(pmd_t *pmd, unsigned long start,
52526ca7fdb905 Muhammad Usama Anjum 2023-08-21  2684  				  unsigned long end, struct mm_walk *walk)
52526ca7fdb905 Muhammad Usama Anjum 2023-08-21  2685  {
52526ca7fdb905 Muhammad Usama Anjum 2023-08-21  2686  #ifdef CONFIG_TRANSPARENT_HUGEPAGE
52526ca7fdb905 Muhammad Usama Anjum 2023-08-21  2687  	struct pagemap_scan_private *p = walk->private;
52526ca7fdb905 Muhammad Usama Anjum 2023-08-21  2688  	struct vm_area_struct *vma = walk->vma;
52526ca7fdb905 Muhammad Usama Anjum 2023-08-21  2689  	unsigned long categories;
52526ca7fdb905 Muhammad Usama Anjum 2023-08-21  2690  	spinlock_t *ptl;
52526ca7fdb905 Muhammad Usama Anjum 2023-08-21  2691  	int ret = 0;
52526ca7fdb905 Muhammad Usama Anjum 2023-08-21  2692  
52526ca7fdb905 Muhammad Usama Anjum 2023-08-21  2693  	ptl = pmd_trans_huge_lock(pmd, vma);
52526ca7fdb905 Muhammad Usama Anjum 2023-08-21  2694  	if (!ptl)
52526ca7fdb905 Muhammad Usama Anjum 2023-08-21  2695  		return -ENOENT;
52526ca7fdb905 Muhammad Usama Anjum 2023-08-21  2696  
52526ca7fdb905 Muhammad Usama Anjum 2023-08-21  2697  	categories = p->cur_vma_category |
52526ca7fdb905 Muhammad Usama Anjum 2023-08-21  2698  		     pagemap_thp_category(p, vma, start, *pmd);
52526ca7fdb905 Muhammad Usama Anjum 2023-08-21  2699  
52526ca7fdb905 Muhammad Usama Anjum 2023-08-21  2700  	if (!pagemap_scan_is_interesting_page(categories, p))
52526ca7fdb905 Muhammad Usama Anjum 2023-08-21  2701  		goto out_unlock;
52526ca7fdb905 Muhammad Usama Anjum 2023-08-21  2702  
52526ca7fdb905 Muhammad Usama Anjum 2023-08-21  2703  	ret = pagemap_scan_output(categories, p, start, &end);
52526ca7fdb905 Muhammad Usama Anjum 2023-08-21  2704  	if (start == end)
52526ca7fdb905 Muhammad Usama Anjum 2023-08-21  2705  		goto out_unlock;
52526ca7fdb905 Muhammad Usama Anjum 2023-08-21  2706  
52526ca7fdb905 Muhammad Usama Anjum 2023-08-21  2707  	if (~p->arg.flags & PM_SCAN_WP_MATCHING)
52526ca7fdb905 Muhammad Usama Anjum 2023-08-21  2708  		goto out_unlock;
52526ca7fdb905 Muhammad Usama Anjum 2023-08-21  2709  	if (~categories & PAGE_IS_WRITTEN)
52526ca7fdb905 Muhammad Usama Anjum 2023-08-21  2710  		goto out_unlock;
52526ca7fdb905 Muhammad Usama Anjum 2023-08-21  2711  
52526ca7fdb905 Muhammad Usama Anjum 2023-08-21  2712  	/*
52526ca7fdb905 Muhammad Usama Anjum 2023-08-21  2713  	 * Break huge page into small pages if the WP operation
52526ca7fdb905 Muhammad Usama Anjum 2023-08-21  2714  	 * needs to be performed on a portion of the huge page.
52526ca7fdb905 Muhammad Usama Anjum 2023-08-21  2715  	 */
52526ca7fdb905 Muhammad Usama Anjum 2023-08-21  2716  	if (end != start + HPAGE_SIZE) {
52526ca7fdb905 Muhammad Usama Anjum 2023-08-21  2717  		spin_unlock(ptl);
52526ca7fdb905 Muhammad Usama Anjum 2023-08-21 @2718  		split_huge_pmd(vma, pmd, start);
52526ca7fdb905 Muhammad Usama Anjum 2023-08-21  2719  		pagemap_scan_backout_range(p, start, end);
52526ca7fdb905 Muhammad Usama Anjum 2023-08-21  2720  		/* Report as if there was no THP */
52526ca7fdb905 Muhammad Usama Anjum 2023-08-21  2721  		return -ENOENT;
52526ca7fdb905 Muhammad Usama Anjum 2023-08-21  2722  	}
52526ca7fdb905 Muhammad Usama Anjum 2023-08-21  2723  
52526ca7fdb905 Muhammad Usama Anjum 2023-08-21  2724  	make_uffd_wp_pmd(vma, start, pmd);
52526ca7fdb905 Muhammad Usama Anjum 2023-08-21  2725  	flush_tlb_range(vma, start, end);
52526ca7fdb905 Muhammad Usama Anjum 2023-08-21  2726  out_unlock:
52526ca7fdb905 Muhammad Usama Anjum 2023-08-21  2727  	spin_unlock(ptl);
52526ca7fdb905 Muhammad Usama Anjum 2023-08-21  2728  	return ret;
52526ca7fdb905 Muhammad Usama Anjum 2023-08-21  2729  #else /* !CONFIG_TRANSPARENT_HUGEPAGE */
52526ca7fdb905 Muhammad Usama Anjum 2023-08-21  2730  	return -ENOENT;
52526ca7fdb905 Muhammad Usama Anjum 2023-08-21  2731  #endif
52526ca7fdb905 Muhammad Usama Anjum 2023-08-21  2732  }
52526ca7fdb905 Muhammad Usama Anjum 2023-08-21  2733  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

  reply	other threads:[~2026-02-26 16:33 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-26 11:23 [RFC v2 00/21] mm: thp: lazy PTE page table allocation at PMD split Usama Arif
2026-02-26 11:23 ` [RFC v2 01/21] mm: thp: make split_huge_pmd functions return int for error propagation Usama Arif
2026-02-26 11:23 ` [RFC v2 02/21] mm: thp: propagate split failure from vma_adjust_trans_huge() Usama Arif
2026-02-26 11:23 ` [RFC v2 03/21] mm: thp: handle split failure in copy_huge_pmd() Usama Arif
2026-02-26 11:23 ` [RFC v2 04/21] mm: thp: handle split failure in do_huge_pmd_wp_page() Usama Arif
2026-02-26 11:23 ` [RFC v2 05/21] mm: thp: handle split failure in zap_pmd_range() Usama Arif
2026-02-26 11:23 ` [RFC v2 06/21] mm: thp: handle split failure in wp_huge_pmd() Usama Arif
2026-02-26 11:23 ` [RFC v2 07/21] mm: thp: retry on split failure in change_pmd_range() Usama Arif
2026-02-26 11:23 ` [RFC v2 08/21] mm: thp: handle split failure in follow_pmd_mask() Usama Arif
2026-02-26 11:23 ` [RFC v2 09/21] mm: handle walk_page_range() failure from THP split Usama Arif
2026-02-26 11:23 ` [RFC v2 10/21] mm: thp: handle split failure in mremap move_page_tables() Usama Arif
2026-02-26 11:23 ` [RFC v2 11/21] mm: thp: handle split failure in userfaultfd move_pages() Usama Arif
2026-02-26 11:23 ` [RFC v2 12/21] mm: thp: handle split failure in device migration Usama Arif
2026-03-02 21:20   ` Nico Pache
2026-03-04 11:55     ` Usama Arif
2026-03-05 16:55     ` Usama Arif
2026-03-09 15:09       ` Nico Pache
2026-03-09 21:34         ` Usama Arif
2026-02-26 11:23 ` [RFC v2 13/21] mm: huge_mm: Make sure all split_huge_pmd calls are checked Usama Arif
2026-02-26 16:32   ` kernel test robot [this message]
2026-02-27 12:11   ` Usama Arif
2026-02-26 11:23 ` [RFC v2 14/21] mm: thp: allocate PTE page tables lazily at split time Usama Arif
2026-02-26 11:23 ` [RFC v2 15/21] mm: thp: remove pgtable_trans_huge_{deposit/withdraw} when not needed Usama Arif
2026-02-26 11:23 ` [RFC v2 16/21] mm: thp: add THP_SPLIT_PMD_FAILED counter Usama Arif
2026-02-26 13:56   ` kernel test robot
2026-02-26 14:22   ` Usama Arif
2026-02-26 15:10   ` kernel test robot
2026-02-26 11:23 ` [RFC v2 17/21] selftests/mm: add THP PMD split test infrastructure Usama Arif
2026-02-26 11:23 ` [RFC v2 18/21] selftests/mm: add partial_mprotect test for change_pmd_range Usama Arif
2026-02-26 11:23 ` [RFC v2 19/21] selftests/mm: add partial_mlock test Usama Arif
2026-02-26 11:23 ` [RFC v2 20/21] selftests/mm: add partial_mremap test for move_page_tables Usama Arif
2026-02-26 11:23 ` [RFC v2 21/21] selftests/mm: add madv_dontneed_partial test Usama Arif
2026-02-26 21:01 ` [RFC v2 00/21] mm: thp: lazy PTE page table allocation at PMD split Nico Pache
2026-02-27 11:13   ` Usama Arif
2026-02-28  0:06     ` Nico Pache
2026-03-02 11:08       ` Usama Arif

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202602270049.Hcnrxeen-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=usama.arif@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.