From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5EA102BE63F; Fri, 27 Feb 2026 21:22:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772227372; cv=none; b=CpA8hhdSUIrXRFAqVYA0hqUhUXCoDC/OTBsr44mpMxImAfuFQu63JgAA16AmI7DCdRpRG3S0CfEhZ1mEmRT1tSB3UktDD8P9LkW3R8kDh9eqortyr/pLxUQ6gERCcZyVnENPd5HRZ/FkvswdwDh7WBSQvaEitePiky4GnwlTrzo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772227372; c=relaxed/simple; bh=gdzxoUn2gxhPxqAZE2wnuoB0K0GDDb9MlkGqZ/c6Edk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=M2VzpwdN3+/Uqky2sUBy9FiuJyun/SKtaSEBrBw1ps5sCq4uLnNfgWZbtuUzSipfwtuffywSuMBNaSxagokdAwbL6oH2mH44NG6FXL0l2RycdW3x1Rvr7OgABIvs/xl7OfTpcZWJ9dYrYGuPmEwD+1pjvTPsBpEGW2xULPogJ6I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=IG+0YFYY; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="IG+0YFYY" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 263E2C116C6; Fri, 27 Feb 2026 21:22:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772227372; bh=gdzxoUn2gxhPxqAZE2wnuoB0K0GDDb9MlkGqZ/c6Edk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IG+0YFYYtUAUb+23rDHJYKFU8SK8o4070YARNt9N3Nj/qUn8Tq4dktYf6wZ2hqh06 XZ8a5Cn7X4z2JY9gO7rFXYkCWHQDGqwWj4g28PUrzC46IgrG3tiir7tJuMpitY3gNg RFBwdzNFVmzfn969s0VhfYuE3DZx7QEMoBPM79w4+3acu0XOmfwxQ+sWyPRIt1BOvG t8h+rI7Cwfb3oqGHY5imm4je2+mBpxC0aBImRggF9jqarNyydQIe7IRUhtNxhZP1lX ErT/H4J8H8hSiZ0ehxMQK1LYebJMjhBIXoqqs8YjQurzDS3+I/RLRWj3sU540OtjDX rfm0CrtjlGykQ== Date: Fri, 27 Feb 2026 13:22:47 -0800 From: Eric Biggers To: Christoph Hellwig Cc: "Theodore Y. Ts'o" , Jaegeuk Kim , Andreas Dilger , Chao Yu , Christian Brauner , "Darrick J. Wong" , linux-fscrypt@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 04/14] ext4, fscrypt: merge fscrypt_mergeable_bio_bh into io_submit_need_new_bio Message-ID: <20260227212247.GC2659@quark> References: <20260226144954.142278-1-hch@lst.de> <20260226144954.142278-5-hch@lst.de> Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260226144954.142278-5-hch@lst.de> On Thu, Feb 26, 2026 at 06:49:24AM -0800, Christoph Hellwig wrote: > ext4 already has the inode and folio and can't have a NULL > folio->mapping in this path. Open code fscrypt_mergeable_bio_bh in > io_submit_need_new_bio based on these simplifying assumptions. > > Signed-off-by: Christoph Hellwig > --- > fs/crypto/inline_crypt.c | 23 ----------------------- > fs/ext4/page-io.c | 8 ++++++-- > include/linux/fscrypt.h | 9 --------- > 3 files changed, 6 insertions(+), 34 deletions(-) > > diff --git a/fs/crypto/inline_crypt.c b/fs/crypto/inline_crypt.c > index c0852b920dbc..0da53956a9b1 100644 > --- a/fs/crypto/inline_crypt.c > +++ b/fs/crypto/inline_crypt.c > @@ -406,29 +406,6 @@ bool fscrypt_mergeable_bio(struct bio *bio, const struct inode *inode, > } > EXPORT_SYMBOL_GPL(fscrypt_mergeable_bio); > > -/** > - * fscrypt_mergeable_bio_bh() - test whether data can be added to a bio > - * @bio: the bio being built up > - * @next_bh: the next buffer_head for which I/O will be submitted > - * > - * Same as fscrypt_mergeable_bio(), except this takes a buffer_head instead of > - * an inode and block number directly. > - * > - * Return: true iff the I/O is mergeable > - */ > -bool fscrypt_mergeable_bio_bh(struct bio *bio, > - const struct buffer_head *next_bh) > -{ > - const struct inode *inode; > - u64 next_lblk; > - > - if (!bh_get_inode_and_lblk_num(next_bh, &inode, &next_lblk)) > - return !bio->bi_crypt_context; > - > - return fscrypt_mergeable_bio(bio, inode, next_lblk); > -} > -EXPORT_SYMBOL_GPL(fscrypt_mergeable_bio_bh); > - > /** > * fscrypt_dio_supported() - check whether DIO (direct I/O) is supported on an > * inode, as far as encryption is concerned > diff --git a/fs/ext4/page-io.c b/fs/ext4/page-io.c > index 88226979c503..3db3c19a29e5 100644 > --- a/fs/ext4/page-io.c > +++ b/fs/ext4/page-io.c > @@ -441,11 +441,15 @@ static void io_submit_init_bio(struct ext4_io_submit *io, > } > > static bool io_submit_need_new_bio(struct ext4_io_submit *io, > + struct inode *inode, > + struct folio *io_folio, > struct buffer_head *bh) > { > if (bh->b_blocknr != io->io_next_block) > return true; > - if (!fscrypt_mergeable_bio_bh(io->io_bio, bh)) > + if (!fscrypt_mergeable_bio(io->io_bio, inode, > + (folio_pos(io_folio) + bh_offset(bh)) >> > + inode->i_blkbits)) > return true; > return false; > } > @@ -456,7 +460,7 @@ static void io_submit_add_bh(struct ext4_io_submit *io, > struct folio *io_folio, > struct buffer_head *bh) > { > - if (io->io_bio && io_submit_need_new_bio(io, bh)) { > + if (io->io_bio && io_submit_need_new_bio(io, inode, io_folio, bh)) { > submit_and_retry: > ext4_io_submit(io); > } As in patch 2, this needs to use 'folio', not 'io_folio'. - Eric From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 047C51039895 for ; Fri, 27 Feb 2026 21:23:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: Reply-To:From:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:In-Reply-To:MIME-Version:References: Message-ID:To:Date:Sender:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZZbxee3K9mAT/XLsDutFi3cG7cfeaSEfpKuprNU37CE=; b=N6KtTdY6Kzqsd2wjsZSKa9sakB Q3OuOGCkdOFU3C/AIK9lZm6UE6ItxnlnvA4386xY+71YDc+drzx5z3g4xEwr4UGYgq4JHIBDtRmpr lAGcS5BSiCSILzZtnXh9OS7UmJixjJBpJ6b6rMMvU5GIb/OnLfvmk0Up4X1M+gowyLBY=; Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1vw5Ie-0001bD-MU; Fri, 27 Feb 2026 21:23:04 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1vw5Id-0001b5-PF for linux-f2fs-devel@lists.sourceforge.net; Fri, 27 Feb 2026 21:23:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=OJh02u0NQVRUdBw4Dur+TyDu1G94ovO5DActNFkg/38=; b=gMmtq7l93ocv2wFHPDbEX1Rx7a 042LlGWtqMcx9kesNNLSw7H3aLddrw+/1AZA0V26hd9Ft2kPMhHeb3QtJgKaB+BXRdc/BzL/sDKGe mXSXlPh+6GaY4NxeBoKRrq1HHqH4pWE9r/yt/tYUdq4Ky1yeHAvjSRPb7akvrSULp29w=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=OJh02u0NQVRUdBw4Dur+TyDu1G94ovO5DActNFkg/38=; b=GI6Uq1GtcF/O+HhiQMlSMau7dI aTI4d9+IybSwdt3F4TGTpiFPqQ7QqTTmqxwqG1Im30Z+Ksxog8kViyUJP2xzCHvCs4gK4NAuL3OXk mx14E2s4rU6RM0W0xzG287+G7Gxgx4z38X3/aZdQfzaX97bMhx9oYAoTX9Qrlc4MyrUI=; Received: from tor.source.kernel.org ([172.105.4.254]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1vw5Id-0005yD-8L for linux-f2fs-devel@lists.sourceforge.net; Fri, 27 Feb 2026 21:23:03 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 4FC686012B; Fri, 27 Feb 2026 21:22:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 263E2C116C6; Fri, 27 Feb 2026 21:22:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772227372; bh=gdzxoUn2gxhPxqAZE2wnuoB0K0GDDb9MlkGqZ/c6Edk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IG+0YFYYtUAUb+23rDHJYKFU8SK8o4070YARNt9N3Nj/qUn8Tq4dktYf6wZ2hqh06 XZ8a5Cn7X4z2JY9gO7rFXYkCWHQDGqwWj4g28PUrzC46IgrG3tiir7tJuMpitY3gNg RFBwdzNFVmzfn969s0VhfYuE3DZx7QEMoBPM79w4+3acu0XOmfwxQ+sWyPRIt1BOvG t8h+rI7Cwfb3oqGHY5imm4je2+mBpxC0aBImRggF9jqarNyydQIe7IRUhtNxhZP1lX ErT/H4J8H8hSiZ0ehxMQK1LYebJMjhBIXoqqs8YjQurzDS3+I/RLRWj3sU540OtjDX rfm0CrtjlGykQ== Date: Fri, 27 Feb 2026 13:22:47 -0800 To: Christoph Hellwig Message-ID: <20260227212247.GC2659@quark> References: <20260226144954.142278-1-hch@lst.de> <20260226144954.142278-5-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260226144954.142278-5-hch@lst.de> X-Headers-End: 1vw5Id-0005yD-8L Subject: Re: [f2fs-dev] [PATCH 04/14] ext4, fscrypt: merge fscrypt_mergeable_bio_bh into io_submit_need_new_bio X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Eric Biggers via Linux-f2fs-devel Reply-To: Eric Biggers Cc: Christian Brauner , "Theodore Y. Ts'o" , "Darrick J. Wong" , linux-f2fs-devel@lists.sourceforge.net, linux-fscrypt@vger.kernel.org, Andreas Dilger , linux-fsdevel@vger.kernel.org, Jaegeuk Kim , linux-ext4@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Thu, Feb 26, 2026 at 06:49:24AM -0800, Christoph Hellwig wrote: > ext4 already has the inode and folio and can't have a NULL > folio->mapping in this path. Open code fscrypt_mergeable_bio_bh in > io_submit_need_new_bio based on these simplifying assumptions. > > Signed-off-by: Christoph Hellwig > --- > fs/crypto/inline_crypt.c | 23 ----------------------- > fs/ext4/page-io.c | 8 ++++++-- > include/linux/fscrypt.h | 9 --------- > 3 files changed, 6 insertions(+), 34 deletions(-) > > diff --git a/fs/crypto/inline_crypt.c b/fs/crypto/inline_crypt.c > index c0852b920dbc..0da53956a9b1 100644 > --- a/fs/crypto/inline_crypt.c > +++ b/fs/crypto/inline_crypt.c > @@ -406,29 +406,6 @@ bool fscrypt_mergeable_bio(struct bio *bio, const struct inode *inode, > } > EXPORT_SYMBOL_GPL(fscrypt_mergeable_bio); > > -/** > - * fscrypt_mergeable_bio_bh() - test whether data can be added to a bio > - * @bio: the bio being built up > - * @next_bh: the next buffer_head for which I/O will be submitted > - * > - * Same as fscrypt_mergeable_bio(), except this takes a buffer_head instead of > - * an inode and block number directly. > - * > - * Return: true iff the I/O is mergeable > - */ > -bool fscrypt_mergeable_bio_bh(struct bio *bio, > - const struct buffer_head *next_bh) > -{ > - const struct inode *inode; > - u64 next_lblk; > - > - if (!bh_get_inode_and_lblk_num(next_bh, &inode, &next_lblk)) > - return !bio->bi_crypt_context; > - > - return fscrypt_mergeable_bio(bio, inode, next_lblk); > -} > -EXPORT_SYMBOL_GPL(fscrypt_mergeable_bio_bh); > - > /** > * fscrypt_dio_supported() - check whether DIO (direct I/O) is supported on an > * inode, as far as encryption is concerned > diff --git a/fs/ext4/page-io.c b/fs/ext4/page-io.c > index 88226979c503..3db3c19a29e5 100644 > --- a/fs/ext4/page-io.c > +++ b/fs/ext4/page-io.c > @@ -441,11 +441,15 @@ static void io_submit_init_bio(struct ext4_io_submit *io, > } > > static bool io_submit_need_new_bio(struct ext4_io_submit *io, > + struct inode *inode, > + struct folio *io_folio, > struct buffer_head *bh) > { > if (bh->b_blocknr != io->io_next_block) > return true; > - if (!fscrypt_mergeable_bio_bh(io->io_bio, bh)) > + if (!fscrypt_mergeable_bio(io->io_bio, inode, > + (folio_pos(io_folio) + bh_offset(bh)) >> > + inode->i_blkbits)) > return true; > return false; > } > @@ -456,7 +460,7 @@ static void io_submit_add_bh(struct ext4_io_submit *io, > struct folio *io_folio, > struct buffer_head *bh) > { > - if (io->io_bio && io_submit_need_new_bio(io, bh)) { > + if (io->io_bio && io_submit_need_new_bio(io, inode, io_folio, bh)) { > submit_and_retry: > ext4_io_submit(io); > } As in patch 2, this needs to use 'folio', not 'io_folio'. - Eric _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel