All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denis Benato <denis.benato@linux.dev>
To: linux-kernel@vger.kernel.org
Cc: linux-input@vger.kernel.org,
	"Benjamin Tissoires" <bentiss@kernel.org>,
	"Jiri Kosina" <jikos@kernel.org>,
	"Luke D . Jones" <luke@ljones.dev>,
	"Mateusz Schyboll" <dragonn@op.pl>,
	"Denis Benato" <benato.denis96@gmail.com>,
	"Denis Benato" <denis.benato@linux.dev>
Subject: [PATCH 7/7] HID: asus: do not try to initialize the backlight if the enpoint doesn't support it
Date: Sat, 28 Feb 2026 15:46:26 +0100	[thread overview]
Message-ID: <20260228144626.1661530-8-denis.benato@linux.dev> (raw)
In-Reply-To: <20260228144626.1661530-1-denis.benato@linux.dev>

Avoid possibly printing a warning about the inability to initialize the
backlight if the hid endpoint doesn't support it.

Signed-off-by: Denis Benato <denis.benato@linux.dev>
---
 drivers/hid/hid-asus.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c
index bcf3b0c7c758..6e9a3a3d5616 100644
--- a/drivers/hid/hid-asus.c
+++ b/drivers/hid/hid-asus.c
@@ -1309,7 +1309,8 @@ static int asus_probe(struct hid_device *hdev, const struct hid_device_id *id)
 	}
 
 	if (is_vendor && (drvdata->quirks & QUIRK_USE_KBD_BACKLIGHT) &&
-	    asus_kbd_register_leds(hdev))
+	    (asus_has_report_id(hdev, FEATURE_KBD_REPORT_ID)) &&
+		(asus_kbd_register_leds(hdev)))
 		hid_warn(hdev, "Failed to initialize backlight.\n");
 
 	/*
-- 
2.53.0


      parent reply	other threads:[~2026-02-28 14:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-28 14:46 [PATCH 0/7] HID: asus: increase robustness of the driver Denis Benato
2026-02-28 14:46 ` [PATCH 1/7] HID: asus: fix code style of comments and brackets Denis Benato
2026-02-28 14:46 ` [PATCH 2/7] HID: asus: add xg mobile 2022 external hardware support Denis Benato
2026-02-28 14:46 ` [PATCH 3/7] HID: asus: fix compiler warning about unused variables Denis Benato
2026-02-28 14:46 ` [PATCH 4/7] HID: asus: make asus_resume adhere to linux kernel coding standards Denis Benato
2026-02-28 14:46 ` [PATCH 5/7] HID: asus: simplify and improve asus_kbd_set_report() Denis Benato
2026-02-28 14:46 ` [PATCH 6/7] HID: asus: do not abort probe when not necessary Denis Benato
2026-02-28 14:46 ` Denis Benato [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260228144626.1661530-8-denis.benato@linux.dev \
    --to=denis.benato@linux.dev \
    --cc=benato.denis96@gmail.com \
    --cc=bentiss@kernel.org \
    --cc=dragonn@op.pl \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luke@ljones.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.