From: Jakub Kicinski <kuba@kernel.org>
To: Antonio Quartulli <antonio@openvpn.net>
Cc: netdev@vger.kernel.org, Sabrina Dubroca <sd@queasysnail.net>,
Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net-next 0/9] pull request: ovpn 2026-02-28
Date: Sat, 28 Feb 2026 17:01:04 -0800 [thread overview]
Message-ID: <20260228170104.1ec4c133@kernel.org> (raw)
In-Reply-To: <433139b8-3aea-4db1-8ed6-959ac445cd27@openvpn.net>
On Sat, 28 Feb 2026 21:49:08 +0100 Antonio Quartulli wrote:
> On 28/02/2026 00:59, Antonio Quartulli wrote:
> > Hello netdev team!
> > Here is our first batch of new features for ovpn.
>
> Please drop this PR.
>
> The automatic checks on patchwork have highlighted a few things worth
> fixing (and the AI even found a real bug in the selftest Makefile!).
>
> Will resend the PR after fixing all issues.
Hi! I am trying to add ovpn to our netdev CI (Fedora 43).
This is what I see without this series applied:
TAP version 13
1..7
# timeout set to 45
# selftests: net/ovpn: test-chachapoly.sh
# Creating interface tun0 with mode 1
# Creating interface tun1 with mode 0
# Creating interface tun2 with mode 0
# Creating interface tun3 with mode 0
# Creating interface tun4 with mode 0
# Creating interface tun5 with mode 0
# Creating interface tun6 with mode 0
# unexpected base64 error1: BASE64 - Invalid character in input (-44)
# Error: invalid arguments.
#
And then it hangs. When I run the tests with this series applied
its still broken but at least doesn't hang (see below)
What am I missing?
# make -C tools/testing/selftests/ TARGETS=net/ovpn run_tests
make: Entering directory '/srv/vmksft/testing/wt-test/tools/testing/selftests'
make[1]: Entering directory '/srv/vmksft/testing/wt-test/tools/testing/selftests/net/ovpn'
make[1]: Nothing to be done for 'all'.
make[1]: Leaving directory '/srv/vmksft/testing/wt-test/tools/testing/selftests/net/ovpn'
make[1]: Entering directory '/srv/vmksft/testing/wt-test/tools/testing/selftests/net/ovpn'
TAP version 13
1..8
# timeout set to 45
# selftests: net/ovpn: test-chachapoly.sh
# Creating interface tun0 with mode 1
# Creating interface tun1 with mode 0
# Creating interface tun2 with mode 0
# Creating interface tun3 with mode 0
# Creating interface tun4 with mode 0
# Creating interface tun5 with mode 0
# Creating interface tun6 with mode 0
# kernel error: Unknown attribute type
# netlink reports error (-7): Invalid input data or parameter
# failed to send netlink message: Invalid argument (-22)
# cannot add peer to VPN: 1 10.10.1.2 1 5.5.5.2
# Cannot execute command: Invalid argument (-22)
not ok 1 selftests: net/ovpn: test-chachapoly.sh # exit=234
/srv/vmksft/testing/wt-test/tools/testing/selftests/kselftest/runner.sh: line 50: : No such file or directory
# timeout set to 45
# selftests: net/ovpn: test-close-socket-tcp.sh
# Deleting interface tun1 ifindex 3
# Deleting interface tun2 ifindex 3
# Deleting interface tun3 ifindex 3
# Deleting interface tun4 ifindex 3
# Deleting interface tun5 ifindex 3
# Deleting interface tun6 ifindex 3
# Creating interface tun0 with mode 1
# Creating interface tun1 with mode 0
# Creating interface tun2 with mode 0
# Creating interface tun3 with mode 0
# Creating interface tun4 with mode 0
# Creating interface tun5 with mode 0
# Creating interface tun6 with mode 0
# connected
# Connection received!
# kernel error: Unknown attribute type
# netlink reports error (-7): Invalid input data or parameter
# failed to send netlink message: Invalid argument (-22)
# cannot add peer to VPN
# Cannot execute command: Invalid argument (-22)
# kernel error: Unknown attribute type
# netlink reports error (-7): Invalid input data or parameter
# failed to send netlink message: Invalid argument (-22)
# cannot add peer to VPN: 1 5.5.5.2
# Cannot execute command: Invalid argument (-22)
not ok 2 selftests: net/ovpn: test-close-socket-tcp.sh # exit=234
/srv/vmksft/testing/wt-test/tools/testing/selftests/kselftest/runner.sh: line 50: : No such file or directory
# timeout set to 45
# selftests: net/ovpn: test-close-socket.sh
# Deleting interface tun1 ifindex 3
# Deleting interface tun2 ifindex 3
# Deleting interface tun3 ifindex 3
# Deleting interface tun4 ifindex 3
# Deleting interface tun5 ifindex 3
# Deleting interface tun6 ifindex 3
# Creating interface tun0 with mode 1
# Creating interface tun1 with mode 0
# Creating interface tun2 with mode 0
# Creating interface tun3 with mode 0
# Creating interface tun4 with mode 0
# Creating interface tun5 with mode 0
# Creating interface tun6 with mode 0
# kernel error: Unknown attribute type
# netlink reports error (-7): Invalid input data or parameter
# failed to send netlink message: Invalid argument (-22)
# cannot add peer to VPN: 1 10.10.1.2 1 5.5.5.2
# Cannot execute command: Invalid argument (-22)
not ok 3 selftests: net/ovpn: test-close-socket.sh # exit=234
/srv/vmksft/testing/wt-test/tools/testing/selftests/kselftest/runner.sh: line 50: : No such file or directory
# timeout set to 45
# selftests: net/ovpn: test-float.sh
# Deleting interface tun1 ifindex 3
# Deleting interface tun2 ifindex 3
# Deleting interface tun3 ifindex 3
# Deleting interface tun4 ifindex 3
# Deleting interface tun5 ifindex 3
# Deleting interface tun6 ifindex 3
# Creating interface tun0 with mode 1
# Creating interface tun1 with mode 0
# Creating interface tun2 with mode 0
# Creating interface tun3 with mode 0
# Creating interface tun4 with mode 0
# Creating interface tun5 with mode 0
# Creating interface tun6 with mode 0
# kernel error: Unknown attribute type
# netlink reports error (-7): Invalid input data or parameter
# failed to send netlink message: Invalid argument (-22)
# cannot add peer to VPN: 1 10.10.1.2 1 5.5.5.2
# Cannot execute command: Invalid argument (-22)
not ok 4 selftests: net/ovpn: test-float.sh # exit=234
/srv/vmksft/testing/wt-test/tools/testing/selftests/kselftest/runner.sh: line 50: : No such file or directory
# timeout set to 45
# selftests: net/ovpn: test-large-mtu.sh
# Deleting interface tun1 ifindex 3
# Deleting interface tun2 ifindex 3
# Deleting interface tun3 ifindex 3
# Deleting interface tun4 ifindex 3
# Deleting interface tun5 ifindex 3
# Deleting interface tun6 ifindex 3
# Creating interface tun0 with mode 1
# Creating interface tun1 with mode 0
# Creating interface tun2 with mode 0
# Creating interface tun3 with mode 0
# Creating interface tun4 with mode 0
# Creating interface tun5 with mode 0
# Creating interface tun6 with mode 0
# kernel error: Unknown attribute type
# netlink reports error (-7): Invalid input data or parameter
# failed to send netlink message: Invalid argument (-22)
# cannot add peer to VPN: 1 10.10.1.2 1 5.5.5.2
# Cannot execute command: Invalid argument (-22)
not ok 5 selftests: net/ovpn: test-large-mtu.sh # exit=234
/srv/vmksft/testing/wt-test/tools/testing/selftests/kselftest/runner.sh: line 50: : No such file or directory
# timeout set to 45
# selftests: net/ovpn: test-mark.sh
# Deleting interface tun1 ifindex 3
# Deleting interface tun2 ifindex 3
# Deleting interface tun3 ifindex 3
# Deleting interface tun4 ifindex 3
# Deleting interface tun5 ifindex 3
# Deleting interface tun6 ifindex 3
# Creating interface tun0 with mode 1
# Creating interface tun1 with mode 0
# Creating interface tun2 with mode 0
# Creating interface tun3 with mode 0
# kernel error: Unknown attribute type
# netlink reports error (-7): Invalid input data or parameter
# failed to send netlink message: Invalid argument (-22)
# cannot add peer to VPN: 1 10.10.1.2 1 5.5.5.2
# Cannot execute command: Invalid argument (-22)
not ok 6 selftests: net/ovpn: test-mark.sh # exit=234
/srv/vmksft/testing/wt-test/tools/testing/selftests/kselftest/runner.sh: line 50: : No such file or directory
# timeout set to 45
# selftests: net/ovpn: test-tcp.sh
# Deleting interface tun1 ifindex 3
# Deleting interface tun2 ifindex 3
# Deleting interface tun3 ifindex 3
# Creating interface tun0 with mode 1
# Creating interface tun1 with mode 0
# Creating interface tun2 with mode 0
# Creating interface tun3 with mode 0
# Creating interface tun4 with mode 0
# Creating interface tun5 with mode 0
# Creating interface tun6 with mode 0
# connected
# Connection received!
# kernel error: Unknown attribute type
# netlink reports error (-7): Invalid input data or parameter
# failed to send netlink message: Invalid argument (-22)
# cannot add peer to VPN
# Cannot execute command: Invalid argument (-22)
# kernel error: Unknown attribute type
# netlink reports error (-7): Invalid input data or parameter
# failed to send netlink message: Invalid argument (-22)
# cannot add peer to VPN: 1 5.5.5.2
# Cannot execute command: Invalid argument (-22)
not ok 7 selftests: net/ovpn: test-tcp.sh # exit=234
/srv/vmksft/testing/wt-test/tools/testing/selftests/kselftest/runner.sh: line 50: : No such file or directory
# timeout set to 45
# selftests: net/ovpn: test.sh
# Deleting interface tun1 ifindex 3
# Deleting interface tun2 ifindex 3
# Deleting interface tun3 ifindex 3
# Deleting interface tun4 ifindex 3
# Deleting interface tun5 ifindex 3
# Deleting interface tun6 ifindex 3
# Creating interface tun0 with mode 1
# Creating interface tun1 with mode 0
# Creating interface tun2 with mode 0
# Creating interface tun3 with mode 0
# Creating interface tun4 with mode 0
# Creating interface tun5 with mode 0
# Creating interface tun6 with mode 0
# kernel error: Unknown attribute type
# netlink reports error (-7): Invalid input data or parameter
# failed to send netlink message: Invalid argument (-22)
# cannot add peer to VPN: 1 10.10.1.2 1 5.5.5.2
# Cannot execute command: Invalid argument (-22)
not ok 8 selftests: net/ovpn: test.sh # exit=234
next prev parent reply other threads:[~2026-03-01 1:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-27 23:59 [PATCH net-next 0/9] pull request: ovpn 2026-02-28 Antonio Quartulli
2026-02-27 23:59 ` [PATCH net-next 1/9] selftests: ovpn: allow compiling ovpn-cli.c with mbedtls3 Antonio Quartulli
2026-02-27 23:59 ` [PATCH net-next 2/9] ovpn: use correct array size to parse nested attributes in ovpn_nl_key_swap_doit Antonio Quartulli
2026-02-27 23:59 ` [PATCH net-next 3/9] ovpn: pktid: use bitops.h API Antonio Quartulli
2026-02-27 23:59 ` [PATCH net-next 4/9] ovpn: notify userspace on client float event Antonio Quartulli
2026-02-27 23:59 ` [PATCH net-next 5/9] selftests: ovpn: add notification parsing and matching Antonio Quartulli
2026-02-27 23:59 ` [PATCH net-next 6/9] ovpn: add support for asymmetric peer IDs Antonio Quartulli
2026-02-27 23:59 ` [PATCH net-next 7/9] selftests: ovpn: check asymmetric peer-id Antonio Quartulli
2026-02-27 23:59 ` [PATCH net-next 8/9] selftests: ovpn: add test for the FW mark feature Antonio Quartulli
2026-02-27 23:59 ` [PATCH net-next 9/9] ovpn: consolidate crypto allocations in one chunk Antonio Quartulli
2026-02-28 20:49 ` [PATCH net-next 0/9] pull request: ovpn 2026-02-28 Antonio Quartulli
2026-03-01 1:01 ` Jakub Kicinski [this message]
2026-03-03 21:02 ` Antonio Quartulli
2026-03-03 21:39 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260228170104.1ec4c133@kernel.org \
--to=kuba@kernel.org \
--cc=antonio@openvpn.net \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.