From: Paul Tarjan <paul@paultarjan.com>
To: git@vger.kernel.org
Cc: koji.nakamaru@gree.net, Paul Tarjan <github@paulisageek.com>
Subject: Re: [PATCH] fsmonitor-watchman: fix variable reference and remove redundant code
Date: Sat, 28 Feb 2026 10:33:14 -0700 [thread overview]
Message-ID: <20260228173314.97952-1-github@paulisageek.com> (raw)
In-Reply-To: <CAOTNsDyy2ZQDhkVyML6j5naS_UC=SjE915hjygj+QmKe4bqc=A@mail.gmail.com>
Koji Nakamaru <koji.nakamaru@gree.net> writes:
> Although I don't have much experience with the Watchman backend, the
> fixes look correct to me.
>
> One suggestion: it seems we can make the code even cleaner by removing
> $retry and its associated logic, as they appear to be no longer
> necessary after these changes.
Good point. $retry only existed to prevent the infinite recursion
from the recursive launch_watchman() call, so now that we've
removed that call it's dead code. Cleaned it up in v2.
Thanks for the review,
Paul
next prev parent reply other threads:[~2026-02-28 17:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-26 1:33 [PATCH] fsmonitor: fix two bugs in watchman hook retry path Paul Tarjan via GitGitGadget
2026-02-08 6:03 ` Paul Tarjan
2026-02-27 6:25 ` [PATCH] fsmonitor-watchman: fix variable reference and remove redundant code Paul Tarjan
2026-02-28 17:02 ` [PATCH] fsmonitor: fix two bugs in watchman hook retry path Koji Nakamaru
2026-02-28 17:33 ` Paul Tarjan [this message]
2026-02-28 17:15 ` brian m. carlson
2026-02-28 17:33 ` [PATCH] fsmonitor-watchman: fix variable reference and remove redundant code Paul Tarjan
2026-02-28 17:37 ` [PATCH v2] " Paul Tarjan via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260228173314.97952-1-github@paulisageek.com \
--to=paul@paultarjan.com \
--cc=git@vger.kernel.org \
--cc=github@paulisageek.com \
--cc=koji.nakamaru@gree.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.