From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7C0C430BBE for ; Sun, 1 Mar 2026 04:48:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.13 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772340526; cv=none; b=W4UaoVTqk0iWk/euQGgZ6KKhIoLCoIy20Db1vzbEhDZhPv9VvY5HeZAi8UUrvhxI8U/SFRlHEY8TbipW6Uzm0+31elpW5ntxd4orXGNdI2OwXx9TjJqZOx9PIyBCshSmtSsoWAMsWo+t5NJwuInXvAiGKoXWXkn75JkPxv0L3S4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772340526; c=relaxed/simple; bh=a0W6ztvFZeg8HRMhjiAWXqsmafBjmB0+e0TeWsjBrYA=; h=Date:From:To:Cc:Subject:Message-ID; b=dMqBWW33dHSxd9ikfbu5QtUXBws54U5guJLGmhaI+pAEGQuLKEwyNifzYqdDsU0hWjCJJwlLb2O5MyXIpM54yoogkyLVpb4bXHId5cT/S0bx5QeB6r7XWTZe6uNPTV+JWjiOpFCKyWYc+c2CjOIsWQq5fX2erV0KtLx1g+kb9pU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=H9TX6w/O; arc=none smtp.client-ip=192.198.163.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="H9TX6w/O" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1772340524; x=1803876524; h=date:from:to:cc:subject:message-id; bh=a0W6ztvFZeg8HRMhjiAWXqsmafBjmB0+e0TeWsjBrYA=; b=H9TX6w/OjhnrrvoOh+Wom6EEev0njUnForb38I75avt8NLX0RHj//FsC itwC4SfaLpFT6H7Exz91dPH1BpJthru8c87hwGqjDzDrZ/Ci6xx/0XUmT 7evWLfofWQHCBlcqx4eWnI1ueWqQCXssQ7ii3Z3UIqzxzdfccve5d8F/x yoPoPmaOsJgexzZ3+H/dGrJICoucJAE4tqyo2624fVdS1DDAHTTGOoIj3 bnJwl+kI7yjDW0kpf8dk6BaWPBB6/5vVI1wAken94vybcOuj+mDoKvBu1 RYNZicskdQcuD3KGan6xEB9Mr2kcZT1iNjIveAzVANz5KAeGDfsGK5dEc g==; X-CSE-ConnectionGUID: 7xKeVbWeSvaMAtHlA9Nzmw== X-CSE-MsgGUID: 31+kkefvT4u31pQoEWR5VA== X-IronPort-AV: E=McAfee;i="6800,10657,11715"; a="75985698" X-IronPort-AV: E=Sophos;i="6.21,317,1763452800"; d="scan'208";a="75985698" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Feb 2026 20:48:44 -0800 X-CSE-ConnectionGUID: PV8Ya7C4Rsah7V/XTfgcbw== X-CSE-MsgGUID: PLYiSBaRQ3+mFT6R6pr5Yw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,317,1763452800"; d="scan'208";a="217407050" Received: from lkp-server01.sh.intel.com (HELO 59784f1c7b2a) ([10.239.97.150]) by orviesa007.jf.intel.com with ESMTP; 28 Feb 2026 20:48:42 -0800 Received: from kbuild by 59784f1c7b2a with local (Exim 4.98.2) (envelope-from ) id 1vwYjQ-000000001HZ-0VUL; Sun, 01 Mar 2026 04:48:40 +0000 Date: Sun, 01 Mar 2026 12:48:02 +0800 From: kernel test robot To: oe-kbuild@lists.linux.dev Cc: lkp@intel.com, Dan Carpenter Subject: [dhowells-fs:netfs-next 10/16] fs/netfs/write_issue.c:850 netfs_writeback_single() warn: inconsistent returns '&ictx->wb_lock'. Message-ID: <202603011243.LsWeX4QE-lkp@intel.com> User-Agent: s-nail v14.9.25 Precedence: bulk X-Mailing-List: oe-kbuild@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: BCC: lkp@intel.com CC: oe-kbuild-all@lists.linux.dev TO: David Howells tree: https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git netfs-next head: 64a2722c2705a6c6f46b7214477a4a0a2106c1b6 commit: a1cee75a302b7af9ddd2449d38863fb935066e80 [10/16] netfs: Switch to using bvecq rather than folio_queue and rolling_buffer :::::: branch date: 6 hours ago :::::: commit date: 7 hours ago config: x86_64-randconfig-r073-20260301 (https://download.01.org/0day-ci/archive/20260301/202603011243.LsWeX4QE-lkp@intel.com/config) compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261) rustc: rustc 1.88.0 (6b00bc388 2025-06-23) smatch version: v0.5.0-8994-gd50c5a4c If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202603011243.LsWeX4QE-lkp@intel.com/ smatch warnings: fs/netfs/write_issue.c:850 netfs_writeback_single() warn: inconsistent returns '&ictx->wb_lock'. vim +850 fs/netfs/write_issue.c 288ace2f57c9d0 David Howells 2024-03-18 763 49866ce7ea8d41 David Howells 2024-12-16 764 /** 49866ce7ea8d41 David Howells 2024-12-16 765 * netfs_writeback_single - Write back a monolithic payload 49866ce7ea8d41 David Howells 2024-12-16 766 * @mapping: The mapping to write from 49866ce7ea8d41 David Howells 2024-12-16 767 * @wbc: Hints from the VM 4e45977f1ea9ab David Howells 2026-01-07 768 * @iter: Data to write. 49866ce7ea8d41 David Howells 2024-12-16 769 * 49866ce7ea8d41 David Howells 2024-12-16 770 * Write a monolithic, non-pagecache object back to the server and/or a1cee75a302b7a David Howells 2026-02-28 771 * the cache. There's a maximum of one subrequest per stream. 49866ce7ea8d41 David Howells 2024-12-16 772 */ 49866ce7ea8d41 David Howells 2024-12-16 773 int netfs_writeback_single(struct address_space *mapping, 49866ce7ea8d41 David Howells 2024-12-16 774 struct writeback_control *wbc, 49866ce7ea8d41 David Howells 2024-12-16 775 struct iov_iter *iter) 49866ce7ea8d41 David Howells 2024-12-16 776 { 49866ce7ea8d41 David Howells 2024-12-16 777 struct netfs_io_request *wreq; 49866ce7ea8d41 David Howells 2024-12-16 778 struct netfs_inode *ictx = netfs_inode(mapping->host); 49866ce7ea8d41 David Howells 2024-12-16 779 int ret; 49866ce7ea8d41 David Howells 2024-12-16 780 49866ce7ea8d41 David Howells 2024-12-16 781 if (!mutex_trylock(&ictx->wb_lock)) { 49866ce7ea8d41 David Howells 2024-12-16 782 if (wbc->sync_mode == WB_SYNC_NONE) { 49866ce7ea8d41 David Howells 2024-12-16 783 netfs_stat(&netfs_n_wb_lock_skip); 49866ce7ea8d41 David Howells 2024-12-16 784 return 0; 49866ce7ea8d41 David Howells 2024-12-16 785 } 49866ce7ea8d41 David Howells 2024-12-16 786 netfs_stat(&netfs_n_wb_lock_wait); 49866ce7ea8d41 David Howells 2024-12-16 787 mutex_lock(&ictx->wb_lock); 49866ce7ea8d41 David Howells 2024-12-16 788 } 49866ce7ea8d41 David Howells 2024-12-16 789 49866ce7ea8d41 David Howells 2024-12-16 790 wreq = netfs_create_write_req(mapping, NULL, 0, NETFS_WRITEBACK_SINGLE); 49866ce7ea8d41 David Howells 2024-12-16 791 if (IS_ERR(wreq)) { 49866ce7ea8d41 David Howells 2024-12-16 792 ret = PTR_ERR(wreq); 49866ce7ea8d41 David Howells 2024-12-16 793 goto couldnt_start; 49866ce7ea8d41 David Howells 2024-12-16 794 } 4e45977f1ea9ab David Howells 2026-01-07 795 wreq->len = iov_iter_count(iter); 4e45977f1ea9ab David Howells 2026-01-07 796 a1cee75a302b7a David Howells 2026-02-28 797 ret = netfs_extract_iter(iter, wreq->len, INT_MAX, 0, &wreq->dispatch_cursor.bvecq, 0); a1cee75a302b7a David Howells 2026-02-28 798 if (ret < 0) a1cee75a302b7a David Howells 2026-02-28 799 goto cleanup_free; a1cee75a302b7a David Howells 2026-02-28 800 if (ret < wreq->len) { a1cee75a302b7a David Howells 2026-02-28 801 ret = -EIO; a1cee75a302b7a David Howells 2026-02-28 802 goto cleanup_free; a1cee75a302b7a David Howells 2026-02-28 803 } a1cee75a302b7a David Howells 2026-02-28 804 a1cee75a302b7a David Howells 2026-02-28 805 bvecq_pos_attach(&wreq->collect_cursor, &wreq->dispatch_cursor); a1cee75a302b7a David Howells 2026-02-28 806 2b1424cd131cfa David Howells 2025-05-19 807 __set_bit(NETFS_RREQ_OFFLOAD_COLLECTION, &wreq->flags); 20d72b00ca814d David Howells 2025-05-19 808 trace_netfs_write(wreq, netfs_write_trace_writeback_single); 49866ce7ea8d41 David Howells 2024-12-16 809 netfs_stat(&netfs_n_wh_writepages); 49866ce7ea8d41 David Howells 2024-12-16 810 49866ce7ea8d41 David Howells 2024-12-16 811 if (__test_and_set_bit(NETFS_RREQ_UPLOAD_TO_SERVER, &wreq->flags)) 49866ce7ea8d41 David Howells 2024-12-16 812 wreq->netfs_ops->begin_writeback(wreq); 49866ce7ea8d41 David Howells 2024-12-16 813 4e45977f1ea9ab David Howells 2026-01-07 814 for (int s = 0; s < NR_IO_STREAMS; s++) { 4e45977f1ea9ab David Howells 2026-01-07 815 struct netfs_io_subrequest *subreq; 4e45977f1ea9ab David Howells 2026-01-07 816 struct netfs_io_stream *stream = &wreq->io_streams[s]; 49866ce7ea8d41 David Howells 2024-12-16 817 4e45977f1ea9ab David Howells 2026-01-07 818 if (!stream->avail) 4e45977f1ea9ab David Howells 2026-01-07 819 continue; 49866ce7ea8d41 David Howells 2024-12-16 820 4e45977f1ea9ab David Howells 2026-01-07 821 netfs_prepare_write(wreq, stream, 0); 4e45977f1ea9ab David Howells 2026-01-07 822 4e45977f1ea9ab David Howells 2026-01-07 823 subreq = stream->construct; 4e45977f1ea9ab David Howells 2026-01-07 824 subreq->len = wreq->len; 4e45977f1ea9ab David Howells 2026-01-07 825 stream->submit_len = subreq->len; 4e45977f1ea9ab David Howells 2026-01-07 826 4e45977f1ea9ab David Howells 2026-01-07 827 netfs_issue_write(wreq, stream); 49866ce7ea8d41 David Howells 2024-12-16 828 } 49866ce7ea8d41 David Howells 2024-12-16 829 a1cee75a302b7a David Howells 2026-02-28 830 wreq->submitted = wreq->len; 49866ce7ea8d41 David Howells 2024-12-16 831 smp_wmb(); /* Write lists before ALL_QUEUED. */ 49866ce7ea8d41 David Howells 2024-12-16 832 set_bit(NETFS_RREQ_ALL_QUEUED, &wreq->flags); 49866ce7ea8d41 David Howells 2024-12-16 833 49866ce7ea8d41 David Howells 2024-12-16 834 mutex_unlock(&ictx->wb_lock); 2b1424cd131cfa David Howells 2025-05-19 835 netfs_wake_collector(wreq); 49866ce7ea8d41 David Howells 2024-12-16 836 4e45977f1ea9ab David Howells 2026-01-07 837 /* TODO: Might want to be async here if WB_SYNC_NONE, but then need to 4e45977f1ea9ab David Howells 2026-01-07 838 * wait before modifying. 4e45977f1ea9ab David Howells 2026-01-07 839 */ 4e45977f1ea9ab David Howells 2026-01-07 840 ret = netfs_wait_for_write(wreq); 4e45977f1ea9ab David Howells 2026-01-07 841 a1cee75a302b7a David Howells 2026-02-28 842 cleanup_free: 20d72b00ca814d David Howells 2025-05-19 843 netfs_put_request(wreq, netfs_rreq_trace_put_return); 49866ce7ea8d41 David Howells 2024-12-16 844 _leave(" = %d", ret); 49866ce7ea8d41 David Howells 2024-12-16 845 return ret; 49866ce7ea8d41 David Howells 2024-12-16 846 49866ce7ea8d41 David Howells 2024-12-16 847 couldnt_start: 49866ce7ea8d41 David Howells 2024-12-16 848 mutex_unlock(&ictx->wb_lock); 49866ce7ea8d41 David Howells 2024-12-16 849 _leave(" = %d", ret); 49866ce7ea8d41 David Howells 2024-12-16 @850 return ret; :::::: The code at line 850 was first introduced by commit :::::: 49866ce7ea8d41a3dc198f519cc9caa2d6be1891 netfs: Add support for caching single monolithic objects such as AFS dirs :::::: TO: David Howells :::::: CC: Christian Brauner -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD2D41E1DE5 for ; Mon, 2 Mar 2026 09:04:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772442289; cv=none; b=Y+Ln0lbULS7oR6nRstdSB5J2iTBepDc/Z/D/OVKAJatuHrrp7Ye2ZNYXQIgSI3HLNE72lD37QsFZq0h3RKs2bzb28lLrBztbSjiCxui6XVbr0K0disv9bwq3f+keVH89EmoZudF4sd9Z+0P3xLfH1aNm1e9Y8BiXdVPlZ0EXMc8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772442289; c=relaxed/simple; bh=wiZg4QESYaLfSKXmkqAIc0SzRuV0kpN1uIrlXBV7Yu4=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=dp8eIUygyKoCPRC6JBxxvGL+UcQ+6Q99Uf1Xzude4nQijGVx+PzxZQ/fDysyFuXLcVTZiO2/fzPRJMzdYXvUs6DHleX+qn3fkTe0EwOjh2pjDA6UheYwbsDwNjwi8rQ0ukP8XpXvBDdzrqWZufcd95FtGXbB/T5EIAp5QAi7cZA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=uC58ScPd; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="uC58ScPd" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-48371bb515eso63823765e9.1 for ; Mon, 02 Mar 2026 01:04:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1772442285; x=1773047085; darn=lists.linux.dev; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=a+bEuvjKvnYpY8GTaPhGwnpzsAMFNgIibApkwJ+YvoU=; b=uC58ScPdMctO72hbyB4CnpPx9Q1M5e9U6X1AnXSDqtni+5p3psSDDSdZaToqjfwTIZ 1KG1oe90rdN6WTd2nqBH+P0pjtraRwaYhjztJCFA/YW5nFi1h20V2foWIm4nsQhY28mu pbD2sgSBB+cU5xDLB3Jfukzm+uH6TJoFS/Gpjsmn7EN8IbLjuWU3ZNPy2GDMbN7I6sMx Diol4/Cy7ekB9qOdwMYP1DgV/qGpg1fTDoE5IPl00Gd5JwO2WzPuLI1TuWbeYqXgl0Ho cuXfs16hRVmVi8EyKCaMLDSQHvqIwuEu/fgpuD+lSpnUzEvQl5ifxyHCJERjdgSMZ/It AK+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772442285; x=1773047085; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=a+bEuvjKvnYpY8GTaPhGwnpzsAMFNgIibApkwJ+YvoU=; b=mUtEM1XXFJ007qATCDzjorgLlYO4FSTz1+40YsKp40ntsgFSMNAsSk6BmAgQVAxLpQ 90JDL2bPv78amgrSk/D97wJaAKE1gwyaEaEvJBcYsk5AmnbNMFQwpDVLv8edJULg/B+V vj0mVVi2HZ1S4PSVh4pjA4lXq715ii+g6dashCGcRj/+/AYh2IdAbgHbGmoFhAyOGxg8 XEFXWIUC946Kd7BFe6iPY8yuZZ0Tgg3d+lQx48oh1bvgF2vNWyv1pTHqDCg8/jC/Ul8Z EGhl2r0d9Dx19ZBejVtN4Ln4F0FQVfLQVkZBDX4SSn7x9NbRMHm5u/dKHpDCBaB4Ahf8 w9fQ== X-Gm-Message-State: AOJu0YwhNWdtRpofML1q9aqBL2Ph4Two0zYPqNu+hUiPIxPXnM7gMIKB Zr58/90qBjgu7sWRvgxL8SCxrh9sfYWQILtuJOc9IcudD3eb58N6U70e9POfRWlMLVb/kGi42u/ 7ew2Z X-Gm-Gg: ATEYQzwDYRgik+jvukgxBBEu1xRJxRy9asB4f4wkJUng/tUalPSKF07pElRydtnzh90 KtzK+a1t4sdWZ6h/kmJyeZa2SuB4Ox+rmAt4qpfKt6i9OGCH/s9+rpqEzFYhgm6ms4IwCQKJL3f Xi0NgMCZiI6db4w5+Z4MVQME+INHY1hJ5rTp4B8z/ynhmAoWcZuOEVXzpttWJXWChbgyHxBnwQc yIeZqW5L9xtzfrESfS7q4ibecLkDVAd0Tuj1Dn0+/kuuDGUw3uKdNH4IlXgQtHaaly9HKvRkT/q GsUvwAUxqykxklQPgMVZ7D+U7dhawYWf+B2q55OvwvwOz6JJmpsiqcdiUfMAhtQLO4yKS4fL6xQ y8C8rkwTp+EmrECyyBVS3hZvROgrYscKLRj6EDDEmNbWNgV1Wikg77fNxf6RMbWoPR5badyLCdF xVfJVB104SLF/7OmnRC7wMPdomhpIi X-Received: by 2002:a05:600c:46d5:b0:477:a36f:1a57 with SMTP id 5b1f17b1804b1-483c9bb7c16mr190306005e9.3.1772442285409; Mon, 02 Mar 2026 01:04:45 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483bfbb6d16sm182125425e9.5.2026.03.02.01.04.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Mar 2026 01:04:43 -0800 (PST) Date: Mon, 2 Mar 2026 12:04:40 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, David Howells Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev Subject: [dhowells-fs:netfs-next 10/16] fs/netfs/write_issue.c:850 netfs_writeback_single() warn: inconsistent returns '&ictx->wb_lock'. Message-ID: <202603011243.LsWeX4QE-lkp@intel.com> Precedence: bulk X-Mailing-List: oe-kbuild@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Message-ID: <20260302090440.vQ87jbglDSN_6CL1da3oYKCz02Bd0s5_0RjcJr6DDOs@z> tree: https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git netfs-next head: 64a2722c2705a6c6f46b7214477a4a0a2106c1b6 commit: a1cee75a302b7af9ddd2449d38863fb935066e80 [10/16] netfs: Switch to using bvecq rather than folio_queue and rolling_buffer config: x86_64-randconfig-r073-20260301 (https://download.01.org/0day-ci/archive/20260301/202603011243.LsWeX4QE-lkp@intel.com/config) compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261) rustc: rustc 1.88.0 (6b00bc388 2025-06-23) smatch version: v0.5.0-8994-gd50c5a4c If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202603011243.LsWeX4QE-lkp@intel.com/ smatch warnings: fs/netfs/write_issue.c:850 netfs_writeback_single() warn: inconsistent returns '&ictx->wb_lock'. vim +850 fs/netfs/write_issue.c 49866ce7ea8d41 David Howells 2024-12-16 773 int netfs_writeback_single(struct address_space *mapping, 49866ce7ea8d41 David Howells 2024-12-16 774 struct writeback_control *wbc, 49866ce7ea8d41 David Howells 2024-12-16 775 struct iov_iter *iter) 49866ce7ea8d41 David Howells 2024-12-16 776 { 49866ce7ea8d41 David Howells 2024-12-16 777 struct netfs_io_request *wreq; 49866ce7ea8d41 David Howells 2024-12-16 778 struct netfs_inode *ictx = netfs_inode(mapping->host); 49866ce7ea8d41 David Howells 2024-12-16 779 int ret; 49866ce7ea8d41 David Howells 2024-12-16 780 49866ce7ea8d41 David Howells 2024-12-16 781 if (!mutex_trylock(&ictx->wb_lock)) { 49866ce7ea8d41 David Howells 2024-12-16 782 if (wbc->sync_mode == WB_SYNC_NONE) { 49866ce7ea8d41 David Howells 2024-12-16 783 netfs_stat(&netfs_n_wb_lock_skip); 49866ce7ea8d41 David Howells 2024-12-16 784 return 0; Unlock before returning? 49866ce7ea8d41 David Howells 2024-12-16 785 } 49866ce7ea8d41 David Howells 2024-12-16 786 netfs_stat(&netfs_n_wb_lock_wait); 49866ce7ea8d41 David Howells 2024-12-16 787 mutex_lock(&ictx->wb_lock); 49866ce7ea8d41 David Howells 2024-12-16 788 } 49866ce7ea8d41 David Howells 2024-12-16 789 49866ce7ea8d41 David Howells 2024-12-16 790 wreq = netfs_create_write_req(mapping, NULL, 0, NETFS_WRITEBACK_SINGLE); 49866ce7ea8d41 David Howells 2024-12-16 791 if (IS_ERR(wreq)) { 49866ce7ea8d41 David Howells 2024-12-16 792 ret = PTR_ERR(wreq); 49866ce7ea8d41 David Howells 2024-12-16 793 goto couldnt_start; 49866ce7ea8d41 David Howells 2024-12-16 794 } 4e45977f1ea9ab David Howells 2026-01-07 795 wreq->len = iov_iter_count(iter); 4e45977f1ea9ab David Howells 2026-01-07 796 a1cee75a302b7a David Howells 2026-02-28 797 ret = netfs_extract_iter(iter, wreq->len, INT_MAX, 0, &wreq->dispatch_cursor.bvecq, 0); a1cee75a302b7a David Howells 2026-02-28 798 if (ret < 0) a1cee75a302b7a David Howells 2026-02-28 799 goto cleanup_free; a1cee75a302b7a David Howells 2026-02-28 800 if (ret < wreq->len) { a1cee75a302b7a David Howells 2026-02-28 801 ret = -EIO; a1cee75a302b7a David Howells 2026-02-28 802 goto cleanup_free; a1cee75a302b7a David Howells 2026-02-28 803 } a1cee75a302b7a David Howells 2026-02-28 804 a1cee75a302b7a David Howells 2026-02-28 805 bvecq_pos_attach(&wreq->collect_cursor, &wreq->dispatch_cursor); a1cee75a302b7a David Howells 2026-02-28 806 2b1424cd131cfa David Howells 2025-05-19 807 __set_bit(NETFS_RREQ_OFFLOAD_COLLECTION, &wreq->flags); 20d72b00ca814d David Howells 2025-05-19 808 trace_netfs_write(wreq, netfs_write_trace_writeback_single); 49866ce7ea8d41 David Howells 2024-12-16 809 netfs_stat(&netfs_n_wh_writepages); 49866ce7ea8d41 David Howells 2024-12-16 810 49866ce7ea8d41 David Howells 2024-12-16 811 if (__test_and_set_bit(NETFS_RREQ_UPLOAD_TO_SERVER, &wreq->flags)) 49866ce7ea8d41 David Howells 2024-12-16 812 wreq->netfs_ops->begin_writeback(wreq); 49866ce7ea8d41 David Howells 2024-12-16 813 4e45977f1ea9ab David Howells 2026-01-07 814 for (int s = 0; s < NR_IO_STREAMS; s++) { 4e45977f1ea9ab David Howells 2026-01-07 815 struct netfs_io_subrequest *subreq; 4e45977f1ea9ab David Howells 2026-01-07 816 struct netfs_io_stream *stream = &wreq->io_streams[s]; 49866ce7ea8d41 David Howells 2024-12-16 817 4e45977f1ea9ab David Howells 2026-01-07 818 if (!stream->avail) 4e45977f1ea9ab David Howells 2026-01-07 819 continue; 49866ce7ea8d41 David Howells 2024-12-16 820 4e45977f1ea9ab David Howells 2026-01-07 821 netfs_prepare_write(wreq, stream, 0); 4e45977f1ea9ab David Howells 2026-01-07 822 4e45977f1ea9ab David Howells 2026-01-07 823 subreq = stream->construct; 4e45977f1ea9ab David Howells 2026-01-07 824 subreq->len = wreq->len; 4e45977f1ea9ab David Howells 2026-01-07 825 stream->submit_len = subreq->len; 4e45977f1ea9ab David Howells 2026-01-07 826 4e45977f1ea9ab David Howells 2026-01-07 827 netfs_issue_write(wreq, stream); 49866ce7ea8d41 David Howells 2024-12-16 828 } 49866ce7ea8d41 David Howells 2024-12-16 829 a1cee75a302b7a David Howells 2026-02-28 830 wreq->submitted = wreq->len; 49866ce7ea8d41 David Howells 2024-12-16 831 smp_wmb(); /* Write lists before ALL_QUEUED. */ 49866ce7ea8d41 David Howells 2024-12-16 832 set_bit(NETFS_RREQ_ALL_QUEUED, &wreq->flags); 49866ce7ea8d41 David Howells 2024-12-16 833 49866ce7ea8d41 David Howells 2024-12-16 834 mutex_unlock(&ictx->wb_lock); 2b1424cd131cfa David Howells 2025-05-19 835 netfs_wake_collector(wreq); 49866ce7ea8d41 David Howells 2024-12-16 836 4e45977f1ea9ab David Howells 2026-01-07 837 /* TODO: Might want to be async here if WB_SYNC_NONE, but then need to 4e45977f1ea9ab David Howells 2026-01-07 838 * wait before modifying. 4e45977f1ea9ab David Howells 2026-01-07 839 */ 4e45977f1ea9ab David Howells 2026-01-07 840 ret = netfs_wait_for_write(wreq); 4e45977f1ea9ab David Howells 2026-01-07 841 a1cee75a302b7a David Howells 2026-02-28 842 cleanup_free: 20d72b00ca814d David Howells 2025-05-19 843 netfs_put_request(wreq, netfs_rreq_trace_put_return); 49866ce7ea8d41 David Howells 2024-12-16 844 _leave(" = %d", ret); 49866ce7ea8d41 David Howells 2024-12-16 845 return ret; 49866ce7ea8d41 David Howells 2024-12-16 846 49866ce7ea8d41 David Howells 2024-12-16 847 couldnt_start: 49866ce7ea8d41 David Howells 2024-12-16 848 mutex_unlock(&ictx->wb_lock); 49866ce7ea8d41 David Howells 2024-12-16 849 _leave(" = %d", ret); 49866ce7ea8d41 David Howells 2024-12-16 @850 return ret; -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki