From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 354001E1DE5 for ; Mon, 2 Mar 2026 08:55:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772441714; cv=none; b=ReWz4TFvBR8KaruKRDQzOVr4eZm0lUqtKeUt+4rJNq+5DfGqIu7IprA9KdMt64Jwi4u6Nb6DKZgY4COUdc97LXUSOe0T0vBngkb6PXZKTo/vF6CTzygC8W0tds4EP42ZxsplBidfeDRfa8MS0KWKcVodvFzkBtTnWlglh8vOF0o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772441714; c=relaxed/simple; bh=fWKHZnhM2AFgK2NZeDXJFryewoq1HSjdJbh/M57qUy0=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=SU7oKdGw5e8r9x3cn7j8eutFJ1fYnARejllA03VRBVVbIiBz6nf+c5+AfIPQF/L5I3/98qgl3ZU5dPNMg5WT2boJ2N0Ov+jBHQsAkAPRSXMD470SUuVFnY1l40Wjvk8ixX0hVUct5989N5TQcn4b3ftf+jBEUoPEgGFE734THQM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=JHGl83/E; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="JHGl83/E" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id B95B21A2117; Mon, 2 Mar 2026 08:55:10 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 8A7635FE89; Mon, 2 Mar 2026 08:55:10 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id A417410369514; Mon, 2 Mar 2026 09:55:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1772441709; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=GolTPQTz/JkLYWONicK1ZiOMxmW8WOdbYREGhj5V2VE=; b=JHGl83/EukVWIZ/SFdAWt9yhzJriahQdYX09JxyQMGmtBSCskhZN7xckRr17bc2Vw62UfB qcGKw/ehj38y6m8ranUWNvyq3NRat6jfinq37P9NycrZiU/fSo6zR+MAJiG9AhmJ7KC/l4 pBFI+KMgG5bhtUnvQCPWwENae2cpXhV2+vViIDxFpYE7xo882EU8nRvBOjJ0gdwpsXhLqI sRiEnHGjGE2s52NWpuK1u5OwsdRnqI2clKShjvkoUZcd+o/kBWHnQdvFWe0ePY9nwbq5ui iQ6Wugpy3aHWjvYrs8kRkNbHf2N86vXCFfVQ/+D6u5JeWKdfRBxrq2xPO8mA1Q== Date: Mon, 2 Mar 2026 09:55:01 +0100 From: Herve Codina To: Conor Dooley Cc: linux-gpio@vger.kernel.org, Conor Dooley , Thomas Gleixner , Daire McNamara , Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Linus Walleij , Bartosz Golaszewski , linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC v11 1/4] gpio: mpfs: Add interrupt support Message-ID: <20260302095501.3104146f@bootlin.com> In-Reply-To: <20260227-divinely-drift-93307c6763d8@spud> References: <20260227-ajar-wolverine-7ce1ebd79821@spud> <20260227-divinely-drift-93307c6763d8@spud> Organization: Bootlin X-Mailer: Claws Mail 4.3.1 (GTK 3.24.49; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Last-TLS-Session-Version: TLSv1.3 Hi Conor, On Fri, 27 Feb 2026 14:52:27 +0000 Conor Dooley wrote: > From: Conor Dooley > > Add support for interrupts to the PolarFire SoC GPIO driver. Each GPIO > has an independent interrupt that is wired to an interrupt mux that sits > between the controllers and the PLIC. The SoC has more GPIO lines than > connections from the mux to the PLIC, so some GPIOs must share PLIC > interrupts. The configuration is not static and is set at runtime, > conventionally by the platform's firmware. CoreGPIO, the version > intended for use in the FPGA fabric has two interrupt output ports, one > is IO_NUM bits wide, as is used in the hardened cores, and the other is > a single bit with all lines ORed together. > > Signed-off-by: Conor Dooley > --- > Doing the chained thing kinda covers all the bases at the expense of the > "direct" mode interrupts that have a dedicated connection to the PLIC. Seems ok on my side. Just a nitpick in probe(). Reviewed-by: Herve Codina ... > static int mpfs_gpio_probe(struct platform_device *pdev) > { > struct device *dev = &pdev->dev; > + struct device_node *node = pdev->dev.of_node; dev->of_node instead of pdev->dev.of_node. or move 'struct device_node *node = pdev->dev.of_node;' at first position (reverse Xmas tree). > struct mpfs_gpio_chip *mpfs_gpio; > + struct gpio_irq_chip *girq; Best regards, Hervé From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DCAA1D58E7A for ; Mon, 2 Mar 2026 08:55:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QTR713NVSwW1zHiTdfbDUS2ZRFPpOVphcfUWhPUy7Uk=; b=roKFJVZ+0bJeSU Ie98MsGINSd1xQ9h2OB5uECJaXe/EHwl2Vh8np7B5C3IzSrJWyE0gfh0ttyv+5nnr8TCPdillf/n6 +JgseUpJlHZpRuZPw41eaKzC8tcNjks5MXbxGeq3mJ39gfDpOtlL+IZeGC05NyYuVtYjeoFU+mMZF zAnzvPBCsXN2aHSA/jd8PW1W0cf+y7A475FRgZuTBY9v4HnSAjYKaaHBvVnO04R2Xvl0jzKiualJs 5QawKfWIpkPyF2CggPhH5X1chtd2D8YBjUfJsys5yHtxgISFbFlSnap0QZbLuenN8rmirdQ9W6Jol 0LLiYH8P4gFr/+qCkcqQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vwz3d-0000000CYOb-32Pw; Mon, 02 Mar 2026 08:55:17 +0000 Received: from smtpout-03.galae.net ([185.246.85.4]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vwz3a-0000000CYNQ-0bmW for linux-riscv@lists.infradead.org; Mon, 02 Mar 2026 08:55:15 +0000 Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id C01CA4E424D9; Mon, 2 Mar 2026 08:55:10 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 8A7635FE89; Mon, 2 Mar 2026 08:55:10 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id A417410369514; Mon, 2 Mar 2026 09:55:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1772441709; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=GolTPQTz/JkLYWONicK1ZiOMxmW8WOdbYREGhj5V2VE=; b=JHGl83/EukVWIZ/SFdAWt9yhzJriahQdYX09JxyQMGmtBSCskhZN7xckRr17bc2Vw62UfB qcGKw/ehj38y6m8ranUWNvyq3NRat6jfinq37P9NycrZiU/fSo6zR+MAJiG9AhmJ7KC/l4 pBFI+KMgG5bhtUnvQCPWwENae2cpXhV2+vViIDxFpYE7xo882EU8nRvBOjJ0gdwpsXhLqI sRiEnHGjGE2s52NWpuK1u5OwsdRnqI2clKShjvkoUZcd+o/kBWHnQdvFWe0ePY9nwbq5ui iQ6Wugpy3aHWjvYrs8kRkNbHf2N86vXCFfVQ/+D6u5JeWKdfRBxrq2xPO8mA1Q== Date: Mon, 2 Mar 2026 09:55:01 +0100 From: Herve Codina To: Conor Dooley Cc: linux-gpio@vger.kernel.org, Conor Dooley , Thomas Gleixner , Daire McNamara , Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Linus Walleij , Bartosz Golaszewski , linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC v11 1/4] gpio: mpfs: Add interrupt support Message-ID: <20260302095501.3104146f@bootlin.com> In-Reply-To: <20260227-divinely-drift-93307c6763d8@spud> References: <20260227-ajar-wolverine-7ce1ebd79821@spud> <20260227-divinely-drift-93307c6763d8@spud> Organization: Bootlin X-Mailer: Claws Mail 4.3.1 (GTK 3.24.49; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-Last-TLS-Session-Version: TLSv1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260302_005514_320434_E1E56848 X-CRM114-Status: GOOD ( 14.90 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org SGkgQ29ub3IsCgpPbiBGcmksIDI3IEZlYiAyMDI2IDE0OjUyOjI3ICswMDAwCkNvbm9yIERvb2xl eSA8Y29ub3JAa2VybmVsLm9yZz4gd3JvdGU6Cgo+IEZyb206IENvbm9yIERvb2xleSA8Y29ub3Iu ZG9vbGV5QG1pY3JvY2hpcC5jb20+Cj4gCj4gQWRkIHN1cHBvcnQgZm9yIGludGVycnVwdHMgdG8g dGhlIFBvbGFyRmlyZSBTb0MgR1BJTyBkcml2ZXIuIEVhY2ggR1BJTwo+IGhhcyBhbiBpbmRlcGVu ZGVudCBpbnRlcnJ1cHQgdGhhdCBpcyB3aXJlZCB0byBhbiBpbnRlcnJ1cHQgbXV4IHRoYXQgc2l0 cwo+IGJldHdlZW4gdGhlIGNvbnRyb2xsZXJzIGFuZCB0aGUgUExJQy4gVGhlIFNvQyBoYXMgbW9y ZSBHUElPIGxpbmVzIHRoYW4KPiBjb25uZWN0aW9ucyBmcm9tIHRoZSBtdXggdG8gdGhlIFBMSUMs IHNvIHNvbWUgR1BJT3MgbXVzdCBzaGFyZSBQTElDCj4gaW50ZXJydXB0cy4gVGhlIGNvbmZpZ3Vy YXRpb24gaXMgbm90IHN0YXRpYyBhbmQgaXMgc2V0IGF0IHJ1bnRpbWUsCj4gY29udmVudGlvbmFs bHkgYnkgdGhlIHBsYXRmb3JtJ3MgZmlybXdhcmUuIENvcmVHUElPLCB0aGUgdmVyc2lvbgo+IGlu dGVuZGVkIGZvciB1c2UgaW4gdGhlIEZQR0EgZmFicmljIGhhcyB0d28gaW50ZXJydXB0IG91dHB1 dCBwb3J0cywgb25lCj4gaXMgSU9fTlVNIGJpdHMgd2lkZSwgYXMgaXMgdXNlZCBpbiB0aGUgaGFy ZGVuZWQgY29yZXMsIGFuZCB0aGUgb3RoZXIgaXMKPiBhIHNpbmdsZSBiaXQgd2l0aCBhbGwgbGlu ZXMgT1JlZCB0b2dldGhlci4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBDb25vciBEb29sZXkgPGNvbm9y LmRvb2xleUBtaWNyb2NoaXAuY29tPgo+IC0tLQo+IERvaW5nIHRoZSBjaGFpbmVkIHRoaW5nIGtp bmRhIGNvdmVycyBhbGwgdGhlIGJhc2VzIGF0IHRoZSBleHBlbnNlIG9mIHRoZQo+ICJkaXJlY3Qi IG1vZGUgaW50ZXJydXB0cyB0aGF0IGhhdmUgYSBkZWRpY2F0ZWQgY29ubmVjdGlvbiB0byB0aGUg UExJQy4KCgpTZWVtcyBvayBvbiBteSBzaWRlLgoKSnVzdCBhIG5pdHBpY2sgaW4gcHJvYmUoKS4K ClJldmlld2VkLWJ5OiBIZXJ2ZSBDb2RpbmEgPGhlcnZlLmNvZGluYUBib290bGluLmNvbT4KCi4u Lgo+ICBzdGF0aWMgaW50IG1wZnNfZ3Bpb19wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpw ZGV2KQo+ICB7Cj4gIAlzdHJ1Y3QgZGV2aWNlICpkZXYgPSAmcGRldi0+ZGV2Owo+ICsJc3RydWN0 IGRldmljZV9ub2RlICpub2RlID0gcGRldi0+ZGV2Lm9mX25vZGU7CgpkZXYtPm9mX25vZGUgaW5z dGVhZCBvZiBwZGV2LT5kZXYub2Zfbm9kZS4KCm9yIG1vdmUgJ3N0cnVjdCBkZXZpY2Vfbm9kZSAq bm9kZSA9IHBkZXYtPmRldi5vZl9ub2RlOycgYXQgZmlyc3QgcG9zaXRpb24KKHJldmVyc2UgWG1h cyB0cmVlKS4KCj4gIAlzdHJ1Y3QgbXBmc19ncGlvX2NoaXAgKm1wZnNfZ3BpbzsKPiArCXN0cnVj dCBncGlvX2lycV9jaGlwICpnaXJxOwoKQmVzdCByZWdhcmRzLApIZXJ2w6kKCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LXJpc2N2IG1haWxpbmcg bGlzdApsaW51eC1yaXNjdkBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRl YWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcmlzY3YK