From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC258322B6F for ; Mon, 2 Mar 2026 14:12:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772460731; cv=none; b=aBzT7tDDirdXO9taUWlf2g1AaLz2kKAQCrN76CHbIUONaxTp33PHgWqTvB2nGbpWuCLDBbxEvWxl4+6XfzGUMx2gwPEc3q+v1mYglPahYW6B9eiL9tEVIu8aVQk8aLslELoUO23Bl6S/VTo0noagEn6qbklc+x9r8nScHbyL2i4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772460731; c=relaxed/simple; bh=w2YDu5rMtbMMxT3t2H4bsBgwmSSKVHaJSN2ub4jHoRU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MjTBzLcPEk5HuDlZ7ekYRJ7/6Ou2aKdCnmqxiW4RGP2R1r8WCq8potHW/gL7Fg613B9024WFg9kaaqd+RWXmHtfjgNXe84SsvzDD+K/Ke3Bfemq7fTpXz9c9dZILZaDUDvl0OaeBsYAWN8EyN5Zm5oYUqB7oxUlCcyPkxzmGieA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id 97D8C68B05; Mon, 2 Mar 2026 15:12:06 +0100 (CET) Date: Mon, 2 Mar 2026 15:12:06 +0100 From: Christoph Hellwig To: John Garry Cc: hch@lst.de, kbusch@kernel.org, sagi@grimberg.me, axboe@fb.com, martin.petersen@oracle.com, james.bottomley@hansenpartnership.com, hare@suse.com, jmeneghi@redhat.com, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, michael.christie@oracle.com, snitzer@kernel.org, bmarzins@redhat.com, dm-devel@lists.linux.dev, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 00/19] nvme: switch to libmultipath Message-ID: <20260302141206.GA23439@lst.de> References: <20260225154007.1033735-1-john.g.garry@oracle.com> Precedence: bulk X-Mailing-List: dm-devel@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260225154007.1033735-1-john.g.garry@oracle.com> User-Agent: Mutt/1.5.17 (2007-11-01) On Wed, Feb 25, 2026 at 03:39:48PM +0000, John Garry wrote: > This switches the NVMe host driver to use libmultipath. That library > is very heavily based on the NVMe multipath code, so the change over > should hopefully be straightforward. There is often a direct replacement > for functions. Given how little code this removes while adding the new libmultipath dependency and abstractions I can't say I like this at all.