From: Jakub Kicinski <kuba@kernel.org>
To: Ovidiu Panait <ovidiu.panait.rb@renesas.com>
Cc: "andrew+netdev@lunn.ch" <andrew+netdev@lunn.ch>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"mcoquelin.stm32@gmail.com" <mcoquelin.stm32@gmail.com>,
"alexandre.torgue@foss.st.com" <alexandre.torgue@foss.st.com>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
"rmk+kernel@armlinux.org.uk" <rmk+kernel@armlinux.org.uk>,
"maxime.chevallier@bootlin.com" <maxime.chevallier@bootlin.com>,
"boon.khai.ng@altera.com" <boon.khai.ng@altera.com>,
"rohan.g.thomas@altera.com" <rohan.g.thomas@altera.com>,
"vladimir.oltean@nxp.com" <vladimir.oltean@nxp.com>,
"hayashi.kunihiko@socionext.com" <hayashi.kunihiko@socionext.com>,
"boon.leong.ong@intel.com" <boon.leong.ong@intel.com>,
"kim.tatt.chuah@intel.com" <kim.tatt.chuah@intel.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-stm32@st-md-mailman.stormreply.com"
<linux-stm32@st-md-mailman.stormreply.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v2 4/5] net: stmmac: Add write_hw parameter to VLAN filter operations
Date: Mon, 2 Mar 2026 16:08:58 -0800 [thread overview]
Message-ID: <20260302160858.2fe0fa3b@kernel.org> (raw)
In-Reply-To: <TY7P301MB1984067560FD51D7E2424CA2D37EA@TY7P301MB1984.JPNP301.PROD.OUTLOOK.COM>
On Mon, 2 Mar 2026 21:59:00 +0000 Ovidiu Panait wrote:
> > I wonder if instead of passing attributes like this around the driver
> > shouldn't simply maintain a flag (or have other way to test) whether
> > the clock to block X is currently enabled? It feels more like a global
> > state / property than trickiness directly related to VLAN config.
>
> I'll drop the write_hw logic and instead just check netif_running()
> directly, to avoid passing attributes around.
SG, tho - be careful with netif_running() in context of open / close
code paths.
next prev parent reply other threads:[~2026-03-03 0:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-25 14:24 [PATCH net-next v2 0/5] net: stmmac: Fix VLAN handling when interface is down Ovidiu Panait
2026-02-25 14:24 ` [PATCH net-next v2 1/5] net: stmmac: Fix error handling in VLAN add and delete paths Ovidiu Panait
2026-02-25 14:24 ` [PATCH net-next v2 2/5] net: stmmac: Improve double VLAN handling Ovidiu Panait
2026-02-25 14:24 ` [PATCH net-next v2 3/5] net: stmmac: Fix VLAN HW state restore Ovidiu Panait
2026-02-25 14:24 ` [PATCH net-next v2 4/5] net: stmmac: Add write_hw parameter to VLAN filter operations Ovidiu Panait
2026-02-28 19:04 ` Jakub Kicinski
2026-03-02 21:59 ` Ovidiu Panait
2026-03-03 0:08 ` Jakub Kicinski [this message]
2026-02-25 14:24 ` [PATCH net-next v2 5/5] net: stmmac: Defer VLAN HW configuration when interface is down Ovidiu Panait
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260302160858.2fe0fa3b@kernel.org \
--to=kuba@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=boon.khai.ng@altera.com \
--cc=boon.leong.ong@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hayashi.kunihiko@socionext.com \
--cc=kim.tatt.chuah@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=ovidiu.panait.rb@renesas.com \
--cc=pabeni@redhat.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=rohan.g.thomas@altera.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.