From: Jakub Kicinski <kuba@kernel.org>
To: Cedric Jehasse <cedric.jehasse@luminex.be>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"andrew@lunn.ch" <andrew@lunn.ch>,
"olteanv@gmail.com" <olteanv@gmail.com>,
"edumazet@google.com" <edumazet@google.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [net-next,v4] net: dsa: mv88e6xxx: Add partial support for TCAM entries
Date: Mon, 2 Mar 2026 16:13:21 -0800 [thread overview]
Message-ID: <20260302161321.03789236@kernel.org> (raw)
In-Reply-To: <PR3P194MB1505B5C902049D53057A41E8EA7EA@PR3P194MB1505.EURP194.PROD.OUTLOOK.COM>
On Mon, 2 Mar 2026 13:36:59 +0000 Cedric Jehasse wrote:
>> I see. But that sounds like a bug / silliness in the core that should
>> be fixed. AFAICT it's due to the fact that the fields are a union and
>> FL_KEY_SET_IF_MASKED() ends up interpreting either being set as both :/
>
> Changes to the core would have to be done in a different patch submission? What
> should be done with this patch, wait untill the core has been patched?
Both can we posted in the same patch series.
> There could be drivers unknowingly depend on the current implementation of
> having both bits always set.
Do your best to spot them, otherwise we'll fix them when someone
complains.
next prev parent reply other threads:[~2026-03-03 0:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-25 13:37 [PATCH net-next v4] net: dsa: mv88e6xxx: Add partial support for TCAM entries Cedric Jehasse
2026-02-25 13:37 ` Cedric Jehasse via B4 Relay
2026-02-27 3:55 ` [net-next,v4] " Jakub Kicinski
2026-02-27 9:44 ` Cedric Jehasse
2026-02-28 1:28 ` Jakub Kicinski
2026-03-02 13:36 ` Cedric Jehasse
2026-03-03 0:13 ` Jakub Kicinski [this message]
2026-02-27 14:06 ` Andrew Lunn
2026-02-27 23:55 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260302161321.03789236@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=cedric.jehasse@luminex.be \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.