From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 249743D3B3 for ; Tue, 3 Mar 2026 01:27:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=18.9.28.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772501267; cv=none; b=Eam/qw4QiXRz7g9ueOLrbLxhdu/zyWo+g5gr7241ByrFfdEQGOZGFJ353IjCs0XQoWvqU1oMIifwWhtwb6rv+5Roik5LQQPXgsIx5Of8yA11ikMUkAcAOKoqmvxAtOim+66ZaraZmcAKH0AbrlqQiwVdVpPPeQEskJLWhGmM/fQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772501267; c=relaxed/simple; bh=g+VdGlVLVkH1poZKLQaU9Z6Cz1tsg2GNZN6MfKpgxB4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=t6/W3lxVq7j9EdsSmDdJyFEMLyISreVrZbvBtXA7ueAod7P4vOUCyzjUmf749bwDvBXBxt+iOD+WJ5Smc82d2G1ZtK0/5e0mAxwZW3+9VzlGSW24wBSuYF/huvCRcHOivWHTUPXhgZ4f2fZLnF19MGZFDcFy1/NKYP/b08MQO24= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mit.edu; spf=pass smtp.mailfrom=mit.edu; dkim=pass (2048-bit key) header.d=mit.edu header.i=@mit.edu header.b=phzB0hIZ; arc=none smtp.client-ip=18.9.28.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mit.edu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mit.edu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mit.edu header.i=@mit.edu header.b="phzB0hIZ" Received: from macsyma.thunk.org (pool-173-48-102-84.bstnma.fios.verizon.net [173.48.102.84]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 6231PuA7026614 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 2 Mar 2026 20:25:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1772501166; bh=/4PzqDjQa596+Pxv5nyCAFN8lvFTxej9AhTZolOU+To=; h=Date:From:Subject:Message-ID:MIME-Version:Content-Type; b=phzB0hIZR1Dj1lfUpzFsTr+flPNVCYM7cGga6WrO7kke29j+oI7WqbalMFREnmiFa 39u6piOkvzSC+jx+skpc8xO8CzlmR1DGj4C5Alh9MmPU2lsvISyly3Iv5gOME95rCd MllEQsTefwUEgdwyTpmROazXEa7NbA5gdhjNhYqUrXL9BbLSWNcW3dyZTKAgvN+zey Zme2la752JOXjAcUBX4yGVlIoNtn+JrIRwXMG0WueOMoaTAHTCwKb+nnqitNheeRt0 EdkCyXgnFyu9pvoE+gS28f2nbWvS4IP+gBRVocTthk62P+MIa/5ig5W04hcezbkVA0 tLxNJsYr70ogA== Received: by macsyma.thunk.org (Postfix, from userid 15806) id 33A7D5AC5A1E; Mon, 2 Mar 2026 20:25:56 -0500 (EST) Date: Mon, 2 Mar 2026 20:25:56 -0500 From: "Theodore Tso" To: Jeff Layton Cc: Alexander Viro , Christian Brauner , Jan Kara , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Dan Williams , Matthew Wilcox , Eric Biggers , Muchun Song , Oscar Salvador , David Hildenbrand , David Howells , Paulo Alcantara , Andreas Dilger , Jan Kara , Jaegeuk Kim , Chao Yu , Trond Myklebust , Anna Schumaker , Chuck Lever , NeilBrown , Olga Kornievskaia , Dai Ngo , Tom Talpey , Steve French , Ronnie Sahlberg , Shyam Prasad N , Bharath SM , Alexander Aring , Ryusuke Konishi , Viacheslav Dubeyko , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Sterba , Marc Dionne , Ian Kent , Luis de Bethencourt , Salah Triki , "Tigran A. Aivazian" , Ilya Dryomov , Alex Markuze , Jan Harkes , coda@cs.cmu.edu, Nicolas Pitre , Tyler Hicks , Amir Goldstein , Christoph Hellwig , John Paul Adrian Glaubitz , Yangtao Li , Mikulas Patocka , David Woodhouse , Richard Weinberger , Dave Kleikamp , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , Mike Marshall , Martin Brandenburg , Miklos Szeredi , Anders Larsen , Zhihao Cheng , Damien Le Moal , Naohiro Aota , Johannes Thumshirn , John Johansen , Paul Moore , James Morris , "Serge E. Hallyn" , Mimi Zohar , Roberto Sassu , Dmitry Kasatkin , Eric Snowberg , Fan Wu , Stephen Smalley , Ondrej Mosnacek , Casey Schaufler , Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , David Airlie , Simona Vetter , Sumit Semwal , Eric Dumazet , Kuniyuki Iwashima , Paolo Abeni , Willem de Bruijn , "David S. Miller" , Jakub Kicinski , Simon Horman , Oleg Nesterov , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , James Clark , "Darrick J. Wong" , Martin Schiller , Eric Paris , Joerg Reuter , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Oliver Hartkopp , Marc Kleine-Budde , David Ahern , Neal Cardwell , Steffen Klassert , Herbert Xu , Remi Denis-Courmont , Marcelo Ricardo Leitner , Xin Long , Magnus Karlsson , Maciej Fijalkowski , Stanislav Fomichev , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, nvdimm@lists.linux.dev, fsverity@lists.linux.dev, linux-mm@kvack.org, netfs@lists.linux.dev, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-nilfs@vger.kernel.org, v9fs@lists.linux.dev, linux-afs@lists.infradead.org, autofs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@telemann.coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-mtd@lists.infradead.org, jfs-discussion@lists.sourceforge.net, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, devel@lists.orangefs.org, linux-unionfs@vger.kernel.org, apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org, linux-integrity@vger.kernel.org, selinux@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org, netdev@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-fscrypt@vger.kernel.org, linux-xfs@vger.kernel.org, linux-hams@vger.kernel.org, linux-x25@vger.kernel.org, audit@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-can@vger.kernel.org, linux-sctp@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH v2 001/110] vfs: introduce kino_t typedef and PRIino format macro Message-ID: <20260303012556.GA6520@macsyma-wired.lan> References: <20260302-iino-u64-v2-0-e5388800dae0@kernel.org> <20260302-iino-u64-v2-1-e5388800dae0@kernel.org> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260302-iino-u64-v2-1-e5388800dae0@kernel.org> On Mon, Mar 02, 2026 at 03:23:45PM -0500, Jeff Layton wrote: > The PRIino macro is a length modifier, not a complete format specifier. > It is used as: "%" PRIino "u" for decimal, "%" PRIino "x" for hex, etc. > This follows the pattern used by userspace PRIu64/PRIx64 macros. For the record, I really hate the inttypes.h format specifiers, but I agree that we should forward the example of the C99 spec, for better or for worse. That being said, the userspace PRIu64, et. al macros are complete format specifiers, not just a length modifier. And I think this results in less ugly format specifiers in our kernel code. ---- cut here --- #!/bin/sh cat < /tmp/blah.c #include #include int main(int arg, char **argv) { printf("PRIu64 is %s\n", PRIu64); printf("PRId64 is %s\n", PRId64); printf("PRIx64 is %s\n", PRIx64); return 0; } EOF clang -m32 -o /tmp/blah /tmp/blah.c /tmp/blah ---- cut here --- % /tmp/blah.sh PRIu64 is llu PRId64 is lld PRIx64 is llx Thanks! - Ted From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D2DE9EB364A for ; Tue, 3 Mar 2026 01:26:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:In-Reply-To:MIME-Version:References:Message-ID:To:From:Date:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ixkqr3IxsBVAYLrlmcgXx9o/SCL/CUOag/5SYnXxlfE=; b=E7U444M62eQ80/+sqI1DAEvSz+ k+Mg8yxT6y0lf2JchO4alqdmIFoK5bBE6CTv1+/ZZIE1Y70mDLWoFeRbNoIrf/+p2i5m+X3TBpxY9 f6EH+1BhzlRopLc9J4OsGLDPKJgvFOV9X8voVbnjdQI8XybhgHMHpTpOCJeRh3HKzg8M=; Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1vxEWy-0001hG-Ty; Tue, 03 Mar 2026 01:26:36 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1vxEWx-0001h9-Nl for linux-f2fs-devel@lists.sourceforge.net; Tue, 03 Mar 2026 01:26:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=/4PzqDjQa596+Pxv5nyCAFN8lvFTxej9AhTZolOU+To=; b=FQ5kBsvyf8eepDSDGEzWZMJCrJ V6EY+vYenQlKbNz8uv8SBMYKoJfA6BLObS41k/TX8hwUc7QdQ4R1Q+msPbPaN4ISpS/kjtM/bq5pc mZYttJC4iMPOiryHkogHTn1k33OrduuVGJ9OlYVoX8XZOeN2QN4XQvCxdTU0X218nI8Y=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=/4PzqDjQa596+Pxv5nyCAFN8lvFTxej9AhTZolOU+To=; b=ecLlswltvo5JiGRbCppeUWOXRd NRUIQ6gnjs9uDQKg9KLht0UcInqt2VxnR+XSvgBFQW8sow6xU7wsy6ofueH7ret3yEGOQ4gjf4YX3 jHBNWC3N0KGAz0uwScCdLqssZ5lNfqB/jK4HkEYK+HAVgz8vc9U25owCR45iz/rzRvDs=; Received: from outgoing-auth-1.mit.edu ([18.9.28.11] helo=outgoing.mit.edu) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1vxEWx-0008Us-4U for linux-f2fs-devel@lists.sourceforge.net; Tue, 03 Mar 2026 01:26:35 +0000 Received: from macsyma.thunk.org (pool-173-48-102-84.bstnma.fios.verizon.net [173.48.102.84]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 6231PuA7026614 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 2 Mar 2026 20:25:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1772501166; bh=/4PzqDjQa596+Pxv5nyCAFN8lvFTxej9AhTZolOU+To=; h=Date:From:Subject:Message-ID:MIME-Version:Content-Type; b=phzB0hIZR1Dj1lfUpzFsTr+flPNVCYM7cGga6WrO7kke29j+oI7WqbalMFREnmiFa 39u6piOkvzSC+jx+skpc8xO8CzlmR1DGj4C5Alh9MmPU2lsvISyly3Iv5gOME95rCd MllEQsTefwUEgdwyTpmROazXEa7NbA5gdhjNhYqUrXL9BbLSWNcW3dyZTKAgvN+zey Zme2la752JOXjAcUBX4yGVlIoNtn+JrIRwXMG0WueOMoaTAHTCwKb+nnqitNheeRt0 EdkCyXgnFyu9pvoE+gS28f2nbWvS4IP+gBRVocTthk62P+MIa/5ig5W04hcezbkVA0 tLxNJsYr70ogA== Received: by macsyma.thunk.org (Postfix, from userid 15806) id 33A7D5AC5A1E; Mon, 2 Mar 2026 20:25:56 -0500 (EST) Date: Mon, 2 Mar 2026 20:25:56 -0500 From: "Theodore Tso" To: Jeff Layton Message-ID: <20260303012556.GA6520@macsyma-wired.lan> References: <20260302-iino-u64-v2-0-e5388800dae0@kernel.org> <20260302-iino-u64-v2-1-e5388800dae0@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260302-iino-u64-v2-1-e5388800dae0@kernel.org> X-Headers-End: 1vxEWx-0008Us-4U Subject: Re: [f2fs-dev] [PATCH v2 001/110] vfs: introduce kino_t typedef and PRIino format macro X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Latchesar Ionkov , nvdimm@lists.linux.dev, Paulo Alcantara , "Darrick J. Wong" , Anders Larsen , dri-devel@lists.freedesktop.org, linux-sctp@vger.kernel.org, linux-hams@vger.kernel.org, Sumit Semwal , Mike Marshall , linux-xfs@vger.kernel.org, Fan Wu , Xin Long , ceph-devel@vger.kernel.org, James Morris , Tyler Hicks , Christoph Hellwig , devel@lists.orangefs.org, Shyam Prasad N , Martin Schiller , Jesper Dangaard Brouer , Jan Harkes , Willem de Bruijn , Arnaldo Carvalho de Melo , linux-fscrypt@vger.kernel.org, Alexander Viro , Ronnie Sahlberg , John Paul Adrian Glaubitz , David Hildenbrand , Eric Van Hensbergen , Magnus Karlsson , Christian Brauner , Dmitry Kasatkin , Stephen Smalley , linux-kernel@vger.kernel.org, Eric Paris , linux-perf-users@vger.kernel.org, Chuck Lever , Masami Hiramatsu , Jiri Olsa , Jan Kara , Alex Deucher , linux-media@vger.kernel.org, Trond Myklebust , Mark Rutland , Dave Kleikamp , Mimi Zohar , Oleg Nesterov , Eric Dumazet , Johan Hedberg , Simona Vetter , linux-cifs@vger.kernel.org, Kuniyuki Iwashima , linux-nilfs@vger.kernel.org, Paul Moore , John Fastabend , Remi Denis-Courmont , linux-trace-kernel@vger.kernel.org, Olga Kornievskaia , Maciej Fijalkowski , Yangtao Li , selinux@vger.kernel.org, v9fs@lists.linux.dev, linux-can@vger.kernel.org, linaro-mm-sig@lists.linaro.org, Casey Schaufler , netfs@lists.linux.dev, Jaegeuk Kim , fsverity@lists.linux.dev, Nicolas Pitre , Muchun Song , Roberto Sassu , "David S. Miller" , Anna Schumaker , linux-integrity@vger.kernel.org, Marcelo Ricardo Leitner , Luiz Augusto von Dentz , Alex Markuze , Martin Brandenburg , Alexander Shishkin , ocfs2-devel@lists.linux.dev, Alexei Starovoitov , linux-mtd@lists.infradead.org, amd-gfx@lists.freedesktop.org, Marc Dionne , Neal Cardwell , linux-afs@lists.infradead.org, Ian Kent , Naohiro Aota , Eric Biggers , Daniel Borkmann , Miklos Szeredi , Matthew Wilcox , coda@cs.cmu.edu, Stanislav Fomichev , Viacheslav Dubeyko , NeilBrown , Ilya Dryomov , Paolo Abeni , jfs-discussion@lists.sourceforge.net, "Serge E. Hallyn" , Amir Goldstein , James Clark , autofs@vger.kernel.org, Steven Rostedt , Damien Le Moal , Mathieu Desnoyers , Dan Williams , Oscar Salvador , Konstantin Komarov , linux-nfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-mm@kvack.org, samba-technical@lists.samba.org, Ondrej Mosnacek , Steve French , netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org, bpf@vger.kernel.org, ntfs3@lists.linux.dev, Christian =?iso-8859-1?Q?K=F6nig?= , Ian Rogers , Alexander Aring , Jan Kara , Peter Zijlstra , Dominique Martinet , Christian Schoenebeck , ecryptfs@vger.kernel.org, linux-unionfs@vger.kernel.org, David Howells , Joseph Qi , Andreas Dilger , Mikulas Patocka , linux-f2fs-devel@lists.sourceforge.net, David Airlie , Steffen Klassert , Eric Snowberg , Herbert Xu , linux-x25@vger.kernel.org, linux-bluetooth@vger.kernel.org, Richard Weinberger , Mark Fasheh , Dai Ngo , Ingo Molnar , Jakub Kicinski , Salah Triki , Marcel Holtmann , Joerg Reuter , codalist@telemann.coda.cs.cmu.edu, Simon Horman , apparmor@lists.ubuntu.com, Tom Talpey , Bharath SM , Marc Kleine-Budde , "Tigran A. Aivazian" , David Sterba , Namhyung Kim , Ryusuke Konishi , John Johansen , Luis de Bethencourt , Oliver Hartkopp , David Ahern , Adrian Hunter , audit@vger.kernel.org, linux-security-module@vger.kernel.org, Johannes Thumshirn , David Woodhouse , Joel Becker Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Mon, Mar 02, 2026 at 03:23:45PM -0500, Jeff Layton wrote: > The PRIino macro is a length modifier, not a complete format specifier. > It is used as: "%" PRIino "u" for decimal, "%" PRIino "x" for hex, etc. > This follows the pattern used by userspace PRIu64/PRIx64 macros. For the record, I really hate the inttypes.h format specifiers, but I agree that we should forward the example of the C99 spec, for better or for worse. That being said, the userspace PRIu64, et. al macros are complete format specifiers, not just a length modifier. And I think this results in less ugly format specifiers in our kernel code. ---- cut here --- #!/bin/sh cat < /tmp/blah.c #include #include int main(int arg, char **argv) { printf("PRIu64 is %s\n", PRIu64); printf("PRId64 is %s\n", PRId64); printf("PRIx64 is %s\n", PRIx64); return 0; } EOF clang -m32 -o /tmp/blah /tmp/blah.c /tmp/blah ---- cut here --- % /tmp/blah.sh PRIu64 is llu PRId64 is lld PRIx64 is llx Thanks! - Ted _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F208CEB3648 for ; Tue, 3 Mar 2026 01:28:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QpKkfYCN1AoMuaP9BMeV4jwOqrcxhubDr8HhhzuhdzU=; b=i/aIoedxcCBgw6 yfrgRpAKRj2GNsjy/dPt+aKqTlRHQIDjXesjoiaSKsOFHFW0OQvbJr3oEU1aDejrCIy5YMwqW748A KjNK9dtsCLV91OsCNVpF71Vu4Cwseh+iOjNvHbUR0mZNsRgF6M5iwWnRGO3cf6HBVQ/yY7PkGhpc4 D0wwGs8N884hSDw6CGH6whdeg4wjFwj+xoTvCRRYaWwtRH4lw3yHP0ry1y2PNbRr4arvUOoWxqQBK PDrW38E0U2xLYk8qn+eKRYZW/zc6CiEbrhPYJHqebLHusKHD/EYIprZy+OdlQOdnuaLqT9awhZ5Ot UP+wHcGn+0eFY9wiWjTA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vxEYW-0000000ELK4-0V6E; Tue, 03 Mar 2026 01:28:12 +0000 Received: from outgoing-auth-1.mit.edu ([18.9.28.11] helo=outgoing.mit.edu) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vxEYT-0000000ELJG-1PVf for linux-mtd@lists.infradead.org; Tue, 03 Mar 2026 01:28:10 +0000 Received: from macsyma.thunk.org (pool-173-48-102-84.bstnma.fios.verizon.net [173.48.102.84]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 6231PuHh026611 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 2 Mar 2026 20:25:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1772501165; bh=/4PzqDjQa596+Pxv5nyCAFN8lvFTxej9AhTZolOU+To=; h=Date:From:Subject:Message-ID:MIME-Version:Content-Type; b=Ev6ld9VELfSTilMsdvuAuUcsoGxAWkhkYbGJgxub8uYi6JxNzIKpWtMLYSH65Q11a LTgb4BMMz6Ut329yS0fdzL3wx8BHwrzl2QmBbUi2AkAdU/lHnsfaIHc/p6xNdd+Wna Kr3z8miEjeR4glowkQniiW1V7ISWUhY5fmWVfihMm5VxA6SkKeku6+zbP1T9VwFBKQ /5tsaXToc7QUEPpds9mL/NiU4uDpJ5GlCTl+veDU984lE468Lsiu54ib1lO8WnZhtt A57VlXyYuMZkd5JTeNCMIbfzi9Fgy5IJlNHQH8JAeRIzB3rUV81721ZRGH+7y7rqyi u4HI27iqLCxeA== Received: by macsyma.thunk.org (Postfix, from userid 15806) id 33A7D5AC5A1E; Mon, 2 Mar 2026 20:25:56 -0500 (EST) Date: Mon, 2 Mar 2026 20:25:56 -0500 From: "Theodore Tso" To: Jeff Layton Cc: Alexander Viro , Christian Brauner , Jan Kara , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Dan Williams , Matthew Wilcox , Eric Biggers , Muchun Song , Oscar Salvador , David Hildenbrand , David Howells , Paulo Alcantara , Andreas Dilger , Jan Kara , Jaegeuk Kim , Chao Yu , Trond Myklebust , Anna Schumaker , Chuck Lever , NeilBrown , Olga Kornievskaia , Dai Ngo , Tom Talpey , Steve French , Ronnie Sahlberg , Shyam Prasad N , Bharath SM , Alexander Aring , Ryusuke Konishi , Viacheslav Dubeyko , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Sterba , Marc Dionne , Ian Kent , Luis de Bethencourt , Salah Triki , "Tigran A. Aivazian" , Ilya Dryomov , Alex Markuze , Jan Harkes , coda@cs.cmu.edu, Nicolas Pitre , Tyler Hicks , Amir Goldstein , Christoph Hellwig , John Paul Adrian Glaubitz , Yangtao Li , Mikulas Patocka , David Woodhouse , Richard Weinberger , Dave Kleikamp , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , Mike Marshall , Martin Brandenburg , Miklos Szeredi , Anders Larsen , Zhihao Cheng , Damien Le Moal , Naohiro Aota , Johannes Thumshirn , John Johansen , Paul Moore , James Morris , "Serge E. Hallyn" , Mimi Zohar , Roberto Sassu , Dmitry Kasatkin , Eric Snowberg , Fan Wu , Stephen Smalley , Ondrej Mosnacek , Casey Schaufler , Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , David Airlie , Simona Vetter , Sumit Semwal , Eric Dumazet , Kuniyuki Iwashima , Paolo Abeni , Willem de Bruijn , "David S. Miller" , Jakub Kicinski , Simon Horman , Oleg Nesterov , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , James Clark , "Darrick J. Wong" , Martin Schiller , Eric Paris , Joerg Reuter , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Oliver Hartkopp , Marc Kleine-Budde , David Ahern , Neal Cardwell , Steffen Klassert , Herbert Xu , Remi Denis-Courmont , Marcelo Ricardo Leitner , Xin Long , Magnus Karlsson , Maciej Fijalkowski , Stanislav Fomichev , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, nvdimm@lists.linux.dev, fsverity@lists.linux.dev, linux-mm@kvack.org, netfs@lists.linux.dev, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-nilfs@vger.kernel.org, v9fs@lists.linux.dev, linux-afs@lists.infradead.org, autofs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@telemann.coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-mtd@lists.infradead.org, jfs-discussion@lists.sourceforge.net, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, devel@lists.orangefs.org, linux-unionfs@vger.kernel.org, apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org, linux-integrity@vger.kernel.org, selinux@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org, netdev@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-fscrypt@vger.kernel.org, linux-xfs@vger.kernel.org, linux-hams@vger.kernel.org, linux-x25@vger.kernel.org, audit@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-can@vger.kernel.org, linux-sctp@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH v2 001/110] vfs: introduce kino_t typedef and PRIino format macro Message-ID: <20260303012556.GA6520@macsyma-wired.lan> References: <20260302-iino-u64-v2-0-e5388800dae0@kernel.org> <20260302-iino-u64-v2-1-e5388800dae0@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260302-iino-u64-v2-1-e5388800dae0@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260302_172809_530068_01FAEE3D X-CRM114-Status: GOOD ( 15.22 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Mon, Mar 02, 2026 at 03:23:45PM -0500, Jeff Layton wrote: > The PRIino macro is a length modifier, not a complete format specifier. > It is used as: "%" PRIino "u" for decimal, "%" PRIino "x" for hex, etc. > This follows the pattern used by userspace PRIu64/PRIx64 macros. For the record, I really hate the inttypes.h format specifiers, but I agree that we should forward the example of the C99 spec, for better or for worse. That being said, the userspace PRIu64, et. al macros are complete format specifiers, not just a length modifier. And I think this results in less ugly format specifiers in our kernel code. ---- cut here --- #!/bin/sh cat < /tmp/blah.c #include #include int main(int arg, char **argv) { printf("PRIu64 is %s\n", PRIu64); printf("PRId64 is %s\n", PRId64); printf("PRIx64 is %s\n", PRIx64); return 0; } EOF clang -m32 -o /tmp/blah /tmp/blah.c /tmp/blah ---- cut here --- % /tmp/blah.sh PRIu64 is llu PRId64 is lld PRIx64 is llx Thanks! - Ted ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/