From: Jamin Lin <jamin_lin@aspeedtech.com>
To: "clg@kaod.org" <clg@kaod.org>,
"jithu.joseph@oss.qualcomm.com" <jithu.joseph@oss.qualcomm.com>,
"open list:All patches CC here" <qemu-devel@nongnu.org>
Cc: Jamin Lin <jamin_lin@aspeedtech.com>,
Troy Lee <troy_lee@aspeedtech.com>,
Kane Chen <kane_chen@aspeedtech.com>,
"nabihestefan@google.com" <nabihestefan@google.com>,
"komlodi@google.com" <komlodi@google.com>
Subject: [PATCH v2 2/4] hw/i3c/mock-i3c-target: Set num_sent in TX callback to fix trace reporting
Date: Tue, 3 Mar 2026 01:33:26 +0000 [thread overview]
Message-ID: <20260303013322.1297499-3-jamin_lin@aspeedtech.com> (raw)
In-Reply-To: <20260303013322.1297499-1-jamin_lin@aspeedtech.com>
mock_i3c_target_tx() did not update *num_sent before returning.
Although some callers may not directly use this value, i3c_send()
passes num_sent to trace_i3c_send(). If the target TX callback does
not initialize *num_sent, the trace output may report an incorrect
or uninitialized value, leading to confusing debugging information.
For example, the following trace was observed:
mock_i3c_target_tx I3C mock target write 0x12
i3c_send I3C send 0/1 bytes, ack=1 (expected 1/1 bytes)
This happens because *num_sent was never set by the TX callback.
Fix this by setting *num_sent in all return paths,
including the IBI magic handling case, to accurately reflect
the number of bytes consumed.
Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
---
hw/i3c/mock-i3c-target.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/i3c/mock-i3c-target.c b/hw/i3c/mock-i3c-target.c
index 875cd7c7d0..b99709a08b 100644
--- a/hw/i3c/mock-i3c-target.c
+++ b/hw/i3c/mock-i3c-target.c
@@ -70,6 +70,7 @@ static int mock_i3c_target_tx(I3CTarget *i3c, const uint8_t *data,
if (s->cfg.ibi_magic && num_to_send == 1 && s->cfg.ibi_magic == *data) {
mock_i3c_target_ibi_timer_start(s);
+ *num_sent = 1;
return 0;
}
@@ -86,6 +87,7 @@ static int mock_i3c_target_tx(I3CTarget *i3c, const uint8_t *data,
s->buf[s->p_buf] = data[i];
s->p_buf++;
}
+ *num_sent = to_write;
return ret;
}
--
2.43.0
next prev parent reply other threads:[~2026-03-03 1:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-03 1:33 [PATCH v2 0/4] hw/i3c: Trace fixes and readability improvements from review feedback Jamin Lin
2026-03-03 1:33 ` [PATCH v2 1/4] hw/i3c/dw-i3c: Use ROUND_UP() for RX buffer allocation alignment Jamin Lin
2026-03-03 1:33 ` Jamin Lin [this message]
2026-03-03 1:37 ` [PATCH v2 2/4] hw/i3c/mock-i3c-target: Set num_sent in TX callback to fix trace reporting Jithu Joseph
2026-03-03 1:33 ` [PATCH v2 3/4] hw/i3c/core: Initialize num_sent in i3c_send_byte() Jamin Lin
2026-03-03 1:33 ` [PATCH v2 4/4] hw/i3c/mock-i3c-target: Simplify GETMRL byte extraction logic Jamin Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260303013322.1297499-3-jamin_lin@aspeedtech.com \
--to=jamin_lin@aspeedtech.com \
--cc=clg@kaod.org \
--cc=jithu.joseph@oss.qualcomm.com \
--cc=kane_chen@aspeedtech.com \
--cc=komlodi@google.com \
--cc=nabihestefan@google.com \
--cc=qemu-devel@nongnu.org \
--cc=troy_lee@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.