From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A669520A5C4; Tue, 3 Mar 2026 04:25:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772511947; cv=none; b=GPcG6PhNkCkpbY+2r+EUc0EOQ3FaCEMOr1cYfOyLLIzW+KVUSIzpdn+Rh9xtLhkQOuvDFQL8o0sEEzMuOyZvg2n/P8avW7gxVHG+ubLuSDU31J4EYZmSCGxIzXv8rfLd0E+yRaTYkMhz49MLg+RgnS2ATMP3ycwhhvqgCE9RSYU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772511947; c=relaxed/simple; bh=YZ/dFxr/gaxWgfEt0nAZiUh8L3hzuSp8PgioG8bdfOI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Sxm1OEmSD5TkLnoFufnPA9S8l8AXZMxBt9i8U7AigmYzo0E9se5HroODTdkbP/Gvm2mgFrT8ISJUZWYs3gQKb2ouzMreTtTaPB0lZ30hLyZ7n6n59+9Sy8e7RMlTs2nt4unqaar6uaE8DD8rETU9NyEHhnLuD2nD+PeTVpn3/7E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=VVZLSXMX; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="VVZLSXMX" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1F1C2C116C6; Tue, 3 Mar 2026 04:25:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772511947; bh=YZ/dFxr/gaxWgfEt0nAZiUh8L3hzuSp8PgioG8bdfOI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VVZLSXMX/ADYwgzUdgl96oTTyoWKtSsqBFyZjRHPhr3+Le570J67X1VARch7tnhrc jLMxK9WyIuv5g2RTTf67P6eMJopf19ZEik5sLXK6jqbxU64ctIOV1XX4j6Kn+Q33Nu yQYGo2cQykg/FleyBJM4gSOzSojW07vqpkIpYgN8n19BYunsJ2Ud2G/HmvpxbPcrq4 pzDmiTteXofRQDx0O66dq6F/dhJKF3yUgl8c6/qCtRRe/JhIVvnMyTg8YHSGrA3GHZ /1eA+v+KmU3ne6r8EbcoV1FFXQPxOQNpH/iFU+LVJ9yxO/ol1CYuEdDyLwooDdAzOZ srZwZE76Q+8tw== Date: Mon, 2 Mar 2026 20:25:46 -0800 From: "Darrick J. Wong" To: Theodore Tso Cc: Jeff Layton , Alexander Viro , Christian Brauner , Jan Kara , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Dan Williams , Matthew Wilcox , Eric Biggers , Muchun Song , Oscar Salvador , David Hildenbrand , David Howells , Paulo Alcantara , Andreas Dilger , Jan Kara , Jaegeuk Kim , Chao Yu , Trond Myklebust , Anna Schumaker , Chuck Lever , NeilBrown , Olga Kornievskaia , Dai Ngo , Tom Talpey , Steve French , Ronnie Sahlberg , Shyam Prasad N , Bharath SM , Alexander Aring , Ryusuke Konishi , Viacheslav Dubeyko , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Sterba , Marc Dionne , Ian Kent , Luis de Bethencourt , Salah Triki , "Tigran A. Aivazian" , Ilya Dryomov , Alex Markuze , Jan Harkes , coda@cs.cmu.edu, Nicolas Pitre , Tyler Hicks , Amir Goldstein , Christoph Hellwig , John Paul Adrian Glaubitz , Yangtao Li , Mikulas Patocka , David Woodhouse , Richard Weinberger , Dave Kleikamp , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , Mike Marshall , Martin Brandenburg , Miklos Szeredi , Anders Larsen , Zhihao Cheng , Damien Le Moal , Naohiro Aota , Johannes Thumshirn , John Johansen , Paul Moore , James Morris , "Serge E. Hallyn" , Mimi Zohar , Roberto Sassu , Dmitry Kasatkin , Eric Snowberg , Fan Wu , Stephen Smalley , Ondrej Mosnacek , Casey Schaufler , Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , David Airlie , Simona Vetter , Sumit Semwal , Eric Dumazet , Kuniyuki Iwashima , Paolo Abeni , Willem de Bruijn , "David S. Miller" , Jakub Kicinski , Simon Horman , Oleg Nesterov , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , James Clark , Martin Schiller , Eric Paris , Joerg Reuter , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Oliver Hartkopp , Marc Kleine-Budde , David Ahern , Neal Cardwell , Steffen Klassert , Herbert Xu , Remi Denis-Courmont , Marcelo Ricardo Leitner , Xin Long , Magnus Karlsson , Maciej Fijalkowski , Stanislav Fomichev , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, nvdimm@lists.linux.dev, fsverity@lists.linux.dev, linux-mm@kvack.org, netfs@lists.linux.dev, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-nilfs@vger.kernel.org, v9fs@lists.linux.dev, linux-afs@lists.infradead.org, autofs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@telemann.coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-mtd@lists.infradead.org, jfs-discussion@lists.sourceforge.net, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, devel@lists.orangefs.org, linux-unionfs@vger.kernel.org, apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org, linux-integrity@vger.kernel.org, selinux@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org, netdev@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-fscrypt@vger.kernel.org, linux-xfs@vger.kernel.org, linux-hams@vger.kernel.org, linux-x25@vger.kernel.org, audit@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-can@vger.kernel.org, linux-sctp@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH v2 001/110] vfs: introduce kino_t typedef and PRIino format macro Message-ID: <20260303042546.GF13868@frogsfrogsfrogs> References: <20260302-iino-u64-v2-0-e5388800dae0@kernel.org> <20260302-iino-u64-v2-1-e5388800dae0@kernel.org> <20260303012556.GA6520@macsyma-wired.lan> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260303012556.GA6520@macsyma-wired.lan> On Mon, Mar 02, 2026 at 08:25:56PM -0500, Theodore Tso wrote: > On Mon, Mar 02, 2026 at 03:23:45PM -0500, Jeff Layton wrote: > > The PRIino macro is a length modifier, not a complete format specifier. > > It is used as: "%" PRIino "u" for decimal, "%" PRIino "x" for hex, etc. > > This follows the pattern used by userspace PRIu64/PRIx64 macros. > > For the record, I really hate the inttypes.h format specifiers, but I > agree that we should forward the example of the C99 spec, for better > or for worse. > > That being said, the userspace PRIu64, et. al macros are complete > format specifiers, not just a length modifier. And I think this > results in less ugly format specifiers in our kernel code. Yeah, I don't like "ino=%" PRIino "u, lolz\n" either. I'd rather have the whole format in the PRIino definition -- it /is/ unsigned long after all. --D > ---- cut here --- > #!/bin/sh > cat < /tmp/blah.c > #include > #include > > int main(int arg, char **argv) > { > printf("PRIu64 is %s\n", PRIu64); > printf("PRId64 is %s\n", PRId64); > printf("PRIx64 is %s\n", PRIx64); > return 0; > } > EOF > > clang -m32 -o /tmp/blah /tmp/blah.c > /tmp/blah > ---- cut here --- > > % /tmp/blah.sh > PRIu64 is llu > PRId64 is lld > PRIx64 is llx > > Thanks! > > - Ted From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 27492E67A63 for ; Tue, 3 Mar 2026 04:26:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: Reply-To:From:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:In-Reply-To:MIME-Version:References: Message-ID:To:Date:Sender:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1/ouL2aeBqTWOUbzFj5JD6f4RNVNhgrV0u8ip3ZU43s=; b=ZRNpSVNU1F5SE7kehi1TD1flei 0gpko/HbNw2GdjuW2GIM0nEXQ5AHz44ytv2DpFyup+uY4Y9yTd44E+BspgfD/EbEt4bty85hmyCFQ aeq3o+2yPm+JfmGXJDHcSR9KDln5mrZXvHS7IEqTQ2CGGSBU63B/FPL5gai3uoQ00ggA=; Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1vxHKa-0005yb-7f; Tue, 03 Mar 2026 04:26:00 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1vxHKY-0005yL-L5; Tue, 03 Mar 2026 04:25:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=EYD+hTYlE85k0B0NWyNfG2ixst88h/xUOUA+vKpk9xg=; b=Zp1V6GRZaTKeqlfldyhUARF77C DSyXi0TwMBXCbl4+5xIr6mV6U3oUWDWIhoIlK1I4e4jQCC8cPRNg2owM4JRUnbgIcj9bYepQ9yRUh EuTueelq1xR5o7zF2mEvHnSGUWCTQnaQBXBlEQXlcL3dKrZOA+mal+FT7F95Sa3p1w/8=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=EYD+hTYlE85k0B0NWyNfG2ixst88h/xUOUA+vKpk9xg=; b=hMqLIhK7k5g0tgUhtqxc1imiSM cOFVXoa22qLKVCj/3obt+cpfkZg6kAU0rZikpVzsKJosBOM5uE8vVe1xFEZ8ICVtowCqYU97/PQJS wuw9c0XllI2Duwhmhp9FQcrKczsQJFQRhd9obwKwvG+M5Gs2QwZRgR19fXwCB/QpQBkE=; Received: from sea.source.kernel.org ([172.234.252.31]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1vxHKY-0008Lu-6M; Tue, 03 Mar 2026 04:25:58 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 7099041750; Tue, 3 Mar 2026 04:25:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1F1C2C116C6; Tue, 3 Mar 2026 04:25:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772511947; bh=YZ/dFxr/gaxWgfEt0nAZiUh8L3hzuSp8PgioG8bdfOI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VVZLSXMX/ADYwgzUdgl96oTTyoWKtSsqBFyZjRHPhr3+Le570J67X1VARch7tnhrc jLMxK9WyIuv5g2RTTf67P6eMJopf19ZEik5sLXK6jqbxU64ctIOV1XX4j6Kn+Q33Nu yQYGo2cQykg/FleyBJM4gSOzSojW07vqpkIpYgN8n19BYunsJ2Ud2G/HmvpxbPcrq4 pzDmiTteXofRQDx0O66dq6F/dhJKF3yUgl8c6/qCtRRe/JhIVvnMyTg8YHSGrA3GHZ /1eA+v+KmU3ne6r8EbcoV1FFXQPxOQNpH/iFU+LVJ9yxO/ol1CYuEdDyLwooDdAzOZ srZwZE76Q+8tw== Date: Mon, 2 Mar 2026 20:25:46 -0800 To: Theodore Tso Message-ID: <20260303042546.GF13868@frogsfrogsfrogs> References: <20260302-iino-u64-v2-0-e5388800dae0@kernel.org> <20260302-iino-u64-v2-1-e5388800dae0@kernel.org> <20260303012556.GA6520@macsyma-wired.lan> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260303012556.GA6520@macsyma-wired.lan> X-Headers-End: 1vxHKY-0008Lu-6M Subject: Re: [f2fs-dev] [PATCH v2 001/110] vfs: introduce kino_t typedef and PRIino format macro X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: "Darrick J. Wong via Linux-f2fs-devel" Reply-To: "Darrick J. Wong" Cc: Latchesar Ionkov , nvdimm@lists.linux.dev, Paulo Alcantara , Anders Larsen , dri-devel@lists.freedesktop.org, linux-sctp@vger.kernel.org, linux-hams@vger.kernel.org, Sumit Semwal , Mike Marshall , linux-xfs@vger.kernel.org, Fan Wu , Xin Long , ceph-devel@vger.kernel.org, James Morris , Tyler Hicks , Christoph Hellwig , devel@lists.orangefs.org, Shyam Prasad N , Martin Schiller , Jesper Dangaard Brouer , Jan Harkes , Willem de Bruijn , Arnaldo Carvalho de Melo , linux-fscrypt@vger.kernel.org, Alexander Viro , Ronnie Sahlberg , John Paul Adrian Glaubitz , David Hildenbrand , Eric Van Hensbergen , Magnus Karlsson , Christian Brauner , Dmitry Kasatkin , Stephen Smalley , linux-kernel@vger.kernel.org, Eric Paris , linux-perf-users@vger.kernel.org, Chuck Lever , Masami Hiramatsu , Jiri Olsa , Jan Kara , Alex Deucher , linux-media@vger.kernel.org, Trond Myklebust , Mark Rutland , Dave Kleikamp , samba-technical@lists.samba.org, Mimi Zohar , Oleg Nesterov , Eric Dumazet , Johan Hedberg , Simona Vetter , linux-cifs@vger.kernel.org, Kuniyuki Iwashima , linux-nilfs@vger.kernel.org, Paul Moore , John Fastabend , Remi Denis-Courmont , linux-trace-kernel@vger.kernel.org, Olga Kornievskaia , Maciej Fijalkowski , Yangtao Li , selinux@vger.kernel.org, v9fs@lists.linux.dev, linux-can@vger.kernel.org, linaro-mm-sig@lists.linaro.org, Casey Schaufler , netfs@lists.linux.dev, Jaegeuk Kim , fsverity@lists.linux.dev, Nicolas Pitre , Muchun Song , Roberto Sassu , "David S. Miller" , Anna Schumaker , linux-integrity@vger.kernel.org, Marcelo Ricardo Leitner , Luiz Augusto von Dentz , Alex Markuze , Martin Brandenburg , Alexander Shishkin , ocfs2-devel@lists.linux.dev, Alexei Starovoitov , linux-mtd@lists.infradead.org, amd-gfx@lists.freedesktop.org, Marc Dionne , Neal Cardwell , linux-afs@lists.infradead.org, Ian Kent , Naohiro Aota , Eric Biggers , Daniel Borkmann , Miklos Szeredi , Matthew Wilcox , coda@cs.cmu.edu, Stanislav Fomichev , Viacheslav Dubeyko , NeilBrown , Ilya Dryomov , Paolo Abeni , jfs-discussion@lists.sourceforge.net, "Serge E. Hallyn" , Amir Goldstein , James Clark , autofs@vger.kernel.org, Steven Rostedt , Damien Le Moal , Mathieu Desnoyers , Dan Williams , Oscar Salvador , Konstantin Komarov , linux-nfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-mm@kvack.org, Jeff Layton , Ondrej Mosnacek , Steve French , netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org, bpf@vger.kernel.org, ntfs3@lists.linux.dev, Christian =?iso-8859-1?Q?K=F6nig?= , Ian Rogers , Alexander Aring , Jan Kara , Peter Zijlstra , Dominique Martinet , Christian Schoenebeck , ecryptfs@vger.kernel.org, linux-unionfs@vger.kernel.org, David Howells , Joseph Qi , Andreas Dilger , Mikulas Patocka , linux-f2fs-devel@lists.sourceforge.net, David Airlie , Steffen Klassert , Eric Snowberg , Herbert Xu , linux-x25@vger.kernel.org, linux-bluetooth@vger.kernel.org, Richard Weinberger , Mark Fasheh , Dai Ngo , Ingo Molnar , Jakub Kicinski , Salah Triki , Marcel Holtmann , Joerg Reuter , codalist@telemann.coda.cs.cmu.edu, Simon Horman , apparmor@lists.ubuntu.com, Tom Talpey , Bharath SM , Marc Kleine-Budde , "Tigran A. Aivazian" , David Sterba , Namhyung Kim , Ryusuke Konishi , John Johansen , Luis de Bethencourt , Oliver Hartkopp , David Ahern , Adrian Hunter , audit@vger.kernel.org, linux-security-module@vger.kernel.org, Johannes Thumshirn , David Woodhouse , Joel Becker Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Mon, Mar 02, 2026 at 08:25:56PM -0500, Theodore Tso wrote: > On Mon, Mar 02, 2026 at 03:23:45PM -0500, Jeff Layton wrote: > > The PRIino macro is a length modifier, not a complete format specifier. > > It is used as: "%" PRIino "u" for decimal, "%" PRIino "x" for hex, etc. > > This follows the pattern used by userspace PRIu64/PRIx64 macros. > > For the record, I really hate the inttypes.h format specifiers, but I > agree that we should forward the example of the C99 spec, for better > or for worse. > > That being said, the userspace PRIu64, et. al macros are complete > format specifiers, not just a length modifier. And I think this > results in less ugly format specifiers in our kernel code. Yeah, I don't like "ino=%" PRIino "u, lolz\n" either. I'd rather have the whole format in the PRIino definition -- it /is/ unsigned long after all. --D > ---- cut here --- > #!/bin/sh > cat < /tmp/blah.c > #include > #include > > int main(int arg, char **argv) > { > printf("PRIu64 is %s\n", PRIu64); > printf("PRId64 is %s\n", PRId64); > printf("PRIx64 is %s\n", PRIx64); > return 0; > } > EOF > > clang -m32 -o /tmp/blah /tmp/blah.c > /tmp/blah > ---- cut here --- > > % /tmp/blah.sh > PRIu64 is llu > PRId64 is lld > PRIx64 is llx > > Thanks! > > - Ted _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A4409E67A63 for ; Tue, 3 Mar 2026 04:25:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=32oUZxsEZYzgYejEjM9cbE4Or19kY/lyYKekBIgENhk=; b=ePeDHtYx59pYgR wvD7XQP61EZ4NNIBePjPbjJqqz1dJPO027+uNXYBcN6b57p7TeOyc9rAS7stNOVgo1lP8T9hOOyYl H9aIm0npZrpwyyuAQfi/JeVhwVD/UK0px3iSkEn8SVsbMZzVHkgacuILJHDdZYcB6YkW3Ohc0KKcH MlewcETWJqg7mhTxhIH5Dx0EvpmiBL7IwTsz4K5kjPGYZkS9MchKq4pWfispuIHYBqZz1cfKCo5LZ 2y6es8qq10Vg7MqQUZKeZZ2Ad/ii4iqjblE43ihvTXDwK4nlwZe5Ui37BM04NwpEobX3X63L3KGXX NuJ8UoS8c3g0xk8vVhYw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vxHKR-0000000EV80-31lM; Tue, 03 Mar 2026 04:25:51 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vxHKP-0000000EV7b-0wOs; Tue, 03 Mar 2026 04:25:50 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 7099041750; Tue, 3 Mar 2026 04:25:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1F1C2C116C6; Tue, 3 Mar 2026 04:25:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772511947; bh=YZ/dFxr/gaxWgfEt0nAZiUh8L3hzuSp8PgioG8bdfOI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VVZLSXMX/ADYwgzUdgl96oTTyoWKtSsqBFyZjRHPhr3+Le570J67X1VARch7tnhrc jLMxK9WyIuv5g2RTTf67P6eMJopf19ZEik5sLXK6jqbxU64ctIOV1XX4j6Kn+Q33Nu yQYGo2cQykg/FleyBJM4gSOzSojW07vqpkIpYgN8n19BYunsJ2Ud2G/HmvpxbPcrq4 pzDmiTteXofRQDx0O66dq6F/dhJKF3yUgl8c6/qCtRRe/JhIVvnMyTg8YHSGrA3GHZ /1eA+v+KmU3ne6r8EbcoV1FFXQPxOQNpH/iFU+LVJ9yxO/ol1CYuEdDyLwooDdAzOZ srZwZE76Q+8tw== Date: Mon, 2 Mar 2026 20:25:46 -0800 From: "Darrick J. Wong" To: Theodore Tso Cc: Jeff Layton , Alexander Viro , Christian Brauner , Jan Kara , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Dan Williams , Matthew Wilcox , Eric Biggers , Muchun Song , Oscar Salvador , David Hildenbrand , David Howells , Paulo Alcantara , Andreas Dilger , Jan Kara , Jaegeuk Kim , Chao Yu , Trond Myklebust , Anna Schumaker , Chuck Lever , NeilBrown , Olga Kornievskaia , Dai Ngo , Tom Talpey , Steve French , Ronnie Sahlberg , Shyam Prasad N , Bharath SM , Alexander Aring , Ryusuke Konishi , Viacheslav Dubeyko , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Sterba , Marc Dionne , Ian Kent , Luis de Bethencourt , Salah Triki , "Tigran A. Aivazian" , Ilya Dryomov , Alex Markuze , Jan Harkes , coda@cs.cmu.edu, Nicolas Pitre , Tyler Hicks , Amir Goldstein , Christoph Hellwig , John Paul Adrian Glaubitz , Yangtao Li , Mikulas Patocka , David Woodhouse , Richard Weinberger , Dave Kleikamp , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , Mike Marshall , Martin Brandenburg , Miklos Szeredi , Anders Larsen , Zhihao Cheng , Damien Le Moal , Naohiro Aota , Johannes Thumshirn , John Johansen , Paul Moore , James Morris , "Serge E. Hallyn" , Mimi Zohar , Roberto Sassu , Dmitry Kasatkin , Eric Snowberg , Fan Wu , Stephen Smalley , Ondrej Mosnacek , Casey Schaufler , Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , David Airlie , Simona Vetter , Sumit Semwal , Eric Dumazet , Kuniyuki Iwashima , Paolo Abeni , Willem de Bruijn , "David S. Miller" , Jakub Kicinski , Simon Horman , Oleg Nesterov , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , James Clark , Martin Schiller , Eric Paris , Joerg Reuter , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Oliver Hartkopp , Marc Kleine-Budde , David Ahern , Neal Cardwell , Steffen Klassert , Herbert Xu , Remi Denis-Courmont , Marcelo Ricardo Leitner , Xin Long , Magnus Karlsson , Maciej Fijalkowski , Stanislav Fomichev , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, nvdimm@lists.linux.dev, fsverity@lists.linux.dev, linux-mm@kvack.org, netfs@lists.linux.dev, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-nilfs@vger.kernel.org, v9fs@lists.linux.dev, linux-afs@lists.infradead.org, autofs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@telemann.coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-mtd@lists.infradead.org, jfs-discussion@lists.sourceforge.net, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, devel@lists.orangefs.org, linux-unionfs@vger.kernel.org, apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org, linux-integrity@vger.kernel.org, selinux@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org, netdev@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-fscrypt@vger.kernel.org, linux-xfs@vger.kernel.org, linux-hams@vger.kernel.org, linux-x25@vger.kernel.org, audit@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-can@vger.kernel.org, linux-sctp@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH v2 001/110] vfs: introduce kino_t typedef and PRIino format macro Message-ID: <20260303042546.GF13868@frogsfrogsfrogs> References: <20260302-iino-u64-v2-0-e5388800dae0@kernel.org> <20260302-iino-u64-v2-1-e5388800dae0@kernel.org> <20260303012556.GA6520@macsyma-wired.lan> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260303012556.GA6520@macsyma-wired.lan> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260302_202549_305093_EA92A307 X-CRM114-Status: GOOD ( 18.78 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Mon, Mar 02, 2026 at 08:25:56PM -0500, Theodore Tso wrote: > On Mon, Mar 02, 2026 at 03:23:45PM -0500, Jeff Layton wrote: > > The PRIino macro is a length modifier, not a complete format specifier. > > It is used as: "%" PRIino "u" for decimal, "%" PRIino "x" for hex, etc. > > This follows the pattern used by userspace PRIu64/PRIx64 macros. > > For the record, I really hate the inttypes.h format specifiers, but I > agree that we should forward the example of the C99 spec, for better > or for worse. > > That being said, the userspace PRIu64, et. al macros are complete > format specifiers, not just a length modifier. And I think this > results in less ugly format specifiers in our kernel code. Yeah, I don't like "ino=%" PRIino "u, lolz\n" either. I'd rather have the whole format in the PRIino definition -- it /is/ unsigned long after all. --D > ---- cut here --- > #!/bin/sh > cat < /tmp/blah.c > #include > #include > > int main(int arg, char **argv) > { > printf("PRIu64 is %s\n", PRIu64); > printf("PRId64 is %s\n", PRId64); > printf("PRIx64 is %s\n", PRIx64); > return 0; > } > EOF > > clang -m32 -o /tmp/blah /tmp/blah.c > /tmp/blah > ---- cut here --- > > % /tmp/blah.sh > PRIu64 is llu > PRId64 is lld > PRIx64 is llx > > Thanks! > > - Ted ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/