From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C7890388363 for ; Tue, 3 Mar 2026 08:45:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.92.199 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772527505; cv=none; b=iCumLSJ9Hu4eijYUZ8f0HEsGV9mYW3wnA7in/PO0zsaKsbbXpWShCT5hnjqgvnItHjqdfVY89ItibnRtPklpEIz8PTyMcwgx+DK3latRPHf+G6XPhSAaC+iOJWBnb0DY4GlFbgPGNUvKhVlP9FZaQdK3EdR3IXrDV1/ZXLhALJg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772527505; c=relaxed/simple; bh=Bl90t4j6lPubHnr4PeO4/uk03hNK22wCBpqwR8aGrrE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=A6hDr2UztZXZ06aKGxcTacw07Di9t/Hzbcq6CpxybsOUqeCaEvl1fx5t1VRFcVXDhXv2LdhUk17WcVhBntCGXZSYO14cK0NQuTWrsQv//rcax5ijVv3h0txZUtoIqekuSnorypgx0mD0uUi2BQIZ9dykcQrocHV9MdJWD59uw7g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=oNOvIUkc; arc=none smtp.client-ip=90.155.92.199 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="oNOvIUkc" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=aeqY1hFOMgFfUWET3LBiasXeWQxmm0naPWE3EHWuV1c=; b=oNOvIUkcraoFwtG71gympmovEb 9v540zG2VXqVPbgLwlPmtXwqUY5tEwD0LnKkjM2Pv8RFH0+mo5GjMQN3/HQQC1n1RCUM6GnuDbrxM jro2ZPZTIhkJzf/0VvtyPE7isAFN3/Xr+tnVXz5QY8odxbsl1BBz73NZBSGPCDM5G75nVerPHxf3X rlDCE8CE1lKPATEvLbmct7xlcA1VcSqby6e/6/D1M+A/xVRpZvfn2INZ9hg/TxQH2ZCj3E0RsSoUd ItgROwuy5EQOZttIehGEenNq2uYCzD96vQ0uZg/KMDr+TcZ+hCc9CgAVAw13BFO1fJNtUMGsCmCZ5 XJ+/5f1A==; Received: from 77-249-17-252.cable.dynamic.v4.ziggo.nl ([77.249.17.252] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.98.2 #2 (Red Hat Linux)) id 1vxLN6-00000001v0y-0zKr; Tue, 03 Mar 2026 08:44:53 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id C6AC2303018; Tue, 03 Mar 2026 09:44:50 +0100 (CET) Date: Tue, 3 Mar 2026 09:44:50 +0100 From: Peter Zijlstra To: Zhang Rui Cc: "Chen, Yu C" , Tim Chen , linux-kernel@vger.kernel.org, kyle.meyer@hpe.com, vinicius.gomes@intel.com, brgerst@gmail.com, hpa@zytor.com, kprateek.nayak@amd.com, patryk.wlazlyn@linux.intel.com, rafael.j.wysocki@intel.com, russ.anderson@hpe.com, zhao1.liu@intel.com, tony.luck@intel.com, x86@kernel.org, tglx@kernel.org Subject: Re: [RFC][PATCH 5/6] x86/topo: Fix SNC topology mess Message-ID: <20260303084450.GM606826@noisy.programming.kicks-ass.net> References: <20260226104909.675623579@infradead.org> <20260226105052.737712686@infradead.org> <334d4edb-b8f4-41fb-aa16-6cb7abeaa21d@intel.com> <20260227130130.GD1395266@noisy.programming.kicks-ass.net> <67cfac6fe0495a533fa3204fa01ee07653029e91.camel@linux.intel.com> <20260302164317.GP1282955@noisy.programming.kicks-ass.net> <570f930fcf770119b0edd3453899068876322d91.camel@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <570f930fcf770119b0edd3453899068876322d91.camel@gmail.com> On Tue, Mar 03, 2026 at 02:31:37PM +0800, Zhang Rui wrote: > On Mon, 2026-03-02 at 17:43 +0100, Peter Zijlstra wrote: > > nt On Sat, Feb 28, 2026 at 03:35:26PM +0800, Chen, Yu C wrote: > > > > > Here we check packages0 and 1, should we check all the packages? > > > > Might as well I suppose. > > > > Could you boot queue/x86/topo on an snc-3 machine to verify it > > doesn't > > explode with all the paranoia on? > > Hi, Peter, > > regarding slit_validate() in > https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git/commit/?h=x86/topo&id=24ca94ac4b72803a7164b7ad84f06f0e9f0c49df > > I suppose we want to use > WARN_ON_ONCE(!slit_cluster_symmetric(n)) > rather than > WARN_ON_ONCE(slit_cluster_symmetric(n)); > right? D'0h yes, very much so! Thanks! Let me go expand the Changelogs some post and then probably stick it in tip somewhere.