From: Christian Marangi <ansuelsmth@gmail.com>
To: Tom Rini <trini@konsulko.com>, Simon Glass <sjg@chromium.org>,
Casey Connolly <casey.connolly@linaro.org>,
Christian Marangi <ansuelsmth@gmail.com>,
Peng Fan <peng.fan@nxp.com>,
Quentin Schulz <quentin.schulz@cherry.de>,
Harsha Vardhan V M <h-vm@ti.com>,
Neha Malcom Francis <n-francis@ti.com>,
Chen-Yu Tsai <wens@kernel.org>,
Jamie Gibbons <jamie.gibbons@microchip.com>,
Justin Klaassen <justin@tidylabs.net>,
Leo Yu-Chi Liang <ycliang@andestech.com>,
Weijie Gao <weijie.gao@mediatek.com>,
Marek Vasut <marek.vasut+renesas@mailbox.org>,
"Lucien.Jheng" <lucienzx159@gmail.com>,
Sky Huang <SkyLake.Huang@mediatek.com>,
Alif Zakuan Yuslaimi <alif.zakuan.yuslaimi@altera.com>,
u-boot@lists.denx.de
Subject: [PATCH 1/5] misc: fs_loader: fix ubifs not unmounted on dev_get_priv error
Date: Tue, 3 Mar 2026 14:29:08 +0100 [thread overview]
Message-ID: <20260303132916.5502-2-ansuelsmth@gmail.com> (raw)
In-Reply-To: <20260303132916.5502-1-ansuelsmth@gmail.com>
When dev_get_priv errors out, the ubifs is not unbounted (if used)
Correctly handle this handle condition and while at it also return -EINVAL
instead of -ENOMEM as a better error since no memory is allocated but is
actually an invalid scenario for fw_get_filesystem_firmware().
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
---
drivers/misc/fs_loader.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/misc/fs_loader.c b/drivers/misc/fs_loader.c
index 2928cf75f89e..7e432a7ebd62 100644
--- a/drivers/misc/fs_loader.c
+++ b/drivers/misc/fs_loader.c
@@ -178,8 +178,10 @@ static int fw_get_filesystem_firmware(struct udevice *dev)
struct firmware *firmwarep = dev_get_priv(dev);
- if (!firmwarep)
- return -ENOMEM;
+ if (!firmwarep) {
+ ret = -EINVAL;
+ goto out;
+ }
ret = fs_read(firmwarep->name, (ulong)map_to_sysmem(firmwarep->data),
firmwarep->offset, firmwarep->size, &actread);
--
2.51.0
next prev parent reply other threads:[~2026-03-03 13:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-03 13:29 [PATCH 0/5] misc: fs_loader: reorg and split to FS and FW loader + FIP loader Christian Marangi
2026-03-03 13:29 ` Christian Marangi [this message]
2026-03-03 13:38 ` [PATCH 1/5] misc: fs_loader: fix ubifs not unmounted on dev_get_priv error Daniel Golle
2026-03-03 13:43 ` Christian Marangi
2026-03-03 13:53 ` Daniel Golle
2026-03-03 13:29 ` [PATCH 2/5] misc: fs_loader: reorganize and split to FS and FW loader Christian Marangi
2026-03-03 13:29 ` [PATCH 3/5] misc: fw_loader: implement generic get_fw_loader_from_node() Christian Marangi
2026-03-03 13:29 ` [PATCH 4/5] misc: fw_loader: introduce FIP loader driver Christian Marangi
2026-03-03 13:29 ` [PATCH 5/5] misc: fw_loader: implement request_firmware_size() OP Christian Marangi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260303132916.5502-2-ansuelsmth@gmail.com \
--to=ansuelsmth@gmail.com \
--cc=SkyLake.Huang@mediatek.com \
--cc=alif.zakuan.yuslaimi@altera.com \
--cc=casey.connolly@linaro.org \
--cc=h-vm@ti.com \
--cc=jamie.gibbons@microchip.com \
--cc=justin@tidylabs.net \
--cc=lucienzx159@gmail.com \
--cc=marek.vasut+renesas@mailbox.org \
--cc=n-francis@ti.com \
--cc=peng.fan@nxp.com \
--cc=quentin.schulz@cherry.de \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=weijie.gao@mediatek.com \
--cc=wens@kernel.org \
--cc=ycliang@andestech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.