All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Long Li <longli@microsoft.com>
Cc: dev@dpdk.org, weh@microsoft.com, stable@dpdk.org
Subject: Re: [PATCH v4 0/6] net/netvsc: bug fixes and runtime queue reconfiguration
Date: Tue, 3 Mar 2026 14:16:05 -0800	[thread overview]
Message-ID: <20260303141605.02edf0e7@phoenix.local> (raw)
In-Reply-To: <20260303205411.325585-1-longli@microsoft.com>

On Tue,  3 Mar 2026 12:54:03 -0800
Long Li <longli@microsoft.com> wrote:

> This series fixes several resource management bugs in the netvsc PMD and
> adds support for runtime queue count reconfiguration.
> 
> Patches 1-5 are bug fixes:
>   1. Subchannel leak on device removal — subchannels allocated during
>      configure are never closed in uninit.
>   2. Double-free of primary Rx queue — hn_dev_free_queues() already
>      frees hv->primary, then uninit frees it again.
>   3. Init error path leaks — hv->primary and hv->channels[0] not freed
>      on failure after allocation.
>   4. Event callback leak — device event callback not unregistered when
>      rxfilter or vf_start fails in hn_dev_start().
>   5. MTU change path leaks — missing chimney bitmap teardown/rebuild,
>      rxbuf_info leak, stale subchannel pointers, and VMBus channel
>      close before free.
> 
> Patch 6 adds runtime queue count reconfiguration via port
> stop/configure/start, with full NVS/RNDIS session teardown and reinit
> when the queue count changes.
> 
> Tested:
>   - Queue reconfig: 4→2→8 queues, all transitions successful
>   - MTU changes: 1500→4000→8000 with rxd/txd=2048, no crashes
>   - TX pps: 15.5M (1500B), 6.1M (4000B), 3.1M (8000B)
>   - RX pps: 7.6M (1500B), 2.7M (4000B), 1.4M (8000B)


Looks good, applied to next-net.

PS: had to argue with Claude to get it to understand relationship
between queues and vmbus channels

  parent reply	other threads:[~2026-03-03 22:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-03 20:54 [PATCH v4 0/6] net/netvsc: bug fixes and runtime queue reconfiguration Long Li
2026-03-03 20:54 ` [PATCH v4 1/6] net/netvsc: fix subchannel leak on device removal Long Li
2026-03-03 20:54 ` [PATCH v4 2/6] net/netvsc: fix double-free of primary Rx queue on uninit Long Li
2026-03-03 20:54 ` [PATCH v4 3/6] net/netvsc: fix resource leak in init error path Long Li
2026-03-03 20:54 ` [PATCH v4 4/6] net/netvsc: fix event callback leak on rxfilter failure Long Li
2026-03-03 20:54 ` [PATCH v4 5/6] net/netvsc: fix resource leaks in MTU change path Long Li
2026-03-03 20:54 ` [PATCH v4 6/6] net/netvsc: support runtime queue count reconfiguration Long Li
2026-03-03 22:16 ` Stephen Hemminger [this message]
2026-03-03 22:30   ` [EXTERNAL] Re: [PATCH v4 0/6] net/netvsc: bug fixes and runtime queue reconfiguration Long Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260303141605.02edf0e7@phoenix.local \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=longli@microsoft.com \
    --cc=stable@dpdk.org \
    --cc=weh@microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.