From: "Daniel P. Berrangé" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
"Christian Schoenebeck" <qemu_oss@crudebyte.com>
Subject: [PULL 12/27] audio: make jackaudio use qemu_thread_set_name
Date: Tue, 3 Mar 2026 15:05:49 +0000 [thread overview]
Message-ID: <20260303150604.2402872-13-berrange@redhat.com> (raw)
In-Reply-To: <20260303150604.2402872-1-berrange@redhat.com>
This has greater portability than directly call pthread_setname_np,
which is only 1 out of 3 possible functions for pthreads that can
set the name.
The new API requires a trampoline function, since it can only set
the name of the current thread.
Reviewed-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
audio/jackaudio.c | 28 +++++++++++++++++++++++-----
1 file changed, 23 insertions(+), 5 deletions(-)
diff --git a/audio/jackaudio.c b/audio/jackaudio.c
index f49fd82c45..be6fb378f7 100644
--- a/audio/jackaudio.c
+++ b/audio/jackaudio.c
@@ -633,18 +633,36 @@ static void qjack_enable_in(HWVoiceIn *hw, bool enable)
ji->c.enabled = enable;
}
-#if !defined(WIN32) && defined(CONFIG_PTHREAD_SETNAME_NP_W_TID)
+#if !defined(WIN32)
+struct QJackThreadData {
+ void *(*function)(void *);
+ void *arg;
+};
+
+static void *qjack_thread_trampoline(void *targ)
+{
+ struct QJackThreadData *data = targ;
+ void *(*function)(void *) = data->function;
+ void *arg = data->arg;
+
+ g_free(data);
+ qemu_thread_set_name("jack-client");
+
+ return function(arg);
+}
+
static int qjack_thread_creator(jack_native_thread_t *thread,
const pthread_attr_t *attr, void *(*function)(void *), void *arg)
{
- int ret = pthread_create(thread, attr, function, arg);
+ struct QJackThreadData *data = g_new0(struct QJackThreadData, 1);
+ data->function = function;
+ data->arg = arg;
+ int ret = pthread_create(thread, attr, qjack_thread_trampoline, data);
if (ret != 0) {
+ g_free(data);
return ret;
}
- /* set the name of the thread */
- pthread_setname_np(*thread, "jack-client");
-
return ret;
}
#endif
--
2.53.0
next prev parent reply other threads:[~2026-03-03 15:07 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-03 15:05 [PULL 00/27] Misc patches queue Daniel P. Berrangé
2026-03-03 15:05 ` [PULL 01/27] scripts: detect another GPL license boilerplate variant Daniel P. Berrangé
2026-03-03 15:05 ` [PULL 02/27] io: separate freeing of tasks from marking them as complete Daniel P. Berrangé
2026-03-03 15:05 ` [PULL 03/27] io: fix cleanup for TLS I/O source data on cancellation Daniel P. Berrangé
2026-03-03 15:05 ` [PULL 04/27] io: fix cleanup for websock " Daniel P. Berrangé
2026-03-03 15:05 ` [PULL 05/27] docs: simplify DiamondRapids CPU docs Daniel P. Berrangé
2026-03-03 15:05 ` [PULL 06/27] qemu-options: remove extraneous [] around arg values Daniel P. Berrangé
2026-03-03 15:05 ` [PULL 07/27] include: define constant for early constructor priority Daniel P. Berrangé
2026-03-03 15:05 ` [PULL 08/27] monitor: initialize global data from a constructor Daniel P. Berrangé
2026-03-03 15:05 ` [PULL 09/27] system: unconditionally enable thread naming Daniel P. Berrangé
2026-03-03 15:05 ` [PULL 10/27] util: fix race setting thread name on Win32 Daniel P. Berrangé
2026-03-03 15:05 ` [PULL 11/27] util: expose qemu_thread_set_name Daniel P. Berrangé
2026-03-03 15:05 ` Daniel P. Berrangé [this message]
2026-03-03 15:05 ` [PULL 13/27] util: set the name for the 'main' thread on Windows Daniel P. Berrangé
2026-03-03 15:05 ` [PULL 14/27] util: add API to fetch the current thread name Daniel P. Berrangé
2026-03-03 15:05 ` [PULL 15/27] util: introduce some API docs for logging APIs Daniel P. Berrangé
2026-03-03 15:05 ` [PULL 16/27] util: avoid repeated prefix on incremental qemu_log calls Daniel P. Berrangé
2026-03-03 15:05 ` [PULL 17/27] util/log: add missing error reporting in qemu_log_trylock_with_err Daniel P. Berrangé
2026-03-03 15:05 ` [PULL 18/27] ui: add proper error reporting for password changes Daniel P. Berrangé
2026-03-03 15:05 ` [PULL 19/27] ui: remove redundant use of error_printf_unless_qmp() Daniel P. Berrangé
2026-03-03 15:05 ` [PULL 20/27] monitor: remove redundant error_[v]printf_unless_qmp Daniel P. Berrangé
2026-03-03 15:05 ` [PULL 21/27] monitor: refactor error_vprintf() Daniel P. Berrangé
2026-03-03 15:05 ` [PULL 22/27] monitor: move error_vprintf back to error-report.c Daniel P. Berrangé
2026-03-03 15:06 ` [PULL 23/27] util: fix interleaving of error & trace output Daniel P. Berrangé
2026-03-03 15:06 ` [PULL 24/27] util: don't skip error prefixes when QMP is active Daniel P. Berrangé
2026-03-03 15:06 ` [PULL 25/27] util: fix interleaving of error prefixes Daniel P. Berrangé
2026-03-03 15:06 ` [PULL 26/27] scripts/checkpatch: Fix MAINTAINERS update warning with --terse Daniel P. Berrangé
2026-03-03 15:06 ` [PULL 27/27] util/oslib-posix: increase memprealloc thread count to 32 Daniel P. Berrangé
2026-03-05 14:47 ` [PULL 00/27] Misc patches queue Peter Maydell
2026-03-05 15:15 ` Daniel P. Berrangé
2026-03-05 17:48 ` Daniel P. Berrangé
-- strict thread matches above, loose matches on Subject: below --
2026-03-05 17:47 [PULL v2 " Daniel P. Berrangé
2026-03-05 17:47 ` [PULL 12/27] audio: make jackaudio use qemu_thread_set_name Daniel P. Berrangé
2026-03-07 11:37 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260303150604.2402872-13-berrange@redhat.com \
--to=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu_oss@crudebyte.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.