From: Jakub Kicinski <kuba@kernel.org>
To: David Wei <dw@davidwei.uk>
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Joe Damato <joe@dama.to>,
Wei Wang <weibunny@meta.com>,
Bobby Eshleman <bobbyeshleman@gmail.com>,
Stanislav Fomichev <sdf@fomichev.me>,
Nikolay Aleksandrov <razor@blackwall.org>
Subject: Re: [PATCH net-next v2 4/4] selftests/net: Add netkit container ping test
Date: Tue, 3 Mar 2026 15:51:02 -0800 [thread overview]
Message-ID: <20260303155102.1c5de2c5@kernel.org> (raw)
In-Reply-To: <20260302053315.1919859-5-dw@davidwei.uk>
On Sun, 1 Mar 2026 21:33:15 -0800 David Wei wrote:
> diff --git a/tools/testing/selftests/drivers/net/hw/config b/tools/testing/selftests/drivers/net/hw/config
> index 2307aa001be1..b6524040418e 100644
> --- a/tools/testing/selftests/drivers/net/hw/config
> +++ b/tools/testing/selftests/drivers/net/hw/config
> @@ -1,3 +1,4 @@
> +CONFIG_BPF_SYSCALL=y
> CONFIG_FAIL_FUNCTION=y
> CONFIG_FAULT_INJECTION=y
> CONFIG_FAULT_INJECTION_DEBUG_FS=y
> @@ -5,6 +6,8 @@ CONFIG_FUNCTION_ERROR_INJECTION=y
> CONFIG_IO_URING=y
> CONFIG_IPV6=y
> CONFIG_IPV6_GRE=y
> +CONFIG_NETKIT=y
> +CONFIG_NET_CLS_BPF=y
> CONFIG_NET_IPGRE=y
> CONFIG_NET_IPGRE_DEMUX=y
> CONFIG_UDMABUF=y
the sort order we use ignores _ characters:
$ ../nipa/tests/patch/check_selftest/validate_config_format.py tools/testing/selftests/drivers/net/hw/config
Validation errors in tools/testing/selftests/drivers/net/hw/config:
Lines 9-10 invalid order, CONFIG_NET_CLS_BPF=y should be before CONFIG_NETKIT=y
Also here and in patch 2 we're getting new pylint --disable=R warnings.
Please fix them where possible.
prev parent reply other threads:[~2026-03-03 23:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-02 5:33 [PATCH net-next v2 0/4] selftests/net: add netkit container env and test David Wei
2026-03-02 5:33 ` [PATCH net-next v2 1/4] selftests/net: Add bpf skb forwarding program David Wei
2026-03-02 5:33 ` [PATCH net-next v2 2/4] selftests/net: Export Netlink class via lib.py David Wei
2026-03-03 23:46 ` Jakub Kicinski
2026-03-02 5:33 ` [PATCH net-next v2 3/4] selftests/net: Add env for container based tests David Wei
2026-03-03 23:47 ` Jakub Kicinski
2026-03-02 5:33 ` [PATCH net-next v2 4/4] selftests/net: Add netkit container ping test David Wei
2026-03-03 23:51 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260303155102.1c5de2c5@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=bobbyeshleman@gmail.com \
--cc=davem@davemloft.net \
--cc=dw@davidwei.uk \
--cc=edumazet@google.com \
--cc=joe@dama.to \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=sdf@fomichev.me \
--cc=weibunny@meta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.