From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D8B6282F37; Tue, 3 Mar 2026 16:04:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772553874; cv=none; b=TRY2+mCTmIIH/417y5S0bepYx1bvOnlUtExUf2HASoJGCxQx+qePK3Z56fR8sbVmVNKDnWroDP4nXusQ+6RedmSI3h17oQvv2prQfzm9cF7VkdSgFOxebN48fZqOc5yC2WDJ81l2b0ITYywoZMdoyWfwL+dSVk9DeffcqjsTkYk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772553874; c=relaxed/simple; bh=FyDdjLedTpsP6TzUy6AnArgDyfiqI7jC6hlyZPHtYFU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mv1zcjEvz6nOJ5iBNusC5n4G0sba22+gMjmxWw8b66XemH3b5LGE8aqmWYGVASuEaiT2Geio7pfNEvKSEYWmXP273xMjElaNWDr1eEP4No+5/3ylPRdlzgqjy0OvUX59pj1ZEUhhK8jvmo857xkmvSXyjw7vOQp/7bWjqsOOoxk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id 2F91868BEB; Tue, 3 Mar 2026 17:04:29 +0100 (CET) Date: Tue, 3 Mar 2026 17:04:28 +0100 From: Christoph Hellwig To: Eric Biggers Cc: Christoph Hellwig , Andrew Morton , Richard Henderson , Matt Turner , Magnus Lindholm , Russell King , Catalin Marinas , Will Deacon , Huacai Chen , WANG Xuerui , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , "David S. Miller" , Andreas Larsson , Richard Weinberger , Anton Ivanov , Johannes Berg , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Herbert Xu , Dan Williams , Chris Mason , David Sterba , Arnd Bergmann , Song Liu , Yu Kuai , Li Nan , linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-crypto@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-arch@vger.kernel.org, linux-raid@vger.kernel.org Subject: Re: [PATCH 16/25] sparc: move the XOR code to lib/raid/ Message-ID: <20260303160428.GE7021@lst.de> References: <20260226151106.144735-1-hch@lst.de> <20260226151106.144735-17-hch@lst.de> <20260228054716.GF65277@quark> Precedence: bulk X-Mailing-List: linux-alpha@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260228054716.GF65277@quark> User-Agent: Mutt/1.5.17 (2007-11-01) On Fri, Feb 27, 2026 at 09:47:16PM -0800, Eric Biggers wrote: > On Thu, Feb 26, 2026 at 07:10:28AM -0800, Christoph Hellwig wrote: > > diff --git a/arch/sparc/lib/xor.S b/lib/raid/xor/sparc/xor-niagara.S > > similarity index 53% > > rename from arch/sparc/lib/xor.S > > rename to lib/raid/xor/sparc/xor-niagara.S > > index 35461e3b2a9b..f8749a212eb3 100644 > > --- a/arch/sparc/lib/xor.S > > +++ b/lib/raid/xor/sparc/xor-niagara.S > > @@ -1,11 +1,8 @@ > > /* SPDX-License-Identifier: GPL-2.0 */ > > /* > > - * arch/sparc64/lib/xor.S > > - * > > * High speed xor_block operation for RAID4/5 utilizing the > > - * UltraSparc Visual Instruction Set and Niagara store-init/twin-load. > > + * Niagara store-init/twin-load. > > * > > - * Copyright (C) 1997, 1999 Jakub Jelinek (jj@ultra.linux.cz) > > * Copyright (C) 2006 David S. Miller > > */ > > > > @@ -16,343 +13,6 @@ > > #include > > #include > > > > can be removed from the two assembly files, since all > the invocations of EXPORT_SYMBOL() in them were removed. > > Also, xor-niagara.S ended up without a .text directive at the beginning. > Probably it was unnecessary anyway. However, this seems unintentional, > given that xor-vis.S still has it. I'll probably undo the split and just do the mechanical move for the next version. This was a bit too much change even if a split would be my preferred outcome. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 603A0EDA693 for ; Tue, 3 Mar 2026 16:04:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=t5bfpGem81QrHvt7zDPjLwkB7S/gsznwaG2jpYyO5gI=; b=wBprpMJ5T5Epew 6cH8oLvWSDlGq9ckcvZ6HMj4zrRmEf7IxrMHfLoFolDmYCmt848xjVyUJSnZsfbmD5ZBAmcgLntsC IVpWDFxYUBCzlKF9ljCMPEBUClSywQ6bcYBy3BnsN/tcq+M38zxiXxwA4ajGL4+VTHK1HwAomIHeB 0nXxIvNOe7637vrR9m2kFPK1DcsZRON43/Gyl6HrtKXYS4Pw6q25KrEbGxVahdgNf7Q3lPogaGcPt fBjVnrnhUQ74zYU7LrMNxGEiFEBnqeFf1drtK4J/sva7EoVQyaCOJs14A1llqJWys+lY6Ebvr/F9V BolHMZNG3dm3lE02qmdQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vxSEg-0000000FVpX-2H9U; Tue, 03 Mar 2026 16:04:38 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vxSEa-0000000FVoB-2C5i; Tue, 03 Mar 2026 16:04:37 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 2F91868BEB; Tue, 3 Mar 2026 17:04:29 +0100 (CET) Date: Tue, 3 Mar 2026 17:04:28 +0100 From: Christoph Hellwig To: Eric Biggers Cc: Christoph Hellwig , Andrew Morton , Richard Henderson , Matt Turner , Magnus Lindholm , Russell King , Catalin Marinas , Will Deacon , Huacai Chen , WANG Xuerui , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , "David S. Miller" , Andreas Larsson , Richard Weinberger , Anton Ivanov , Johannes Berg , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Herbert Xu , Dan Williams , Chris Mason , David Sterba , Arnd Bergmann , Song Liu , Yu Kuai , Li Nan , linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-crypto@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-arch@vger.kernel.org, linux-raid@vger.kernel.org Subject: Re: [PATCH 16/25] sparc: move the XOR code to lib/raid/ Message-ID: <20260303160428.GE7021@lst.de> References: <20260226151106.144735-1-hch@lst.de> <20260226151106.144735-17-hch@lst.de> <20260228054716.GF65277@quark> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260228054716.GF65277@quark> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260303_080432_859547_52968550 X-CRM114-Status: GOOD ( 22.49 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Fri, Feb 27, 2026 at 09:47:16PM -0800, Eric Biggers wrote: > On Thu, Feb 26, 2026 at 07:10:28AM -0800, Christoph Hellwig wrote: > > diff --git a/arch/sparc/lib/xor.S b/lib/raid/xor/sparc/xor-niagara.S > > similarity index 53% > > rename from arch/sparc/lib/xor.S > > rename to lib/raid/xor/sparc/xor-niagara.S > > index 35461e3b2a9b..f8749a212eb3 100644 > > --- a/arch/sparc/lib/xor.S > > +++ b/lib/raid/xor/sparc/xor-niagara.S > > @@ -1,11 +1,8 @@ > > /* SPDX-License-Identifier: GPL-2.0 */ > > /* > > - * arch/sparc64/lib/xor.S > > - * > > * High speed xor_block operation for RAID4/5 utilizing the > > - * UltraSparc Visual Instruction Set and Niagara store-init/twin-load. > > + * Niagara store-init/twin-load. > > * > > - * Copyright (C) 1997, 1999 Jakub Jelinek (jj@ultra.linux.cz) > > * Copyright (C) 2006 David S. Miller > > */ > > > > @@ -16,343 +13,6 @@ > > #include > > #include > > > > can be removed from the two assembly files, since all > the invocations of EXPORT_SYMBOL() in them were removed. > > Also, xor-niagara.S ended up without a .text directive at the beginning. > Probably it was unnecessary anyway. However, this seems unintentional, > given that xor-vis.S still has it. I'll probably undo the split and just do the mechanical move for the next version. This was a bit too much change even if a split would be my preferred outcome. _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv