From: Jakub Kicinski <kuba@kernel.org>
To: Fernando Fernandez Mancera <fmancera@suse.de>
Cc: netdev@vger.kernel.org, tgraf@infradead.org, horms@kernel.org,
pabeni@redhat.com, edumazet@google.com, dsahern@kernel.org,
davem@davemloft.net
Subject: Re: [PATCH net v3] ipv4: bump rt_genid when a relevant devconf value changes through netlink
Date: Tue, 3 Mar 2026 18:38:43 -0800 [thread overview]
Message-ID: <20260303183843.5b29d5b0@kernel.org> (raw)
In-Reply-To: <20260302130858.5197-1-fmancera@suse.de>
On Mon, 2 Mar 2026 14:08:57 +0100 Fernando Fernandez Mancera wrote:
> + switch (nla_type(a)) {
> + case IPV4_DEVCONF_FORWARDING:
> + if (nla_get_u32(a))
> + netif_disable_lro(dev);
why not dev_disable_lro()??
> + fallthrough;
> + case IPV4_DEVCONF_NOXFRM:
> + case IPV4_DEVCONF_NOPOLICY:
> + case IPV4_DEVCONF_PROMOTE_SECONDARIES:
> + case IPV4_DEVCONF_ROUTE_LOCALNET:
> + case IPV4_DEVCONF_DROP_UNICAST_IN_L2_MULTICAST:
> + flush_cache = true;
> + break;
> + default:
> + break;
> + }
> + }
> + if (flush_cache)
> + rt_cache_flush(net);
> }
Looking closer at this I'm struggling to connect this to
devinet_conf_proc(). The attrs you're snooping here are completely different!?
Logic for when rt_cache_flush() happens is different.
inet_netconf_notify_devconf() is missing even after the patch.
--
pw-bot: cr
next prev parent reply other threads:[~2026-03-04 2:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-02 13:08 [PATCH net v3] ipv4: bump rt_genid when a relevant devconf value changes through netlink Fernando Fernandez Mancera
2026-03-04 2:38 ` Jakub Kicinski [this message]
2026-03-04 9:03 ` Fernando Fernandez Mancera
2026-03-04 18:52 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260303183843.5b29d5b0@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=fmancera@suse.de \
--cc=horms@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tgraf@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.