From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D87CCEDEBE5 for ; Tue, 3 Mar 2026 19:58:41 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EC6A610E031; Tue, 3 Mar 2026 19:58:40 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="dCgrcDoC"; dkim-atps=neutral Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) by gabe.freedesktop.org (Postfix) with ESMTPS id 996BD10E031 for ; Tue, 3 Mar 2026 19:58:39 +0000 (UTC) Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-439c5cce2c6so222113f8f.3 for ; Tue, 03 Mar 2026 11:58:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772567918; x=1773172718; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=SdLh/NWLkEm3eJhtC/mdgt/+LRhEHwHgzGrdAve98wA=; b=dCgrcDoCf4HAM4R3SA2RpVd2kNQAQZutTJ0pJAM1zzNNBczlkcs7ezJII2rlmWKj58 M9DEDk4xqhMxjktk4O9fdq1U7MAktyXCIHlFWGa1B/P56EOBaAI1PwN3xB9mcU0jyWBn 5UbkwYEsNTqFhfLRsgATgo2uxPPWAbybNDp1LBG4yqmBVl6C+9GLQt3VRKOM56zbj3ba ust0k4YAif7wXe7hEsM69JKVOkMWltBq3dXdZjERc3ma3hzCQSTY714Kdoq6nThPLmng 2gy7G6bpnaeqg1e1X1hGB7/CLBy/ox8mqsNC22QTKkhszdA6eO4BIENSEfD+eipAtWSx MpzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772567918; x=1773172718; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=SdLh/NWLkEm3eJhtC/mdgt/+LRhEHwHgzGrdAve98wA=; b=nhkAdYDPNqOBXVuR99RYAwPvj81Wz2mSrU0rRf6+2SN6Jkl6cu4AHirEDLfzqR9AVb 9XtToXDKXek2Me23PWcCUL1JZxz/DYD9PWOu9N4YO93KqWfjfN/vL6UGAdc2aSzGiaQW cMS+658vZC4fS6W9+L6rnUCPeNFw0RIQhEZiiyUnNVe8O7fFKoz/oOHyapkm+m/2Joy+ rFX61UCZwKKEz4/XrroZ9QUj9oTuDSLwHvAAp7FChGWdIlEUpkGCTGFkLGeRm/JlMF0c BcNpKbuFaTOl7SaIkUbrIsf5aMqxGKPkO+SW5JSOPU8lDRjLfpU9Zj9XPfEQZQ8t7Y12 HjRw== X-Forwarded-Encrypted: i=1; AJvYcCUfUuvCmZZrz0RaVbOwirmx/H+uahjBr5a4+dEL0zi5lOybWrLyrlI94JZVIuJqmJRWpRppSyYXTE8=@lists.freedesktop.org X-Gm-Message-State: AOJu0YyDSYrYlXIfNFdsfc6tFSwlnc7fytH2vuS3QI9B+DGWNM1d1WRs NWGKHXe6smGMZ428HaC08FZqpsLOz1N+ImP14fk1eUUY0jvT905zh6qZ X-Gm-Gg: ATEYQzyV20eQLnhNtzk7hVO4gVZZm8NTbTNsHQcmFsNN7h5ZALKPZPKMXyJavdXv7Mf WmAF2PoOLzLEGNg0KgZ5IqoKg4QhfxvTf0g1P3JWlxKBiVYIZoBpTKRnTdez0proK+xZfmFGp+0 ONHwNc8EgHQXl4dan4covXKCr7c3HUCRIljhePNE1riM0/6Msu8uMJlDnKvvze3A2vYAZIVMWeF MyV6RoYmwIZCnR6aFN4Zqd7f6dcvA2r+5fHv0AGcw3FXchxg4PRuOEG8ekHb0+XdVIzcsoFTU5l d+l9+NkWJtHhY+ZfqzBKjc6k0vxc1T4itBSt7D67/ez0sz1dyCVTfx7ypAzw0Xlv6Fqzw2//2/p dM9n8Fgkipe+FCK+yHIF8ga3QK4B1qEgth7HkbGql6J5Hata+RoOxxB7tmD9X6gpHjgLK5/EGlK V8U4I0MO1l9qQptmWbrXpsOEMGjK9fGIzUcVM6SMhDvrY5rBegKK4RkPBQW4vnbAgL X-Received: by 2002:a05:6000:25c3:b0:439:be67:a038 with SMTP id ffacd0b85a97d-439be67a710mr9921230f8f.41.1772567917770; Tue, 03 Mar 2026 11:58:37 -0800 (PST) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439b503425asm19275915f8f.25.2026.03.03.11.58.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Mar 2026 11:58:37 -0800 (PST) Date: Tue, 3 Mar 2026 19:58:35 +0000 From: David Laight To: Julian Orth Cc: Maarten Lankhorst , Michel =?UTF-8?B?RMOkbnplcg==?= , Christian =?UTF-8?B?S8O2bmln?= , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Dmitry Osipenko , Rob Clark , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/syncobj: Fix handle <-> fd ioctls with dirty stack Message-ID: <20260303195835.4c23be7a@pumpkin> In-Reply-To: References: <20260301-point-v1-1-21fc5fd98614@gmail.com> <3c969254-ed38-4b13-84b3-5afa365b04cb@amd.com> <2b75199f-b78a-4915-8e75-5d186f63f7c5@mailbox.org> <88726fec-3bbb-4ca8-b724-c281b5696324@linux.intel.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, 3 Mar 2026 18:44:59 +0100 Julian Orth wrote: > On Tue, Mar 3, 2026 at 6:41=E2=80=AFPM Maarten Lankhorst > wrote: > > > > My point is that it works for old userspace without problems. It's only > > newly compiled userspace with new headers that will run into problems. > > The code as written would have continued to work, but if you update to > > the new header and don't initialise the new members then it's a userspa= ce > > problem. It should not be worked around in the kernel, since it's newly > > written bad userspace code, not old bad userspace code that stopped wor= king > > when the kernel changed. =20 >=20 > But it's not newly written. The example is, say, 5 year old code. The > binary that was compiled 5 years ago works fine as you say. But if you > take the same code and just run gcc again, the new binary will no > longer work. >=20 Worse, the recompiled version may well work when you test it, and even when deployed. But you'll get non-obvious random failures - a support nightmare. Probably best code is something like: case OLD_IOCTL_CODE: if (ioc->flag & NEW_FLAG) return -EINVAL; /* FALLTHROUGH *. case NEW_IOCTL_CODE: if (!(ioc->flag & NEW_FLAG)) ioc->new_field =3D 0; David