From: Conor Dooley <conor@kernel.org>
To: Tom Rini <trini@konsulko.com>
Cc: u-boot@lists.denx.de, Simon Glass <sjg@chromium.org>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Simon Glass <simon.glass@canonical.com>,
Sughosh Ganu <sughosh.ganu@arm.com>
Subject: Re: [PATCH] kbuild: unexport sub_make_done to fix child make invocations
Date: Wed, 4 Mar 2026 09:54:22 +0000 [thread overview]
Message-ID: <20260304-robe-praising-5509e3a984cd@spud> (raw)
In-Reply-To: <177256385549.3975993.592734328770415000.b4-ty@konsulko.com>
[-- Attachment #1: Type: text/plain, Size: 1858 bytes --]
On Tue, Mar 03, 2026 at 12:50:55PM -0600, Tom Rini wrote:
> On Fri, 13 Feb 2026 19:47:34 -0700, Simon Glass wrote:
>
> > The exported sub_make_done variable leaks into the environment of all
> > child processes. When make targets like tcheck spawn independent make
> > invocations with O=, those child makes inherit sub_make_done=1, skip
> > the KBUILD_OUTPUT setup and try to build in the source tree.
> >
> > There is a workaround that resets sub_make_done to 0 for specific test
> > targets, but this isn't great since it has tolist every target that
> > spawns independent make invocations.
> >
> > [...]
>
> Applied to u-boot/master, thanks!
>
> [1/1] kbuild: unexport sub_make_done to fix child make invocations
> commit: 4284306d22c5b6d64ecd62b462551d9d313c8104
This breaks the build for me:
make ARCH=riscv CROSS_COMPILE=riscv64-unknown-linux-gnu- O=build microchip_mpfs_generic_defconfig
GEN Makefile
#
# configuration written to .config
#
make ARCH=riscv CROSS_COMPILE=riscv64-unknown-linux-gnu- O=build
HOSTCC scripts/basic/fixdep
GEN Makefile
HOSTCC scripts/kconfig/conf.o
YACC scripts/kconfig/zconf.tab.[ch]
LEX scripts/kconfig/zconf.lex.c
HOSTCC scripts/kconfig/zconf.tab.o
HOSTLD scripts/kconfig/conf
scripts/kconfig/conf --syncconfig Kconfig
***
*** Configuration file ".config" not found!
***
*** Please run some configurator (e.g. "make oldconfig" or
*** "make menuconfig" or "make xconfig").
***
make[4]: *** [/stuff/u-boot/scripts/kconfig/Makefile:75: syncconfig] Error 1
make[3]: *** [/stuff/u-boot/Makefile:702: syncconfig] Error 2
make[2]: *** [../Makefile:189: __sub-make] Error 2
make[1]: *** No rule to make target 'include/config/auto.conf', needed by 'include/config/uboot.release'. Stop.
make: *** [Makefile:189: __sub-make] Error 2
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2026-03-04 9:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-14 2:47 [PATCH] kbuild: unexport sub_make_done to fix child make invocations Simon Glass
2026-03-03 18:50 ` Tom Rini
2026-03-04 9:54 ` Conor Dooley [this message]
2026-03-04 15:01 ` Tom Rini
2026-03-04 15:09 ` Conor Dooley
2026-03-04 15:11 ` Tom Rini
2026-03-04 15:24 ` Conor Dooley
2026-03-04 15:45 ` Tom Rini
2026-03-04 16:57 ` Ilias Apalodimas
2026-03-04 17:34 ` Tom Rini
2026-03-04 18:02 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260304-robe-praising-5509e3a984cd@spud \
--to=conor@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=simon.glass@canonical.com \
--cc=sjg@chromium.org \
--cc=sughosh.ganu@arm.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.