Re: [Buildroot] [PATCH] package/iniparser: new package

[cp0613@linux.alibaba.com]

On Tue, 03 Mar 2026 19:08:41 +0100, ju.o@free.fr wrote:

> > From: Chen Pei <cp0613@linux.alibaba.com>
> > 
> > The iniparser is a simple C library offering ini file parsing services.
> > 
> > ndctl[1] requires it.
> > 
> > [1] https://github.com/pmem/ndctl
> > 
> > Signed-off-by: Chen Pei <cp0613@linux.alibaba.com>
> > ---
> [...]
> > diff --git a/package/iniparser/iniparser.mk 
> > b/package/iniparser/iniparser.mk
> > new file mode 100644
> > index 0000000000..9034a1cb78
> > --- /dev/null
> > +++ b/package/iniparser/iniparser.mk
> > @@ -0,0 +1,14 @@
> > +################################################################################
> > +#
> > +# iniparser
> > +#
> > +################################################################################
> > +
> > +INIPARSER_VERSION = v4.2.6
> > +INIPARSER_SITE = 
> > https://gitlab.com/iniparser/iniparser/-/archive/$(INIPARSER_VERSION)
> > +INIPARSER_SOURCE = iniparser-$(INIPARSER_VERSION).tar.gz
> 
> Could you move the "v" from the _VERSION to _SITE and update _SOURCE,
> please? This will allow our version monitoring scripts to work better.
> We should preferably have:
> 
> INIPARSER_VERSION = 4.2.6
> INIPARSER_SITE = 
> https://gitlab.com/iniparser/iniparser/-/archive/v$(INIPARSER_VERSION)
> INIPARSER_SOURCE = iniparser-v$(INIPARSER_VERSION).tar.gz
> 
> Note: your initial submission was also reporting an error, which
> should be fixed indirectly with the change I propose. Please make
> sure to run the command "utils/docker-run make check-package" before
> sending patches. See:
> https://nightly.buildroot.org/manual.html#_preparing_a_patch_series
> 
> > +INIPARSER_INSTALL_STAGING = YES
> > +INIPARSER_LICENSE = MIT
> > +INIPARSER_LICENSE_FILES = LICENSE
> > +
> > +$(eval $(cmake-package))
> > --
> > 2.50.1
> 
> Also, quoting the Buildroot documentation at:
> https://nightly.buildroot.org/manual.html#DEVELOPERS
> """
> We ask developers adding new packages, new boards, or generally new 
> functionality in Buildroot, to register themselves in the DEVELOPERS 
> file. As an example, we expect a developer contributing a new package to 
> include in his patch the appropriate modification to the DEVELOPERS 
> file.
> """
> 
> Note that will received emails from the autobuilders in
> case of build failures, and from other developers using
> the get-developers script.
> 
> Could you add a new entry in the DEVELOPERS file registering
> yourself to this new package?
> 
> Could you send an updated v2 patch with those changes, please?
> 
Hi, Julien,

Thank you for your review and reminder. I will send an v2 patch,
update iniparser.mk, and add a new entry in the DEVELOPERS.

Thanks,
Pei

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot