From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00DB73988E5 for ; Wed, 4 Mar 2026 09:30:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772616642; cv=none; b=XB4kEyZZHlftFLx52BeSzP8nmKx6Pd5JMtztu9YLzTET6Y3DjZGCCRFmwUdoBjloVm1n3tMsO94t2M7C3u48slJGZdo2PNZiEnKSpUcTUxmsdVKonbsiH9fhlNCjGVQlujv72iIbT/IqxBRnRkEjMFM+6sV6l6BGiPkhgqGMyys= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772616642; c=relaxed/simple; bh=qyvL/iXE6+TakoKVVxVCaopqm1BpX+f7Q05dx5gBHDE=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=hd29anKsxZuWushZ9MjIhPrS5v/YSQAvKeGBKPKHZur9KGveU/Kg/L8QNtaRfHLuhbOQ5mR8uxy3wL9IV8ZBB8f9CU8XetAdRsnbBCKynQoCGnFYC4Jsqqa6UlP7NNi2gqYVQwPwS3HQoJGAPdkYwlJpSrfRRCdf4RFXZau/N7k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=b9sIRKFF; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="b9sIRKFF" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-48371bb515eso99247705e9.1 for ; Wed, 04 Mar 2026 01:30:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772616636; x=1773221436; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=BUzQoESoh9/PqMSFbMpuw4Pmh5IPXiGP/qvOjxX4wwo=; b=b9sIRKFFaokgkSrgeWrbA/ViOpJjWP1ViLK9R1Hc1//m2coegBzgKtpFqwevCmiACZ C7afbaacWCHtjdaHICcRaatb9x6ZEJn6NhG6Zj9DIWESFWJ1Wfs22M1hBHSvsJT6ov0y u+gbatvToXFWw4Ws1z6B810aDtF2H+NtjWSzWUXjnH2Uagh4gEk5+S1nkLp8lVzxzopS A1lgIkzEEAlqX7ANlEMButL3162rmrsjjiFCTqL06qEr4gqfcdGAwI6S5Z1yvtqPS7rR QeMeyyLIZ4ZsiMHZmsjBPBW/Gjz82S/2K6mHxq88plnIdodtUPQPjzOSR2cd/SZiIcXY bgtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772616636; x=1773221436; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=BUzQoESoh9/PqMSFbMpuw4Pmh5IPXiGP/qvOjxX4wwo=; b=IrkPwGLuGRs476iX01NSe0hvDqCjAq7r3kHJPe/fCvmYIOeBZHadaIFwuk5SFJWNnY txelgRyu1lpNGrHPjMVDuV1VTsKQA9fDgvLeJ8JeDkx4nvpvmEFljWPqyiUPkTRATnMk 5gU8MnavcNClQYmAVmLI2bE++iwU/XuKOpvOB/5jZCnp2zQ44XPOxWlhKyEvt/wgcYEv 0yeAzQcq7M03fMVLratkz9PYABnN4FKQXwc9c37Z0pEPokQ+/yUYK0EBDZS7/Ay/aeEp N/z2TrYZoB79Y6DS+oqE34upHp1E4X6HAzGgxmCcXs7Zx1yn3lQuxPBnWrQmOtHzRzt4 FDGA== X-Forwarded-Encrypted: i=1; AJvYcCXnEojShQ/Utvy6cRPzk4NRbwOe0neHe5pCQo+6c/DwtzJEWOR59crAQBp7L5pRKvdJG7Q=@vger.kernel.org X-Gm-Message-State: AOJu0Yx4Cf8bu1ZWdsqe903wLYV7CrWf0sR+U0TA0w2qPEEvTBpVeiv3 y5ixdcEInjEFyJNl0vXknwW21iBlZa+Ym8tAylyttoYqxFAllzt+dXtO X-Gm-Gg: ATEYQzwJiQKn9sG6kW+qXLfGwysrXKDc8E04gmIZVOnabKdOPAHg4xX1SNeFSDdlT4Y R5EIbVPP2ViON/lB90xRQ3UHtV8AASe3+OdRiXcBkU7fQlAM7/gXVT9pp6rxECzns3lF/Mo7mca GEfxmHM3bDMue7AQ3ItjJCoB/DB959HjzwN/Rg4Fle49PxF4DsqGl7kLCaQy60/15KRJzEiXQY8 iRKnWsR2e5okPKJbsXhu7fm9rAJwArTxB6lKJr15H/QztrP9SMipiaXv3W9U+NdVzeZs3eYJXf7 yFkufNlAXU28CFeMA4ESw7IxjHhjpmR9OapMtnl1j+9fmjYFn8lnTnftIS1u6bVYNtvhcSfU8hG pOfIV1KNPO+o2jbYtCWXZXYg8b/sWKs5282fujWzyX9MoTe5BUNeSVL5We9iI2vAo1JlwZX1XYX bwHSGu3QGwE2PsKgEbIlLwQrSyQhOItvAZrEWhy8eHgLHY+cuZmUS/cXTb2TbCC890 X-Received: by 2002:a05:600c:8b53:b0:483:498f:7963 with SMTP id 5b1f17b1804b1-4851989024emr19550785e9.26.1772616636117; Wed, 04 Mar 2026 01:30:36 -0800 (PST) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4851884225asm38972555e9.6.2026.03.04.01.30.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2026 01:30:35 -0800 (PST) Date: Wed, 4 Mar 2026 09:30:33 +0000 From: David Laight To: NeilBrown Cc: "Jeff Layton" , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, nvdimm@lists.linux.dev, fsverity@lists.linux.dev, linux-mm@kvack.org, netfs@lists.linux.dev, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-nilfs@vger.kernel.org, v9fs@lists.linux.dev, linux-afs@lists.infradead.org, autofs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-mtd@lists.infradead.org, jfs-discussion@lists.sourceforge.net, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, devel@lists.orangefs.org, linux-unionfs@vger.kernel.org, apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org, linux-integrity@vger.kernel.org, selinux@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org, netdev@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-fscrypt@vger.kernel.org, linux-xfs@vger.kernel.org, linux-hams@vger.kernel.org, linux-x25@vger.kernel.org, audit@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-can@vger.kernel.org, linux-sctp@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH v2 000/110] vfs: change inode->i_ino from unsigned long to u64 Message-ID: <20260304092559.554ac9a9@pumpkin> In-Reply-To: <177260561903.7472.14075475865748618717@noble.neil.brown.name> References: <20260302-iino-u64-v2-0-e5388800dae0@kernel.org> <1787281.1772535332@warthog.procyon.org.uk> <1c28e34c7167acf4e20c3e201476504135aa44e8.camel@kernel.org> <177260561903.7472.14075475865748618717@noble.neil.brown.name> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 04 Mar 2026 17:26:59 +1100 NeilBrown wrote: > On Tue, 03 Mar 2026, Jeff Layton wrote: > > On Tue, 2026-03-03 at 10:55 +0000, David Howells wrote: > > > Jeff Layton wrote: > > > > > > > This version splits the change up to be more bisectable. It first adds a > > > > new kino_t typedef and a new "PRIino" macro to hold the width specifier > > > > for format strings. The conversion is done, and then everything is > > > > changed to remove the new macro and typedef. > > > > > > Why remove the typedef? It might be better to keep it. > > > > > > > Why? After this change, internel kernel inodes will be u64's -- full > > stop. I don't see what the macro or typedef will buy us at that point. > > Implicit documentation? > ktime_t is (now) always s64, but we still keep the typedef; > > It would be cool if we could teach vsprintf to understand some new > specifier to mean "kinode_t" or "ktime_t" etc. But that would trigger > gcc warnings. A more interesting one would be something that made gcc re-write the format with the correct 'length modifier' for the parameter. That would save a lot of effort! David > > NeilBrown > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6E1DCEB7EB6 for ; Wed, 4 Mar 2026 09:30:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:To:From:Date:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=l6Gk0+qv/Yubq0iZYbM/JWJ8FcVwquevvNed17JmTdU=; b=DqVmPsH/GSN1MJwbs/r7+v7as9 0asD4Uh6JuKVJ1nba6IPx9bhBaH7bkOnBCVp//wvBY6YtGNAKloAaYct8Z/gcOuve4jAhxJs0v8hK WxRuGn72gzfALElBHpDosTCpIe16ekyiKJlNyVqU+Nrb3ciFLuv23Zdb/UZU0CxkMQRo=; Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1vxiZ6-0007KP-Rv; Wed, 04 Mar 2026 09:30:49 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1vxiZ5-0007KC-J3 for linux-f2fs-devel@lists.sourceforge.net; Wed, 04 Mar 2026 09:30:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:MIME-Version :References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=BUzQoESoh9/PqMSFbMpuw4Pmh5IPXiGP/qvOjxX4wwo=; b=EFRrGgDJ4okXalm9eTrbj7kbc3 p/3Rpy7aQVWAmgZQrvuDCbmzPPBzcHL2Lx1mtTYcsT1JwiF5FhEB2rGIL374fG8USdmz2oEVHkylL UUcFEekLTgP6QZayfK0CewQCSRpeNNW2qTg+mI9n6jeEZZGVLkkXwWAYAfUzl9baP84o=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:MIME-Version:References: In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=BUzQoESoh9/PqMSFbMpuw4Pmh5IPXiGP/qvOjxX4wwo=; b=jEP9HACvsEwoGgQmQAYNp8g1tm VOZLh62Oxos9sMd1sRg9lRe8H+BBeMZsafJTJepdULn04iWBPTynROJe14itH+QZWAEH3UeIosWQZ hxXoEudKB/EutTeoBLez+U1IHu0qfWNWvQ/t1Z9MpP+vtZKECe2FyNLPkpTRQFVyl7jQ=; Received: from mail-wm1-f42.google.com ([209.85.128.42]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1vxiZ6-0007eV-01 for linux-f2fs-devel@lists.sourceforge.net; Wed, 04 Mar 2026 09:30:48 +0000 Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-48371119eacso80386735e9.2 for ; Wed, 04 Mar 2026 01:30:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772616636; x=1773221436; darn=lists.sourceforge.net; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=BUzQoESoh9/PqMSFbMpuw4Pmh5IPXiGP/qvOjxX4wwo=; b=VAG2/OFjl2kHQw/xVwitdIOXKJvHGLOMIp9G5vUhpxYfvnnklNApZshY6wwcqPFQDT 80mmpcXyFWGQFEkXxKNPCLnLrjSqrXJkgq3h2XVGF9Ra0pzI7FtmR78HIGmSc/MhfHlE OQZs2hFtMO1YwUU32qGqC5e1k7kwdAcySYgc7Sfl7jPcPKtCEJ6tLjcdRTSL6rrY6oi5 dZRfy+2p8Rs6krdG7JIQvD+KoLRLEE/EZbjIVP6wvWbCHDw+G6weH02C0hUNd6L0r1wO +bcnSyK8t08xN/vHh4LV0wowHKNOfz/VyQoe+OMfVKw0ZjxXifLqFpK+R0Cb94cAw6Yt 8Xeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772616636; x=1773221436; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=BUzQoESoh9/PqMSFbMpuw4Pmh5IPXiGP/qvOjxX4wwo=; b=G564+bXKzuIgt2zR7KDTQMFCO3GF3XsUPocyxCAkfwnpiQ02BZbqDaSqBsfbhaLQqz +Qf25ygDcm+iFalmH0njkG3iYI1DLT/iKuDI/1/J3jYIP08wt9OxkorkI22shFTIEINW fZ4Six0ss+hBqt13PAsszVTJ6rOWtoHf9t+3A4+9T9ffUySesY1AvJQL1L9evPnTXaB0 jL1vZqx4OxiVgPcIn11199nP9tB1LeB6G+XKvBDwrgA85VxxyGW1KsqPl9X/nfTHbaGX EMh85PLVOfIg+65Aa4AU7fMCHvwcyp7zqtlWgsBQiQhEDOSWjP7sUAwvcsuhxbiho8zA y9jw== X-Forwarded-Encrypted: i=1; AJvYcCVH75zm5EYgANElD68Sl5oAbtqtRFTw/ip5PoPFwhpbEIBsXjieM2R7NTlaT1st+cS11+NwGGvzY0r6wFG2UXJo@lists.sourceforge.net X-Gm-Message-State: AOJu0YyvjVFv8tH/OJljUAtYl9cb8GgxjUxP89HYdljZDjUmUnXFSDFH 1/C6GqIvdb03SQ+FmuWiv+8wG833AKMHrf7hfxm+lMn76K48aVaW+1aU X-Gm-Gg: ATEYQzzrAK6tdvVpQ1/cFdFHC1GByX+sFc68qxcSUl1RQaiFKV7WqjpyuIHEqQTWaXg hW6BJ2yaiAeT2OwDj63FxztKsJiKw2Z+puXJltFClZkCyiL3sfJY+DufJg3TCkcQtZQn16CaLQ3 SipoKvyYmpQuCbnm4PJmF/cIvZZQxX5nQiYJAM7KHyyvoYGJur2P1FeBErBbCF+W4ilWArOF7lS LilOp1iAzNigENSN948NPOHW3Zi/qq3eiSj7cMXcSh3bDtfQT3kaDem71GqCgPwgFMu3+9+EgFe CoCKaJzcQ8O6wgVJV/MlrSLYNTY8Au9YyC0roOBfioBMzhPyVHdPnpxjqcfjKiQeuZQgBePU/Ml 1kTQ8XPums+pu53Gyvi8vPq9Z8ev+oJSDUXMAQ44uyXAM4gNAR0Qijj3A9ZHGypXqB6CKiwD4NO 92t+fM8OAhcIlk6XOzbC5SSZ0BS22IXi0NXbsv9PGbt7UhEZquFgIHyt858z1Ptjfj X-Received: by 2002:a05:600c:8b53:b0:483:498f:7963 with SMTP id 5b1f17b1804b1-4851989024emr19550785e9.26.1772616636117; Wed, 04 Mar 2026 01:30:36 -0800 (PST) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4851884225asm38972555e9.6.2026.03.04.01.30.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2026 01:30:35 -0800 (PST) Date: Wed, 4 Mar 2026 09:30:33 +0000 From: David Laight To: NeilBrown Message-ID: <20260304092559.554ac9a9@pumpkin> In-Reply-To: <177260561903.7472.14075475865748618717@noble.neil.brown.name> References: <20260302-iino-u64-v2-0-e5388800dae0@kernel.org> <1787281.1772535332@warthog.procyon.org.uk> <1c28e34c7167acf4e20c3e201476504135aa44e8.camel@kernel.org> <177260561903.7472.14075475865748618717@noble.neil.brown.name> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) MIME-Version: 1.0 X-Headers-End: 1vxiZ6-0007eV-01 Subject: Re: [f2fs-dev] [PATCH v2 000/110] vfs: change inode->i_ino from unsigned long to u64 X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nvdimm@lists.linux.dev, jfs-discussion@lists.sourceforge.net, Jeff Layton , dri-devel@lists.freedesktop.org, linux-unionfs@vger.kernel.org, linux-mm@kvack.org, linux-sctp@vger.kernel.org, linux-mtd@lists.infradead.org, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-x25@vger.kernel.org, linux-bluetooth@vger.kernel.org, amd-gfx@lists.freedesktop.org, codalist@coda.cs.cmu.edu, linux-ext4@vger.kernel.org, bpf@vger.kernel.org, devel@lists.orangefs.org, linux-trace-kernel@vger.kernel.org, ecryptfs@vger.kernel.org, selinux@vger.kernel.org, autofs@vger.kernel.org, apparmor@lists.ubuntu.com, linux-media@vger.kernel.org, linux-can@vger.kernel.org, linaro-mm-sig@lists.linaro.org, ocfs2-devel@lists.linux.dev, linux-fscrypt@vger.kernel.org, linux-hams@vger.kernel.org, ceph-devel@vger.kernel.org, linux-xfs@vger.kernel.org, fsverity@lists.linux.dev, linux-nfs@vger.kernel.org, netdev@vger.kernel.org, v9fs@lists.linux.dev, samba-technical@lists.samba.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-perf-users@vger.kernel.org, audit@vger.kernel.org, linux-security-module@vger.kernel.org, linux-fsdevel@vger.kernel.org, netfs@lists.linux.dev, linux-integrity@vger.kernel.org, ntfs3@lists.linux.dev Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Wed, 04 Mar 2026 17:26:59 +1100 NeilBrown wrote: > On Tue, 03 Mar 2026, Jeff Layton wrote: > > On Tue, 2026-03-03 at 10:55 +0000, David Howells wrote: > > > Jeff Layton wrote: > > > > > > > This version splits the change up to be more bisectable. It first adds a > > > > new kino_t typedef and a new "PRIino" macro to hold the width specifier > > > > for format strings. The conversion is done, and then everything is > > > > changed to remove the new macro and typedef. > > > > > > Why remove the typedef? It might be better to keep it. > > > > > > > Why? After this change, internel kernel inodes will be u64's -- full > > stop. I don't see what the macro or typedef will buy us at that point. > > Implicit documentation? > ktime_t is (now) always s64, but we still keep the typedef; > > It would be cool if we could teach vsprintf to understand some new > specifier to mean "kinode_t" or "ktime_t" etc. But that would trigger > gcc warnings. A more interesting one would be something that made gcc re-write the format with the correct 'length modifier' for the parameter. That would save a lot of effort! David > > NeilBrown > _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 44420EB7EAC for ; Wed, 4 Mar 2026 09:30:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6gZlPAzpS6TMMePbrRJqtXpnIpL2KrFrUimTpwJC1J4=; b=MVtMBmdpykPbPE bMnM0M3dYa75UKtO95AlE0K7NnJMGoP+uH8SGK4IPAssRPl5qrNGVfaHCa+muBP02NPPKKJGRBwNu J2fyTC0LosuLh1KRYGhVN+p04zimbnR3SnTjGdXlYc3ObsdIKmWpcFduMwlcFCIgxxAHpCGFyxjP6 mVNswMs4YXzLZ8JlqogI2CU3laKNmEyQO/RMDesytxSDkDmmqzhctf7mpGl+sSkWMn/sMAVyUIxba Xb0Enfyvimj4WcQVpcksA+1K/AtLPuqreG2p+rT8ppdE5+AjR3QELMJUNnSVLPZQwapiPScPeDCCd 09Q3JuqDANvWsx9fl0CQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vxiYz-0000000GsD8-07ly; Wed, 04 Mar 2026 09:30:41 +0000 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vxiYw-0000000GsCO-2YLT for linux-mtd@lists.infradead.org; Wed, 04 Mar 2026 09:30:39 +0000 Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-48371119eacso80386785e9.2 for ; Wed, 04 Mar 2026 01:30:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772616636; x=1773221436; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=BUzQoESoh9/PqMSFbMpuw4Pmh5IPXiGP/qvOjxX4wwo=; b=mQ0v5yLl3QjrrqgYQwZsLs5eLZjrUqAelQLO7LBclIxyI+vqh/xIs0i00ydBoFVcRi QGp28rcdZ3U/t2+nyOKJTFHt1yoYGWI4ZRC8PXZWB7BEpx9GtA32+bSXNUOSxSGO2SSb qRzVnVfa7tC41ln2fEIc8AUMSlQeN86SCzAuCOJf1FFC0ak2Pqs6WLlH+p8jH6GIGw3x pylEngAFtiF+gEn6q8FsB6uuKZyWAjmFBYM0JJuFC+9mU8JOCWf1KWW8hTsK3qLhwTHd MZ5J38S+RUUl3OR3d9tFU9WUtSb1+7vA+rKUNbC4Lzv6tR33wWij+Jem9ZB5JeYwCWL4 TmXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772616636; x=1773221436; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=BUzQoESoh9/PqMSFbMpuw4Pmh5IPXiGP/qvOjxX4wwo=; b=EUEmf9tDeCjw4A32JypIGmhpxWn4UwPLYOMY2e4l4fhhKmuoOcaF64jKNCL172kJW+ ckd742M9i1Vt2MEsdkFLmEjiA6vOR/z1uV/Vp3du5mZ9VMB4dt7VWn0HBBfV4TUmUrEB yhf7a/EobvEYwm8PooJxbKZoKf/rB6IpxO6OogtSOivTD12VADp8ZWvCQw7u9PB/ynfJ /bTe2ertEfxjygq95MYdLwv78LENLehf6Vu+0vfcKH6IxpnsxQ2azh5tCn/O+XGLt5/T KojCsE1tgCMhef7v3YaryYY+sxncAeOFD6jW7vhL35j/0h9HuILkCEle8g8QbhO0C5CH TLAw== X-Forwarded-Encrypted: i=1; AJvYcCVaw+pwaANjCpEIFpEnZmuUAN3biEgXSYVjRkyixUyFT+fLYIMRP0GI4EWID31aAH4UsI3sAc7JmJI=@lists.infradead.org X-Gm-Message-State: AOJu0Yxcui1Yrhg6pJi2rhWA76RrFrYIabygQeIbUjoM8wUlqIND7pYN PjPyEbRUmFzengjOSuskP6mo7UoweYKwJdZpYBXhBfV30wPHUhhcj9ih X-Gm-Gg: ATEYQzyDF+3/2iErChBfOC2PdJ/0chH7FaL88cPI1Ks2uZVqr/63nbIIQc3OAsT4V1Y 9Ln+iCgl14j/heIyaolz519e76OBFFxUQ7hMfd1vP7DOcbqjofHAvQh5CWgMwc6XaS89VheETJ0 M+jfBrjauOhAl2x4U0KejuuG3zMfSDCQ+e9yqoc3ufy93S/OrfqVgwSwHPDjY3rO5+sxL8wp14p JeV9Y7A0Swx/t/bHzntphpBgY6E4GUHyVKPiZ/KgEOuRgvqIFJNuxijS71mMzyd4MBDkmADgyXj 1tBQLr7vOLAlWwk3DAptn8lkH920qKZUrWp3rpAkjKvWugVh3aEYdoP7qIZA8kgo5T8gLwVZX7E aR7NJrcHxnzHGYZCiHOxi2dXHp2DXT4axz9OwU9kfTt+7RdkYdrp5EuoPa7j4sm/t5p6M0JDPlu kEF2lN4tvmkc84A4hN+byk1/Z/VfvHCI8MBPPQf5glxkVJ2p8xnn06JWrjE9vi5rRu X-Received: by 2002:a05:600c:8b53:b0:483:498f:7963 with SMTP id 5b1f17b1804b1-4851989024emr19550785e9.26.1772616636117; Wed, 04 Mar 2026 01:30:36 -0800 (PST) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4851884225asm38972555e9.6.2026.03.04.01.30.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2026 01:30:35 -0800 (PST) Date: Wed, 4 Mar 2026 09:30:33 +0000 From: David Laight To: NeilBrown Cc: "Jeff Layton" , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, nvdimm@lists.linux.dev, fsverity@lists.linux.dev, linux-mm@kvack.org, netfs@lists.linux.dev, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-nilfs@vger.kernel.org, v9fs@lists.linux.dev, linux-afs@lists.infradead.org, autofs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-mtd@lists.infradead.org, jfs-discussion@lists.sourceforge.net, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, devel@lists.orangefs.org, linux-unionfs@vger.kernel.org, apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org, linux-integrity@vger.kernel.org, selinux@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org, netdev@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-fscrypt@vger.kernel.org, linux-xfs@vger.kernel.org, linux-hams@vger.kernel.org, linux-x25@vger.kernel.org, audit@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-can@vger.kernel.org, linux-sctp@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH v2 000/110] vfs: change inode->i_ino from unsigned long to u64 Message-ID: <20260304092559.554ac9a9@pumpkin> In-Reply-To: <177260561903.7472.14075475865748618717@noble.neil.brown.name> References: <20260302-iino-u64-v2-0-e5388800dae0@kernel.org> <1787281.1772535332@warthog.procyon.org.uk> <1c28e34c7167acf4e20c3e201476504135aa44e8.camel@kernel.org> <177260561903.7472.14075475865748618717@noble.neil.brown.name> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260304_013038_669371_30957187 X-CRM114-Status: GOOD ( 22.01 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Wed, 04 Mar 2026 17:26:59 +1100 NeilBrown wrote: > On Tue, 03 Mar 2026, Jeff Layton wrote: > > On Tue, 2026-03-03 at 10:55 +0000, David Howells wrote: > > > Jeff Layton wrote: > > > > > > > This version splits the change up to be more bisectable. It first adds a > > > > new kino_t typedef and a new "PRIino" macro to hold the width specifier > > > > for format strings. The conversion is done, and then everything is > > > > changed to remove the new macro and typedef. > > > > > > Why remove the typedef? It might be better to keep it. > > > > > > > Why? After this change, internel kernel inodes will be u64's -- full > > stop. I don't see what the macro or typedef will buy us at that point. > > Implicit documentation? > ktime_t is (now) always s64, but we still keep the typedef; > > It would be cool if we could teach vsprintf to understand some new > specifier to mean "kinode_t" or "ktime_t" etc. But that would trigger > gcc warnings. A more interesting one would be something that made gcc re-write the format with the correct 'length modifier' for the parameter. That would save a lot of effort! David > > NeilBrown > ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/