All of lore.kernel.org
 help / color / mirror / Atom feed
From: Igor Mammedov <imammedo@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
	"Michael S . Tsirkin" <mst@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Eduardo Habkost" <eduardo@habkost.net>,
	"Yanan Wang" <wangyanan55@huawei.com>,
	"Zhao Liu" <zhao1.liu@intel.com>,
	"Jason Wang" <jasowang@redhat.com>, "Yi Liu" <yi.l.liu@intel.com>,
	"Clément Mathieu--Drif" <clement.mathieu--drif@eviden.com>,
	"Fabiano Rosas" <farosas@suse.de>,
	"Laurent Vivier" <lvivier@redhat.com>
Subject: Re: [PATCH v2 16/16] tests/qtest/test-x86-cpuid-compat: Remove the test with the i440fx-2.9 machine
Date: Wed, 4 Mar 2026 12:26:16 +0100	[thread overview]
Message-ID: <20260304122616.2485ebcf@imammedo> (raw)
In-Reply-To: <20260225092024.794595-17-thuth@redhat.com>

On Wed, 25 Feb 2026 10:20:24 +0100
Thomas Huth <thuth@redhat.com> wrote:

> From: Thomas Huth <thuth@redhat.com>
> 
> The machine has been removed, so the related test can now be removed, too.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Reviewed-by: Igor Mammedov <imammedo@redhat.com>

> ---
>  tests/qtest/test-x86-cpuid-compat.c | 11 -----------
>  1 file changed, 11 deletions(-)
> 
> diff --git a/tests/qtest/test-x86-cpuid-compat.c b/tests/qtest/test-x86-cpuid-compat.c
> index 5e0547e81b7..c534e764f82 100644
> --- a/tests/qtest/test-x86-cpuid-compat.c
> +++ b/tests/qtest/test-x86-cpuid-compat.c
> @@ -343,17 +343,6 @@ int main(int argc, char **argv)
>                     "486", "xlevel2=0xC0000002,xstore=on",
>                     NULL, "xlevel2", 0xC0000002);
>  
> -    /* Check compatibility of old machine-types that didn't
> -     * auto-increase level/xlevel/xlevel2: */
> -    if (qtest_has_machine("pc-i440fx-2.9")) {
> -        add_cpuid_test("x86/cpuid/auto-level7/pc-i440fx-2.9/off",
> -                       "Conroe", NULL, "pc-i440fx-2.9",
> -                       "level", 10);
> -        add_cpuid_test("x86/cpuid/auto-level7/pc-i440fx-2.9/on",
> -                       "Conroe", "erms=on", "pc-i440fx-2.9",
> -                       "level", 10);
> -    }
> -
>      /* Test feature parsing */
>      add_feature_test("x86/cpuid/features/plus",
>                       "486", "+arat",



  parent reply	other threads:[~2026-03-04 11:26 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-25  9:20 [PATCH v2 00/16] hw/i386/pc: Remove deprecated 2.8 and 2.9 PC machines Thomas Huth
2026-02-25  9:20 ` [PATCH v2 01/16] hw/i386/pc: Remove deprecated pc-q35-2.8 and pc-i440fx-2.8 machines Thomas Huth
2026-02-25  9:20 ` [PATCH v2 02/16] hw/i386/pc: Remove pc_compat_2_8[] array Thomas Huth
2026-02-25  9:20 ` [PATCH v2 03/16] hw/i386/kvm: Remove KVMClockState::mach_use_reliable_get_clock field Thomas Huth
2026-02-25  9:20 ` [PATCH v2 04/16] hw/core/machine: Remove hw_compat_2_8[] array Thomas Huth
2026-02-25  9:20 ` [PATCH v2 05/16] hw/block/pflash: Remove PFlashCFI01::old_multiple_chip_handling field Thomas Huth
2026-02-25  9:20 ` [PATCH v2 06/16] hw/pci/pcie: Remove QEMU_PCIE_EXTCAP_INIT definition Thomas Huth
2026-02-25  9:20 ` [PATCH v2 07/16] hw/virtio/virtio-pci: Remove VIRTIO_PCI_FLAG_INIT_DEVERR definition Thomas Huth
2026-02-25  9:20 ` [PATCH v2 08/16] hw/virtio/virtio-pci: Remove VIRTIO_PCI_FLAG_INIT_LNKCTL definition Thomas Huth
2026-02-25  9:20 ` [PATCH v2 09/16] hw/virtio/virtio-pci: Remove VIRTIO_PCI_FLAG_INIT_PM definition Thomas Huth
2026-02-25  9:20 ` [PATCH v2 10/16] hw/i386/pc: Remove deprecated pc-q35-2.9 and pc-i440fx-2.9 machines Thomas Huth
2026-02-25  9:20 ` [PATCH v2 11/16] hw/i386/pc: Remove pc_compat_2_9[] array Thomas Huth
2026-02-25  9:20 ` [PATCH v2 12/16] hw/core/machine: Remove hw_compat_2_9[] array Thomas Huth
2026-02-25  9:20 ` [PATCH v2 13/16] hw/net/virtio-net: Remove VirtIONet::mtu_bypass_backend field Thomas Huth
2026-02-25  9:20 ` [PATCH v2 14/16] hw/pci-bridge/gen_pcie_rp: Remove GenPCIERootPort::migrate_msix field Thomas Huth
2026-02-25  9:20 ` [PATCH v2 15/16] hw/i386/x86-iommu: Remove X86IOMMUState::pt_supported field Thomas Huth
2026-03-04 11:25   ` Igor Mammedov
2026-02-25  9:20 ` [PATCH v2 16/16] tests/qtest/test-x86-cpuid-compat: Remove the test with the i440fx-2.9 machine Thomas Huth
2026-02-25 18:26   ` Fabiano Rosas
2026-03-04 11:26   ` Igor Mammedov [this message]
2026-03-03 14:00 ` [PATCH 17/16] hw/southbridge/ich9: Remove ICH9_LPC_SMI_F_BROADCAST_BIT definition Igor Mammedov
2026-03-04 17:20   ` Thomas Huth
2026-03-05 12:10     ` Igor Mammedov
2026-03-05 12:33       ` Thomas Huth
2026-03-05 14:32         ` Igor Mammedov
2026-03-05 16:06           ` Igor Mammedov
2026-03-05 16:06   ` [PATCH v3 " Igor Mammedov
2026-03-05  7:26 ` [PATCH v2 00/16] hw/i386/pc: Remove deprecated 2.8 and 2.9 PC machines Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260304122616.2485ebcf@imammedo \
    --to=imammedo@redhat.com \
    --cc=clement.mathieu--drif@eviden.com \
    --cc=eduardo@habkost.net \
    --cc=farosas@suse.de \
    --cc=jasowang@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    --cc=wangyanan55@huawei.com \
    --cc=yi.l.liu@intel.com \
    --cc=zhao1.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.